🇦🇺Australia @Toby Wild

p_stampy → credited toby wild → .

Hi,

I've just had this issue come up on a client site. The fact they are allowed to set a 10 minute validation for the TFA token, but the timeout is hardcoded to 5 minutes makes for a very confusing user experience.

The "workaround" is that if they try to use the code after the 5 minutes, and get the Access Denied error, they can re-login and use the code rather than requesting a new one is ok in the short term.

Wouldn't it make more sense that on form submit for the TFA module configuration, if the email validity period is greater than 5 minutes, it automatically updates the timeout to match that selected value, and if it's less than 5 minutes, it defaults to 5 minutes.

Also having the same issue. In a 24 hour period, a site that I manage had almost 14,000 logs of:

Channel: access denied
Level: WARNING
Message: Path: XXXX. Drupal\Core\Http\Exception\CacheableAccessDeniedHttpException: The 'view any unpublished content' permission is required. in Drupal\Core\Routing\AccessAwareRouter->checkAccess() (line 115 of /app/web/core/lib/Drupal/Core/Routing/AccessAwareRouter.php).
UID: 0

While I'm sure this is expected behaviour in the code, I would suggest that User 0 would realistically never be given "view any unpublished content' permission, and as such, this isn't something worth logging as a Warning.

The user was provided the correct 403 page response, which is the expected behaviour for this interaction.

I would say that there is nothing to Warn about in this instance.

Apologies John, I don't know how to write unit tests, however I can also confirm the same behaviour.

Using the patch from #275, when a facet is activated, the search occurs, all other facet elements in the same facet group are given a 'disabled=disabled' attribute.

If there are other facets on the page, they are still active and working, however only until you use a single facet in each group.

Manually removing the disabled=disabled attribute makes the inputs interact-able, but doesn't actually trigger a search.

An error message is reported in the console:

Session has not been set.

toby wild → created an issue.

Yeh that make sense.

For example, running: civictheme_get_field_value($node, 'field_thumbnail') would return the equivalent of civictheme_media_get_variables('field_thumbnail') after it's done all the checks and balances.

civictheme_media_get_variables returns everything you need to display an image via image_style, or to provide a link to a PDF.

toby wild → created an issue.

toby wild → created an issue.

gargsuchi → credited Toby Wild → .

gargsuchi → credited Toby Wild → .

Hi smethawee.

This worked for me today:

In the directory /themes/civictheme

On the command line I ran:

php civictheme_create_subtheme.php cttesttheme "Test Theme" "Human theme description" ../cttest

Breaking that down it goes as:

1. php: running a PHP command on the command line
2. civictheme_create_subtheme.php: Triggering that file
3. cttestheme: That is the machine name of the theme I want to create
4. "Test Theme": Is the human readable name
5. "Humn theme description": That is the theme description
6. ../cttest: Means go back one directory (Back into /themes) and create it in the new folder "cttest"

If you just straight up copy and paste the suggested command without changing the theme machine name and path arguments, it wont work.

If this doesn't work for you, can you provide what error you are seeing, or what outcome is happening at all?

Toby Wild → created an issue.

Toby Wild → created an issue.

Clarifying my above suggestion:

/**
 * Preprocess block function to add additional cache context on Banner block.
 */
function <THEMENAME>_preprocess_block(&$variables) {
  if ($variables['base_plugin_id'] != 'block_content') {
    return;
  }

  $node = \Drupal::routeMatch()->getParameter('node');
  $block = $variables['elements']['content']['#block_content'];

  // If the node is not loaded, adjust the cache max-age of the banner block to -1.
  if ($block && $block->bundle() == 'civictheme_banner' && !$node) {
    $variables['#cache']['max-age'] = 0;
  }
}

Adding a pre_process function to the theme should fix this.

function <THEMENAME>_preprocess_block(&$variables) {

  if ($variables['configuration']['label'] && $variables['configuration']['label'] == 'Banner') {
    $variables['#cache']['contexts'][] = 'user';
  if ($variables['base_plugin_id'] != 'block_content') {
    return;
  }

  /** @var \Drupal\node\Entity\Node $node */
  $node = \Drupal::routeMatch()->getParameter('node');

  $block = $variables['elements']['content']['#block_content'];

  // If the node is not loaded, adjust the cache max-age of the banner block to -1.
  if ($block && $block->bundle() == 'civictheme_banner' && !$node) {
    $variables['#cache']['max-age'] = 0;
  }
}

Kristen Pol → credited Toby Wild → .

Hi.

I have tested the current 1.x-dev branch and everything appears to be working correctly, however it is showing a failed Gitlab CI Pipeline (https://git.drupalcode.org/project/consultation/-/jobs/855721)

But all the issues outlined above appear to be implemented and working.

Kristen Pol → credited Toby Wild → .

Toby Wild → created an issue.

Pushed change to issue fork that wraps the code that changes the to_mail variable to check if we are coming from the webform_submission_resend form.

Also tested this code to ensure it still works when normal submissions are submitted, and everything appears to work correctly.

$_POST['form_id'] should always exist, as this is a FormHandler, which by definition must always be submitted from a Form with a form_id.

https://git.drupalcode.org/project/consultation/-/merge_requests/6

Toby Wild → created an issue.

Toby Wild → created an issue.

Had the same issue, and can confirm that changing array_flip to array_keys solved it.

Also now getting this error:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "civictheme_one_column" plugin does not exist. Valid plugin IDs for Drupal\Core\Layout\LayoutPluginManager are: layout_twocol_section, layout_threecol_section, layout_fourcol_section, layout_onecol, layout_twocol, layout_twocol_bricks, layout_threecol_25_50_25, layout_threecol_33_34_33, layout_builder_blank in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 53 of /Users/tobywild/Sites/second/web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

Toby Wild → created an issue.

Toby Wild → created an issue.

Toby Wild → created an issue.

Toby Wild → created an issue.

Toby Wild → created an issue.

Toby Wild → created an issue.