fionamorrison23 → credited richardgaunt → .
fionamorrison23 → credited richardgaunt → .
fionamorrison23 → credited richardgaunt → .
fionamorrison23 → credited richardgaunt → .
richardgaunt → created an issue.
richardgaunt → created an issue.
Working as expected false test fail.
We are using theme_hook now and this removed the div with the class `table-of-contents-container` in the Drupal template. Test updated and issue fixed.
richardgaunt → created an issue.
richardgaunt → created an issue.
richardgaunt → created an issue.
gargsuchi → credited richardgaunt → .
richardgaunt → created an issue.
richardgaunt → created an issue.
richardgaunt → created an issue.
Changes to the extend model
1. Currently, it is possible to override a part of the component, a whole component or create a custom component in the sub-theme. This allows to only override parts of components with a minimum blueprint and, at the same time, rely on upstream. This makes CT-based sites easy to maintain, because only a specific set overrides would need to be supported. Could you please elaborate how this feature change?
The supported inheritance / extension types of Single Directory Components are:
- Custom component in sub-theme
- Override CivicTheme component
But not: Extend CivicTheme component - we will be moving more towards the SDC model meaning after the release of SDC you will not be able to extend the original CivicTheme component.
For existing sites that have extended CivicTheme components recommend one of the following options:
1. Convert those components to a overridden component
2. Create a custom component of the original CivicTheme component and extend that in your existing sub-theme component
Single Directory Components
UI Kit is being converted to support multiple component libraries, the original twig component library will be maintained, there will now be a second component library (Single Directory Components) being maintained.
The original twig component will continue to not include any Drupal specific pieces of functionality.
The Single Directory components will continue to mirror the twig components just the namespacing and the bundling of the component YML and css files will be the changes.
Changes to the UI Kit structure and Design System
This is not part of this project - there is continued discussions but no plans on the evolution of CivicTheme design system. This will be tackled in future issues and plans.
Why SDC
SDC allows CivicTheme to utilise the core component system and opens up future work integrating with experience builder and other new development features appearing within the Drupal ecosystem
richardgaunt → created an issue.
@thisisalistairsaccount
We have a long running PR to fix this but there is no easy solution. At the moment, CivicTheme works out which menu to render based on the menu name.
We have not been able to get to a good solution on how to configure within Drupal (within the theme system) a menu block to render a menu with a certain theme.
richardgaunt → created an issue.
richardgaunt → created an issue.
richardgaunt → created an issue.
I am all good I made a local patch to fix for my purposes.
https://git.drupalcode.org/issue/external_entities-3516546/-/jobs/4830977
Tests are failing with this change but won't fix until I know the direction to take.
Created a MR that fixes this issue:
https://git.drupalcode.org/project/external_entities/-/merge_requests/81
Not sure whether inheritance should be this way as ConfigurableExternalEntityTypeInterface feels like an extension on ExternalEntityTypeInterface but its a starting point.
richardgaunt → created an issue.
richardgaunt → created an issue.
richardgaunt → created an issue.
fionamorrison23 → credited richardgaunt → .
richardgaunt → created an issue.
Thanks I think we have solved this issue.
We are now developing directly on Drupal 11 and we have added patches for any modules that CivicTheme relies on in composer to make them Drupal 11 compatible.
These fixes are being released with CivicTheme 1.10 which is being released today.
Hi,
We have created some recipes to get CivicTheme started in Drupal CMS. These will activate and setup CivicTheme with some default content to get you started:
https://github.com/civictheme/upgrade-tools
Here is the PR with explanation
https://github.com/civictheme/upgrade-tools/pull/3
This will work with the upcoming release of Civictheme 1.10.
Fixes have been implemented and we are now developing on D11 in our development environment. Marking this as fixed for upcoming release.
We have created a repository for this update script (details being outlined in the release notes of 1.10)
PR for this update script and screenshots
https://github.com/civictheme/upgrade-tools/pull/1
Repository to get this script from: https://github.com/civictheme/upgrade-tools
We are adding a recipe to enable on Drupal CMS: https://github.com/civictheme/upgrade-tools/pull/3 please see the drupal-cms recipes directory.
We have solutions for these upcoming in the release being prepared and scheduled for tomorrow. There will be an alpha recipe for installing on Drupal CMS and we are now developing on Drupal 11.
We are using the following patches for incompatible modules. To install these module dependencies on Drupal 11 add these patches to your composer.json:
"drupal/simple_sitemap": {
"Error on installing / enabling simple_sitemap in D11: https://www.drupal.org/project/simple_sitemap/issues/3507718": "./patches/modules/simple_sitemap/fix-error-on-install.patch"
},
"drupal/styleguide": {
"Create Drupal 11 test release: https://www.drupal.org/project/styleguide/issues/3505640": "https://git.drupalcode.org/project/styleguide/-/merge_requests/23.patch"
}PR created and merged: https://github.com/civictheme/monorepo-drupal/pull/1359
richardgaunt → created an issue.
richardgaunt → created an issue.
jct321 → credited richardgaunt → .