Melbourne
Account created on 30 March 2015, over 9 years ago
#

Merge Requests

Recent comments

🇦🇺Australia RichardGaunt Melbourne

Yes the purpose is for this to be a utility to get values for a variety of different field types. As you say it only handles file type of media it would be good if it could be used for video

🇦🇺Australia RichardGaunt Melbourne

So from my understanding of your issue there is a need to implement an alter hook that allows the overriding / setting of the view filters.
Like:
`hook_civictheme_automated_list_view_arguments_alter` ?

🇦🇺Australia RichardGaunt Melbourne

We are making changes to how form's behave in 1.9 to fallback to Drupal if CivicTheme does not support a form element but this is not a form element we have plans for delivering first party support for at the moment.

🇦🇺Australia RichardGaunt Melbourne

@sime

This is our proposed fix.

Update civictheme_media_get_variables to handle the OEmbed (remote video).

We want to only return the properties that are useful for remote video:

<ul>
  <li>name</li>
  <li>url</li>
  <li>created</li>
  <li>updated</li>
  <li></li>
</ul>

Do not return other properties.

Does this align with your thinking?

🇦🇺Australia RichardGaunt Melbourne

A fix has been merged to develop and is being tested.

🇦🇺Australia RichardGaunt Melbourne

Hi Sonny,

This has been fixed in the 1.8 release and the form working being progressed at the moment is taking this into account.

🇦🇺Australia RichardGaunt Melbourne

@alex.skrypnyk title attribute only works when no text is in the tag and so yes your PR would work. The PR that has been committed
also works because it adds visually hidden text.

https://github.com/civictheme/uikit/pull/391

We might add your change to provide a tooltip for back to top as this would be nice feature to have but on this issue at hand both work correctly.

🇦🇺Australia RichardGaunt Melbourne

WE are actively working on this branch to create an opt-in system for form element preprocessing rather than the current opt-out.

https://github.com/civictheme/monorepo-drupal/pull/1306

The ck editor webform fields are something we are testing and ensuring are working before we are releasing a fix.

🇦🇺Australia RichardGaunt Melbourne

We have this issue being actively worked on, apologies for the delays.

🇦🇺Australia RichardGaunt Melbourne

@alan.cole Can you please review this and let me know if it solves your problem?

🇦🇺Australia RichardGaunt Melbourne

Thanks @amey and @sourojeetpaul.

Reviewing this change with @alancole: adding an `aria-label` as in your patch will duplicate the `aria-label` when the link opens in a new window and so we need to refine the solution slightly.

We are looking into the separate issue use of `aria-label` in the below issue as we believe we can remove the "Opens new window".

https://github.com/civictheme/uikit/issues/389

But for your issue of their not being an accessible back to top element we are suggesting the following:

Update back to top twig:

uikit/components/02-molecules/back-to-top/back-to-top.twig

<div class="ct-back-to-top" data-component-name="back-to-top" data-scrollspy data-scrollspy-offset="400">
  {% include '@atoms/button/button.twig' with {
    kind: 'link',
    type: 'primary',
    icon: 'up-arrow',
    url: '#top',
    text: '<span class="ct-visually-hidden">Return focus to the top of the page</span>',
    allow_html: true,
    modifier_class: 'ct-back-to-top__button',
  } only %}

This will provide a visually hidden text element as part of the button that will be read out. I will have @joshua1234511 create a PR in `uikit`

🇦🇺Australia RichardGaunt Melbourne

Josh is working on a fix:

1. Move the menu theming code into a helper _civictheme_preprocess_primary_navigation_menu and _civictheme_preprocess_footer_menu:
2. Add theme settings to define the primary navigations and the footer navigation menus
3. Update the menu name check to check for these theme settings if ($menu_name === 'THEME_SETTING')
4. Add update hook to add new theme setting or at least at a default value for expected values in this code above

🇦🇺Australia RichardGaunt Melbourne

@sime I agree re: importance. I will look into and work out how to fix this week, apologies for slow reply.

🇦🇺Australia RichardGaunt Melbourne

We handle media with `civictheme_media_get_variables` and `civictheme_media_image_get_url` and `civictheme_media_image_get_url` due to its complexity and varied needs for a value.

Perhaps we should add support for media with returning `civictheme_media_get_variables` when passed to `civictheme_get_value`. Thoughts @toby?

🇦🇺Australia RichardGaunt Melbourne

Identified issue and suggest:

  1. Create civictheme_subject_card display mode and configure appropriately
  2. See civictheme_preprocess_node - create preprocess function: _civictheme_preprocess_node__subject_card.
    This function should provide the variables for subject card look to _civictheme_preprocess_node__civictheme_navigation_card for guidance on how to do this.
🇦🇺Australia RichardGaunt Melbourne

Thank you for the patch - 1.8.1 has had a lot of changes to form elements and there seems to be some issues sprouting out of this. I will be looking into these over the next week.

🇦🇺Australia RichardGaunt Melbourne

@javexed Apologies for the slow reply but did you manage to install civichteme with the blocks correctly placed?

There are installation instructions provided here:

https://docs.civictheme.io/development/drupal-theme

I have tried to replicate but when I have followed installation instructions it has worked.

🇦🇺Australia RichardGaunt Melbourne

My thoughts, there are three issues identified:

Allow alt text field to be left blank

This conflicts with practice of making

We need the ability for the alt text field on the media library to be:
- left blank, or
- allow for a decorative option, or
- allow for the alt test to overridden when inserting image into a web page.

🇦🇺Australia RichardGaunt Melbourne

Sorry on further inspection I see that we are using a REST display of alert content types see: /admin/structure/views/view/civictheme_alerts

The `visibility` field needs to be updated to strip tags to remove the `
` tags.

Same underlying cause but we have ability to change field output.

🇦🇺Australia RichardGaunt Melbourne

The fix updates the parsing of the incorrect "plain text" from the API but the root cause of this issue is in the `plain_text` field formatter which adds the twig filter `nlbr` to its processing.

https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...

The ideal fix will be to change the page visibility field to a multi-value plain text field so it provides an array of page visibility values and we can iterate over the values.

Due to this requiring a new field / update existing field and an upgrade path this will need to be considered.

For the meantime Josh's fix mitigates the issue

🇦🇺Australia RichardGaunt Melbourne

https://github.com/civictheme/civictheme_content

This is how CivicTheme generates content - can you utilise these methods to generate components to your needs.

🇦🇺Australia RichardGaunt Melbourne

@ugintl

The next step is to make a front page - you will need to go to Content and create a page and then to Configuration to set this page as the front page of your website

Just looking at the message on your screen its giving a link to the CivicTheme Docs page - https://www.civictheme.io/how-to-use-civictheme/getting-started-document...

Which gives pretty good starter instructions.

Any questions about this let me know.

🇦🇺Australia RichardGaunt Melbourne

Recommend running the composer command directly with the beta stability requirement should solve this:

composer require 'drupal/components:^3.0@beta'

This is a safeguard by composer against installing packages with non-release standard stability.

🇦🇺Australia RichardGaunt Melbourne

Thanks for the double check.

I spent some time trying to pin it down but can't see anything in my nginx.

I've had other issues with the 'snap'
installed version of firefox and did a clean install - and this has fixed the issue - go figure.

Thanks for your help.

🇦🇺Australia RichardGaunt Melbourne

I also get this error:

  • when I install the site with another theme other than CT
  • created a child CT theme
  • enabled this child theme
  • set as default
  • navigate to front page
🇦🇺Australia RichardGaunt Melbourne

@smethawa It looks like you are trying to run it in the wrong directory because it did not find the `civictheme_create_subtheme.php` file

You need to run the command in the civictheme file directory not your drupal root directory.

Production build 0.71.5 2024