- Issue created by @RichardGaunt
- Merge request !7Removed CivicTheme components from Layout templates. β (Closed) created by RichardGaunt
- π¦πΊAustralia alex.skrypnyk Melbourne
We looked deeper into the issue and it appears that the CivicTheme incorrectly uses layout functionality.
The layout template is expected to be available site-wide and, therefore, not supposed to contain any other template inclusions. For styling, the layout could reference a library (which in own turn can use CSS to style that layout). The expectation is that every theme is responsible for providing styles to support layouts.
At his point, it looks like we definitely need to simplify the layout template to not include any other components. We also need to look into shipping a standalone layout CSS file.
We also need to assess if it is worth ditching our custom layout in favour of the Drupal core's layouts markup and just add our own CSS (need to assess if that CSS is already provided by core).
Once the above investigations conducted, the results will be posted into this issue.
- πΊπΈUnited States jdleonard Austin, TX, USA
I ran into this as well while simply viewing a page node. It might have been using a sub-theme, but I hadn't made any changes to the sub-theme.
- Assigned to alex.skrypnyk
- πΊπΈUnited States jdleonard Austin, TX, USA
Copying the files changed by https://git.drupalcode.org/project/civictheme/-/merge_requests/7/diffs?c... into my sub-theme resolved the error for me.
- c2f1be52 committed on 1.x
Issue #3441713 by RichardGaunt: Layout error when another theme renders...
- c2f1be52 committed on 1.x
- Status changed to Fixed
6 months ago 2:30am 24 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.