Remove SDDS directories and files that will be built via npm

Created on 22 August 2024, 9 months ago
Updated 10 September 2024, 8 months ago

Problem/Motivation

For the initial set up of SDDS, we copied over CivicTheme and checked in the build artifacts as well. This makes the codebase bloated.

Steps to reproduce

Proposed resolution

We should remove those build artifacts, add those build files/directories to .gitignore, and update the README and docs to make sure the build steps is included.

Remaining tasks

  • Identify minimal amount of files/directories needed in codebase
  • Identify the files/directories that are built with npm run build for base theme and subtheme
  • Update .gitignore to not include these built files/directories
  • Update README and dev guide with correct steps to install base theme and subtheme
  • Create MR with changes
  • Review and test per below
  • Commit :)

Testing:

  • Go through the process of installation with composer require, npm run build, and drush theme:install
  • Check both themes show up in list of themes and both theme settings can be edited
  • Check both themes have their Storybook available within their theme settings

User interface changes

Nothing in the UI but files/directories in theme will be tidier out-of-the-box.

API changes

Data model changes

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States Kristen Pol Santa Cruz, CA, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024