- Issue created by @Kristen Pol
- Assigned to joshua1234511
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Assigning to Joshua for next week.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Note that if we have to change the Twig namespaces to SDC syntax then Storybook won't be testable. See 📌 Reconcile components vs SDC namespaces for SDDS includes/embeds Postponed .
- First commit to issue fork.
- Merge request !31Removed SDDS directories and files that will be built via npm → (Merged) created by joshua1234511
- Assigned to Kristen Pol
- Status changed to Needs review
9 months ago 10:04am 27 August 2024 - 🇮🇳India joshua1234511 Goa
MR: https://git.drupalcode.org/project/demo_design_system/-/merge_requests/31
Task
Identified minimal amount of files/directories that are built with npm run build for base theme and subtheme
Updated .gitignore to not include these built files/directories
Update README and dev guide with correct steps to install base theme and subthemeReviewed and tested locally
Following steps from https://www.drupal.org/community-initiatives/starshot-demo-design-system... →Update README and dev guide with correct steps to install base theme and subtheme
- No update required as steps already added
https://www.drupal.org/community-initiatives/starshot-demo-design-system... →
Step 3: Configure and enable base theme
Step 5: n addition to enabling the base civictheme theme, we have a subtheme with the custom branding and components for Drupal CMS, so we need to configure and enable that too - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Code changes look good. I'll test :)
- Status changed to RTBC
9 months ago 5:45pm 27 August 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
This is working well. I'll get it merged.
- Issue was unassigned.
- Status changed to Fixed
9 months ago 5:46pm 27 August 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Just double checked:
https://git.drupalcode.org/project/demo_design_system
against:
https://github.com/civictheme/monorepo-drupal/tree/develop/web/themes/co...
and it looks similar. Of course, we have components and starshot_demo but that's to be expected.
Automatically closed - issue fixed for 2 weeks with no activity.