- Issue created by @Kristen Pol
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Actually, let's get rid of the header and footer as part of updating
page--front.html.twig
. Then we don't have to worry about those right now. - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
It can be put here:
demo_design_system/starshot_demo/templates/page--front.html.twig
- Assigned to Akhil Babu
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks 🙏 Keep in mind we are breaking up some of the bigger components into smaller components over the couple days but I think this work can still start if you have time
- 🇮🇳India Akhil Babu Chengannur
I have created the front page with the given components.
Hero (starshot-hero2), Four column with icon cards, and Testimonial components render perfectly while the others have few styling issues
- 🇮🇳India Akhil Babu Chengannur
Just noting down the findings
- Heading
Should be aligned with the icon cards section
- Case Study (starshot-case-study2)
Image overlapped with the text as logo, paragraph, and data components are not added to their slots. The components also needs some top margin.
- CTA (starshot-cta2)
The HTML tags are rendered in front end as
content_right
andcontent_right_bottom
props do not use the|raw
filter in template.- Stats + Four column in slot + Stats card in each slot
Style is broken when this combination is used
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks! This is perfect to start with. Let’s park it a few days so we can catch up to you. I’ll revisit later this week.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Closing the old similar issue as a duplicate and moving credit:
📌 Create dummy page that has all SDDS components listed for testing Closed: duplicate
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Please bear with us... still working through a big refactor here:
https://git.drupalcode.org/project/demo_design_system/-/merge_requests/53
I hope that will land in the next couple days.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
The refactor has landed. This issue has details that may be useful here (i.e. looking at the Starshot template in Storybook):
📌 Create MR with SDDS Sections so XB demo can use MR patch Needs review
Would be amazing if you wanted to tackling that one as well.
- Status changed to Needs work
3 months ago 7:33pm 11 September 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Changing status. See above comment re storybook.
- 🇮🇳India Akhil Babu Chengannur
I have updated the front page template by following the same component structure in 📌 Create MR with SDDS Sections so XB demo can use MR patch Needs review .
This is how the front page looks right now - Assigned to Kristen Pol
- Status changed to Needs review
3 months ago 2:13pm 17 September 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Looks amazing 🙏 I’ve got meetings and appointments today but will try to review tonight
- Status changed to RTBC
3 months ago 3:49am 18 September 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Made a tiny change... I'll get this merged.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Updated summary to reflect changes.
- Issue was unassigned.
- Status changed to Fixed
3 months ago 3:56am 18 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.