🇮🇳India @annmarysruthy

Reviewed the MR !460. The error message could not be replicated after the changes in MR. AI Assistant is also working fine.

annmarysruthy → created an issue.

@vakulrai Unable to replicate the issue. No warnings were issued when a field with AI Automator enabled was deleted and content is edited again.

annmarysruthy → made their first commit to this issue’s fork.

Updated comments for return values as per review comment #5.

annmarysruthy → made their first commit to this issue’s fork.

Raised MR #3. Kindly review.

If #title is provided in the form element, pass1 does not get an extra title. If #title is not provided, it defaults to "Password" as before.
Creating a custom form with a password_confirm form element with #title will only display the provided title, not the default one.

Updated issue summary

annmarysruthy → made their first commit to this issue’s fork.

The comment above the actions section originally described a configuration related to user roles and permissions.

Original code:

# Configuration actions may be defined. The structure here should be
# entity_type.ID.action. Below the user role entity type with an ID of
# editor is having the permissions added. The permissions key will be
# mapped to the \Drupal\user\Entity\Role::grantPermission() method.
actions:
  user.role.editor:
    createIfNotExists:
      label: 'Editor'
    grantPermissions:
      - 'delete any article content'
      - 'edit any article content'

However, in a later commit, the actual configuration changed to modifying text.settings, but the comment remained unchanged:

actions:
  text.settings:
    simpleConfigUpdate:
      default_summary_length: 700

Now, the comment is misleading because it's still describing user roles and permissions, while the actual code is updating text summary length settings.

annmarysruthy → made their first commit to this issue’s fork.

Removed autocomplete in MR !499. Kindly review. however even if we enter text in searchbox, relevant results are not displayed. This is already mentioned in https://www.drupal.org/project/drupal_cms/issues/3501069 🐛 Search broken without search_api_autocomplete Active

annmarysruthy → made their first commit to this issue’s fork.

Kindly review MR !11144.

annmarysruthy → made their first commit to this issue’s fork.

Updated remaining tasks.

Removed Ban module usage from UpdatePathTestBaseFilledTest and ConfigImportUITest. Kindly review

annmarysruthy → made their first commit to this issue’s fork.

Tests failed as ban module is used in tests. Will work on these tests as part of https://www.drupal.org/project/drupal/issues/3488838 📌 Use a test module instead of Ban in dependency tests Active .

annmarysruthy → made their first commit to this issue’s fork.

Any User with 'Translate any entity' permission will be able to translate an entity even when 'Enable Translation' is not enabled individually.

annmarysruthy → made their first commit to this issue’s fork.

Added tests in Merge request !11106. Kindly review

Raised MR#5. Kindly review.

annmarysruthy → made their first commit to this issue’s fork.

annmarysruthy → made their first commit to this issue’s fork.

annmarysruthy → made their first commit to this issue’s fork.

annmarysruthy → made their first commit to this issue’s fork.

annmarysruthy → made their first commit to this issue’s fork.

annmarysruthy → made their first commit to this issue’s fork.

annmarysruthy → made their first commit to this issue’s fork.

Kindly review MR !9746

annmarysruthy → made their first commit to this issue’s fork.

@benjifisher Kindly review

Kindly review MR !9712.

annmarysruthy → made their first commit to this issue’s fork.

annmarysruthy → made their first commit to this issue’s fork.

annmarysruthy → made their first commit to this issue’s fork.

Deprecation code was added in https://www.drupal.org/project/drupal/issues/3394197 🐛 [regression] The new property \Drupal\Core\Form\ConfigFormBase::$typedConfigManager conflicts with some contrib modules Fixed and later it was removed in https://www.drupal.org/project/drupal/issues/3443488 📌 Remove deprecated code from lib/Flood and lib/Form Fixed

Kindly review MR !9620. Change record:
https://www.drupal.org/node/3476950 → . Instead of function _install_get_version_info(), explode('.', \Drupal::VERSION) can be used.

annmarysruthy → made their first commit to this issue’s fork.

Kindly review MR !9599.

annmarysruthy → made their first commit to this issue’s fork.

annmarysruthy → made their first commit to this issue’s fork.

If a user entity should be created by autocreate, text entered in the autocomplete field can be passed as username for user entity. which role should be assigned to the user created? - I would suggest Authenticated only.

In case of file entity, how can we autocreate a file from an autocomplete field?

Kindly review MR !9570 which hides option 'Create referenced entities if they don't already exist' in manage field of reference type fields of type user and file.

Two approaches can be followed here:

1. Implement a fix to ensure the name field is populated and implement user entity autocreate
2. hide option "Create referenced entities if they don't already exist" for user entity

annmarysruthy → made their first commit to this issue’s fork.

annmarysruthy → changed the visibility of the branch 3473029- to hidden.

annmarysruthy → changed the visibility of the branch 3473029-wrong-maxlength-on to hidden.

In authoring information tab (in node add, edit), 'Authored by' has maxlength 1024. Only in translation form, Authored by inside translation tab has maxlength 60. In the same translation form, Authored by field inside 'Authoring information' tab has maxlength 1024 and this causes issue.

Instead of removing maxlength, I would recommend changing maxlength of 'Authored By' inside translation tab to 1024 and make it same as ' Authored by' field inside 'Authoring information' tab

annmarysruthy → made their first commit to this issue’s fork.

Current implementation ensures that HTML tags that are already supported by CKEditor 5 plugins are not redundantly added to the Source Editing. In core/modules/ckeditor5/src/Plugin/Validation/Constraint/SourceEditingRedundantTagsConstraintValidator.php, The code for this implementation is added and it ensures that tags already enabled by plugins are not added again and raises an error.

I believe rephrasing the helptext would be better in this case. We can rephrase it to :

"A list of HTML tags that can be used while editing source. Remove or do not add tags that are already supported by enabled plugins. For example, if "Bold" is enabled, do not add the tag. It may be necessary to add

annmarysruthy → made their first commit to this issue’s fork.

A helptext "This widget uses radio buttons if the "Allowed number of values" is set to 1. If the number of allowed values is more than 1 or unlimited, checkboxes will be used." will be displayed in manage form display when Checkboxes/Radio buttons is selected as widget.

annmarysruthy → made their first commit to this issue’s fork.

annmarysruthy → made their first commit to this issue’s fork.

I followed development guide and then created a page as per design. Few issues/observations I noticed:

1. In the left side bar, when I right click on the components added, a list of options such as Edit , Duplicate, Move and Delete appears. But on moving the mouse, the options disappear and I was unable to select an option using mouse click. However, I can use the options using navigation keys.
2. It took me more than one attempt to drag and place a component in page. Sometimes I drag the component to the place I need it to be displayed, but on releasing mouse, it will not be placed
3. The preview is not clear and this makes it hard to identify which components should be added as per design.

annmarysruthy → made their first commit to this issue’s fork.

kristen pol → credited annmarysruthy → .

Raised MR for replacing the components module namespaces with the SDC namespaces. Kindly review MR !38

annmarysruthy → made their first commit to this issue’s fork.

annmarysruthy → created an issue.

Raised MR !34 for adding required props to component.yml files. Kindly review

annmarysruthy → changed the visibility of the branch 3469522- to active.

annmarysruthy → changed the visibility of the branch 3469522- to hidden.

@kristenpol Yesterday I raised MR for the component.yml files in atoms, molecules folders of base theme. Today I took latest pull and added examples for remaining component.yml files of base theme and subtheme. Hope you are clear.

@kristenpol added examples for properties in all component.yml files of theme and subtheme. Kindly review

Added a commit for adding drupal in tag.twig. This would fix issue 3 listed in comment #3. Kindly review

annmarysruthy → changed the visibility of the branch 3469523-add-examples-for to active.