annmarysruthy → made their first commit to this issue’s fork.
annmarysruthy → made their first commit to this issue’s fork.
annmarysruthy → made their first commit to this issue’s fork.
Created MR !3 to fix the compatibility issues reported by upgrade status. Please review.
Checked the module's D10 compatibilty with upgrade status. attaching the report here.
annmarysruthy → made their first commit to this issue’s fork.
Reviewed patch #2. patch applied cleanly and issues are fixed.
Reviewed patch #2. patch applied cleanly and module is drupal 10 compatible
Reviewed the patch #2. it failed to apply as core is already removed in https://www.drupal.org/project/auto_node_translate → version 2.1.4.
Reviewed MR!4. Issues are fixed.
Raised MR!3. Some of the phpcs issues are fixed. only 1 issue in /var/www/html/web/modules/custom/address_display/tests/src/Kernel/Formatter/AddressDisplayTest.php is pending.
Created MR!1 to fix the code by declare $plugin as class property in class editableviews_style_helper. Please review.
annmarysruthy → made their first commit to this issue’s fork.
annmarysruthy → made their first commit to this issue’s fork.
MR !4 raised to avoid t() calls inside class. please review
annmarysruthy → made their first commit to this issue’s fork.
annmarysruthy → made their first commit to this issue’s fork.
Reviewed patch #2. But it failed to apply.
Created an MR!3 to fix the drupal coding standards issues.
created a new patch for changing all the t() calls. Please review
Reviewed patch #2. patch applied cleanly and hook_help is implemented.
annmarysruthy → made their first commit to this issue’s fork.
Created an MR!7 for fixing the type error in hook_migrate_prepare_row. please review.
annmarysruthy → made their first commit to this issue’s fork.
Reviewed patch #3, it applied cleanly and core key is removed.
Reviewed patch #2. It applied cleanly.
Reviewed patch #2. It applied cleanly and hooh_help is now implemented.
annmarysruthy → made their first commit to this issue’s fork.
Created an MR!6 to fix the issues. Please Review
Created MR!6 for fixing phpcs issues. Please review.
Reviewed the patch #2. Patch failed to apply.
Reviewed MR !1 and hook_help() is implemented.
Reviewed patch #2. Patch applies cleanly and all phpcs issues are fixed.
@dcam Can you please review MR !5 not MR !4
Raised MR!2 for fixing the compatibility issues mentioned in #3. Please Review.
The module was scanned using upgrade status for checking Drupal 10 compatibility. 2 Issues were found in the module
annmarysruthy → made their first commit to this issue’s fork.
Checked the compatibility of the module using upgrade status and found only 1 issue.
Raised MR!2 to add Drupal 10 to core_version_requirement.
Kindly review.
annmarysruthy → made their first commit to this issue’s fork.
Reviewed patch #2. Patch applied cleanly and module is now Drupal 10 compatible.
annmarysruthy → made their first commit to this issue’s fork.
Made commit to fix some more issues in phpcs. However 1 warning is remaining which cannot be solved.
FILE: /var/www/html/web/modules/contrib/weight-3343609/weight.views.inc
-----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------
17 | WARNING | Unused variable $table_name.
-----------------------------------------------------------------------
we cannot remove the $table_name variable from the foreach loop because it is used as a key in the $data array. Removing it would cause an error in the loop, as it would not be possible to access the data in the $data array without the key.
annmarysruthy → made their first commit to this issue’s fork.
Installed and reviewed the following release:
https://www.drupal.org/project/notificationswidget/releases/2.0.0-alpha1 →
This is drupal 10 compatible. No issues were found.
hook_help() is already implemented in the module file. Redeclaring the hook_help() will throw an error while installing the module.
MR!1 has to reverted. Hence raised new MR for reverting changes in first commit.
Please review.
annmarysruthy → made their first commit to this issue’s fork.
annmarysruthy → made their first commit to this issue’s fork.
apaderno → credited annmarysruthy → .
MR !3 raised to make the module Drupal 10 compatible. Kindly review.
annmarysruthy → created an issue.
Reviewed patch #2. Patch applied cleanly and hook_help is implemented.
Reviewed patch #2. patch applied cleanly and core is removed.
Please Elaborate on the issues and how to reproduce the issues.
annmarysruthy → made their first commit to this issue’s fork.
Created 2 MR for fixing the phpcs issues. Some issues are remaining . Needs work