Casing of translatable string incorrectly hard coded

annmarysruthy → changed the visibility of the branch 3531117-casing-of-translatable to hidden.

annmarysruthy → changed the visibility of the branch 3531117-casing-of-translatable to active.

annmarysruthy → changed the visibility of the branch 3531117-casing-of-translatable to hidden.

Looks nice codewise. Thanks for the patch!

While the strtolower is incorrect, the test strings look incorrect in English now, with the capitalisation mid sentence - e.g. "Translate Taxonomy vocabulary" or "Translate Contact form"

Entities have singular labels available for this sort of thing, shouldn't we be using label_singular here instead?

#[ConfigEntityType(
  id: 'taxonomy_vocabulary',
  label: new TranslatableMarkup('Taxonomy vocabulary'),
  label_collection: new TranslatableMarkup('Taxonomy'),
  label_singular: new TranslatableMarkup('vocabulary'),
  label_plural: new TranslatableMarkup('vocabularies'),

with the button text "Translate vocabulary"

#[ConfigEntityType(
  id: 'contact_form',
  label: new TranslatableMarkup('Contact form'),
  label_collection: new TranslatableMarkup('Contact forms'),
  label_singular: new TranslatableMarkup('contact form'),
  label_plural: new TranslatableMarkup('contact forms'),

with the button text "Translate contact form"

#[ConfigEntityType(
  id: 'view',
  label: new TranslatableMarkup('View', ['context' => 'View entity type']),
  label_collection: new TranslatableMarkup('Views', ['context' => 'View entity type']),
  label_singular: new TranslatableMarkup('view', ['context' => 'View entity type']),
  label_plural: new TranslatableMarkup('views', ['context' => 'View entity type']),

with the button text "Translate view", etc.

Seems like something definitely should be looked at. Agree "Translate Taxonomy vocabulary" seems wrong.

In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Also mentioned on the version → section of the list of issue fields documentation. Thanks.

It's good to know, that this is a bigger issue. We where looking for the root cause multiple years, so if we came across a solution that solve this uppercase/lowercase issue in all affected places, that would be very great.