Drupal 10 compatiility?

The module was scanned using upgrade status for checking Drupal 10 compatibility. 2 Issues were found in the module

Raised MR!2 for fixing the compatibility issues mentioned in #3. Please Review.

Hi,

This patch doesn't apply to me and contains more changes than what upgrade_status indicates. This is one patch for the module with the problems reported by upgrade_status.

Hope that it helps

Hi,

Attached a new patch as the previous didn't apply.

None of these worked for me.

#5 has 2 extra commits in it, and absolutely would not apply.

I'm not sure what's going on in #6, but per the author it does not apply.

#7 applies, but only removed "core: 8.x" from the masonry.info.yml and we need to do more than that for D10.

I have a patch that works, but I have a nested doc root and so does this patch -- apparently I don't know how to make a patch that works for everyone. (Happy to figure it out. Just not happening today.)

I've attached my file so you can see what I did, it' really simply. In case anyone gets back here and needs it before I get back here. Drupal 9 EOL is coming up, these are simple changes, would be great if we could get in a new version. ASAP.

Sorry I couldn't do more today.

Here is a replacement that follows the Drupal instructions for standardizing patches.

It only makes the 2 changes required by Upgrade Status.

Please review.

FYI, the above patch in #10 applies only to 8.x-1.x-dev, not to 8.x-1.2.

Change version to 8.x-1.x-dev because that is what the patches apply to.

Okay the original Merge request in #5 actually works. All the code in it appears to be required for Drupal 10.

It applies, but ONLY to the dev version (8.x-1.x-dev).

It works for me on 10.0.5, on 2 different sites.

You will likely also need the patch, below, if you switch to the dev version from the recommended version. https://www.drupal.org/project/masonry/issues/3231169 🐛 Restore the masonry-layout class Fixed

I am going to change this to RTBC. And hide both of my temp patches. And the patches in #7 and 8 to avoid any future confusion.

Would be nice if someone else could verify and contact the maintainer.

Yes. I'll test this week. But it would be good if the maintainer might move this into the dev branch for wider testing.

Any word on a release date for the D10 version?

Here is the patch I am committing after all.

Is it committed/released? I do not see the D10 version on the front page yet. Thanks!

Me neither.

Release 2.0.0 published.

Thank you! Will Masonry Views for D10 be published today as well? ( https://www.drupal.org/project/masonry_views/issues/3288460 📌 Automated Drupal 10 compatibility fixes Fixed )

I won't have time today. But it is already pushed in the 2.x branch if needed so that should be soon.

albeorte → closed merge request !2