Hi all,
First of all, thanks for the theme! It looks really nice.
I've checked this issue because I saw the same problem while testing it. The code looks good to me and works but the fork needed an update. I updated it following the instrucctions and pushed the change. I'm not sure if I did correctly but let me know if you see I broke something.
Thanks
luismagr → made their first commit to this issue’s fork.
Hi,
I've experienced the same issue while trying to run storybook on a drupal installation with seckit installed on it. I've created a MR that prevent the error. Probably there's a plan to fix this in another way but for now, it seems this works well for my issue.
Happy to continue with the issue if someone points me to a better direction.
Thanks
luismagr → made their first commit to this issue’s fork.
luismagr → made their first commit to this issue’s fork.
Hi all,
I'm running 10.2.5 and I can confirm it works as expected. I'm building a new theme started with the starterkit and this is working perfectly fine.
I'm not putting this issue back to 'Reviewed & tested by the community' because I can't confirm if it's working or not in a boostrap theme.
Thanks all for your work on this issue
luismagr → created an issue.
Hi @basvredeling
Thanks for the patch. I was having the same issue and I tried this patch to apply to my project. It applied well so thanks for it. However it didn't solve my problem completely as I have translatable content as well. I've modified your patch to make the field also translatable.
I think I didn't add my code in the best way and I applied it to your branch which could cause some problems to people using your previous one. I'm not totally used to issue forks now, so pease, let me know if I have to revert it and do it in another way.
Again, thanks for your code.
luismagr → made their first commit to this issue’s fork.
I've opened a MR for this issue and there's a fork you can use. Moving the issue to "Needs review".
Thanks
luismagr → created an issue.
Hi,
Attached a new patch as the previous didn't apply.
Hi,
This patch doesn't apply to me and contains more changes than what upgrade_status indicates. This is one patch for the module with the problems reported by upgrade_status.
Hope that it helps
luismagr → made their first commit to this issue’s fork.