- 🇬🇧United Kingdom Alina Basarabeanu
Just discovered that the latest patch breaks the XML sitemap.
When viewing the website sitemap in Firefox an error is shown: XML Parsing Error: not well-formed
Set the defer attribute as defer="defer" instead of just 'defer' for the seckit.frame_check.js file.
Updated patch added. - Status changed to Needs review
about 1 year ago 1:57pm 22 March 2024 - Issue was unassigned.
- 🇺🇸United States DamienMcKenna NH, USA
Should this be moved to the 2.0.x branch?
- 🇺🇸United States DamienMcKenna NH, USA
Moving to the 2.0.x/2.x branch because the 8.x-1.x branch is no longer supported.
- last update
10 months ago 2 fail The last submitted patch, 26: seckit-3193443-21.patch, failed testing. View results →
- First commit to issue fork.
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Not currently mergeable. - Merge request !29Resolve #3193443 "Avoid using document.write " → (Closed) created by chaitanyadessai
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Not currently mergeable. - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Not currently mergeable. - First commit to issue fork.
- Merge request !30#3193443: Open and close the document for writing operations → (Open) created by luismagr
- 🇪🇸Spain luismagr
Hi,
I've experienced the same issue while trying to run storybook on a drupal installation with seckit installed on it. I've created a MR that prevent the error. Probably there's a plan to fix this in another way but for now, it seems this works well for my issue.
Happy to continue with the issue if someone points me to a better direction.
Thanks
- First commit to issue fork.
- 🇬🇧United Kingdom the_g_bomb
Hi,
@luismagr there is a solution offered already that solves this in #21, you MR in #30 does not include the complete solution.
@manish.upadhyay I think your patch at #29 is close, but I don't think defer="defer" can be used for css - 🇬🇧United Kingdom the_g_bomb
Pushed a reroll of #21 applying to the 2.x branch.
This patch can be used if needed:
https://git.drupalcode.org/project/seckit/-/merge_requests/46.diff