πŸ‡ΊπŸ‡ΈUnited States @astringer

Account created on 17 August 2011, about 13 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States astringer

@tpzurdo,

You are probably looking for Matt Glaman's Composer Lenient:

https://github.com/mglaman/composer-drupal-lenient

πŸ‡ΊπŸ‡ΈUnited States astringer

I had this problem with an authenticate user and user_picture in the public folder.

The patch did not work, at first. It did work once I changed the storage of the user_picture to private.

I didn't have time to investigate further, ping me if you anyone wants more details. (And it's strange because it worked a couple of days ago with the public folder, and no patch.).

Crossing my fingers it holds.

πŸ‡ΊπŸ‡ΈUnited States astringer

I had this problem with an authenticate user and user_picture in the public folder.

The patch did not work, at first. It did work once I changed the storage of the user_picture to private.

I didn't have time to investigate further, ping me if you anyone wants more details. (And it's strange because it worked a couple of days ago with the public folder, and no patch.).

Crossing my fingers it holds.

πŸ‡ΊπŸ‡ΈUnited States astringer

I'm in the same boat as @fisherman90, +1 for this, that behavior is not expected and confusing, and I'm happy to test the patch. @idebr

πŸ‡ΊπŸ‡ΈUnited States astringer

The merge request from #13 failed for me. 9.5.3 and 8.x-2.x beta 6(Applied, but I got this WSOD.)

I didn't have time to test it with another theme.

The website encountered an unexpected error. Please try again later.
TypeError: Drupal\bootstrap\Plugin\PrerenderManager::preRender(): Argument #1 ($element) must be of type array, null given in Drupal\bootstrap\Plugin\PrerenderManager::preRender() (line 36 of themes/contrib/bootstrap/src/Plugin/PrerenderManager.php).
Drupal\bootstrap\Plugin\PrerenderManager::preRender(NULL)
call_user_func_array(Array, Array) (Line: 101)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725 β†’ ', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 788)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 374)
Drupal\Core\Render\Renderer->doRender(NULL) (Line: 446)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 204)
Drupal\Core\Render\Renderer->render(Array) (Line: 94)
template_preprocess_toolbar(Array, 'toolbar', Array)
call_user_func_array('template_preprocess_toolbar', Array) (Line: 287)
Drupal\Core\Theme\ThemeManager->render('toolbar', Array) (Line: 433)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 446)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 204)
Drupal\Core\Render\Renderer->render(Array) (Line: 479)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 83)
__TwigTemplate_474fe8af4d3a856c59ebc5f7c9fa5132->doDisplay(Array, Array) (Line: 405)
Twig\Template->displayWithErrorHandling(Array, Array) (Line: 378)
Twig\Template->display(Array) (Line: 390)
Twig\Template->render(Array) (Line: 55)
twig_render_template('themes/custom/itp_bs/templates/system/html.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('html', Array) (Line: 433)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 204)
Drupal\Core\Render\Renderer->render(Array) (Line: 162)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 163)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 142)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 174)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 50)
Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 707)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

πŸ‡ΊπŸ‡ΈUnited States astringer

Okay the original Merge request in #5 actually works. All the code in it appears to be required for Drupal 10.

It applies, but ONLY to the dev version (8.x-1.x-dev).

It works for me on 10.0.5, on 2 different sites.

You will likely also need the patch, below, if you switch to the dev version from the recommended version. https://www.drupal.org/project/masonry/issues/3231169 πŸ› Restore the masonry-layout class Fixed

I am going to change this to RTBC. And hide both of my temp patches. And the patches in #7 and 8 to avoid any future confusion.

Would be nice if someone else could verify and contact the maintainer.

πŸ‡ΊπŸ‡ΈUnited States astringer

Change version to 8.x-1.x-dev because that is what the patches apply to.

πŸ‡ΊπŸ‡ΈUnited States astringer

Merge request in #8 worked for me, changed to RTBC.

πŸ‡ΊπŸ‡ΈUnited States astringer

This is a duplicate of https://www.drupal.org/project/telephone_validation/issues/3289981 πŸ“Œ Automated Drupal 10 compatibility fixes Fixed

πŸ‡ΊπŸ‡ΈUnited States astringer

FYI, the above patch in #10 applies only to 8.x-1.x-dev, not to 8.x-1.2.

πŸ‡ΊπŸ‡ΈUnited States astringer

Here is a replacement that follows the Drupal instructions for standardizing patches.

It only makes the 2 changes required by Upgrade Status.

Please review.

πŸ‡ΊπŸ‡ΈUnited States astringer

Just reiterating #6 worked for me, if you simply need to get this done now.

πŸ‡ΊπŸ‡ΈUnited States astringer

None of these worked for me.

#5 has 2 extra commits in it, and absolutely would not apply.

I'm not sure what's going on in #6, but per the author it does not apply.

#7 applies, but only removed "core: 8.x" from the masonry.info.yml and we need to do more than that for D10.

I have a patch that works, but I have a nested doc root and so does this patch -- apparently I don't know how to make a patch that works for everyone. (Happy to figure it out. Just not happening today.)

I've attached my file so you can see what I did, it' really simply. In case anyone gets back here and needs it before I get back here. Drupal 9 EOL is coming up, these are simple changes, would be great if we could get in a new version. ASAP.

Sorry I couldn't do more today.

πŸ‡ΊπŸ‡ΈUnited States astringer

This works, can we please get it applied and a new version EOL for D9 is coming up.

πŸ‡ΊπŸ‡ΈUnited States astringer

I tested #46 with the CkEditor 5 patch and it works well, thank you.

πŸ‡ΊπŸ‡ΈUnited States astringer

re: #19

I'm a goof, I did not know you needed an API key for Facebook/Instagram. I did not have one when I tested, and I am fairly certain that is probably why it failed.

In a perfect world, an exception might be helpful there.

(Sorry we just don't use them, I just thought I'd try them. I need it for Youtube and Vimeo.)

So someone who has those API credentials should test those. Otherwise it worked great for me.

Thanks.

πŸ‡ΊπŸ‡ΈUnited States astringer

I applied your patch to 2.x-dev running Drupal 9.5.5, with CKEditor 5. And it works, except for Facebook and Instagram, they are throwing the error, below. Which may or may not be related to this issue: https://www.drupal.org/project/url_embed/issues/3272702 πŸ“Œ Support for Facebook/Instagram API (2022), switch to embed/embed v4 Fixed

(I tested it with Vimeo, Youtube, Twitter, Facebook and Insta.)

Warning: Attempt to read property "html" on null in Drupal\url_embed\Plugin\Filter\UrlEmbedFilter->process() (line 78 of modules/contrib/url_embed/src/Plugin/Filter/UrlEmbedFilter.php).
Drupal\url_embed\Plugin\Filter\UrlEmbedFilter->process('
', 'en') (Line: 118)
Drupal\filter\Element\ProcessedText::preRenderText(Array)
call_user_func_array(Array, Array) (Line: 101)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725 β†’ ', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 788)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 374)
Drupal\Core\Render\Renderer->doRender(Array, 1) (Line: 204)
Drupal\Core\Render\Renderer->render(Array, 1) (Line: 160)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 161)
Drupal\Core\Render\Renderer->renderPlain(Array) (Line: 91)
Drupal\embed\Controller\EmbedController->preview(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 50)
Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

πŸ‡ΊπŸ‡ΈUnited States astringer

The patch in #29, works for me on Drupal 9.5.3 using 8.x-1.9 of Userswitch.

πŸ‡ΊπŸ‡ΈUnited States astringer

If you end up on this page: the patch from this issue Add an entity operation instead of a user list, solves this bug, AND it's a much better solution from a user experience perspective. And I also believe it solves the route issue in #9 πŸ› The userswitch.user.user_list key is used twice in userswitch.links.action.yml Needs work .

πŸ‡ΊπŸ‡ΈUnited States astringer

Thank you!

I have this working on 3 installs. The errors are gone.

Can we get this merged and a new version ASAP?

Because the change is to a dependency, It's really cumbersome to get this working with composer.

πŸ‡ΊπŸ‡ΈUnited States astringer

I can confirm that we had this problem on 9.5 using a clean install of group 3 RC1 and entity clone 2.0.0-alpha1. And a few other modules. Not a surprise, but reporting anyway.

πŸ‡ΊπŸ‡ΈUnited States astringer

Confirming that I got nothing but a WSOD installing on 9.5.1. And the patch in #6 worked for me.

Can we please get this patch merged. It would be nice to be able to test this on an install, to see where OG is at and not have the hassle of it refusing to uninstall.

Production build 0.71.5 2024