Automated Drupal 10 compatibility fixes

This works, can we please get it applied and a new version EOL for D9 is coming up.

Any word on a release date for the D10 version?

Fixed in branch 2.x
It will require a bit of time though until Masonry API is ready too. Please be patient, sorry for inconvenience.

Is it committed/released? I do not see the D10 version on the front page yet. Thanks!

Masonry API 2.0 (D10 compatible) is released on 20th April.
https://www.drupal.org/project/masonry/releases/2.0.0 →

I patched the dev branch with the patch in this thread (which only changes the version requirements) and installed the latest D10-compatible version of the Masonry module. Now, when I apply Masonry as the View's "format", my view completely disappears from my front-end. Any ideas on why that would happen?

@hockey2112 what do that means "my view completely disappears" ?
Could you reproduce that on a fresh drupal instance ? Do you have any debug info, either in console or in the report section ?
Anything that could lead me in anyway ?

Automatically closed - issue fixed for 2 weeks with no activity.

What is the proper way to install version 2.0? I'm seeing branch in repo but no release yet. Is it possible to checkout to 2.0 using composer ... dependencies in masonry_api are not allowing me use v2.0 until masonry_views matches this version.

@tpzurdo,

You are probably looking for Matt Glaman's Composer Lenient:

https://github.com/mglaman/composer-drupal-lenient

@Dom. any chance you can promote the 2.0 version on the project homepage? https://git.drupalcode.org/project/masonry_views shows the 2.x branch as default, but https://www.drupal.org/project/masonry_views → doesn't show it.

Thanks!

I will for sure,
Drupal Dev Days Vienna is my deadline, but hopefully I will do it sooner.
I want to test it again first. Or someone from the community uses the D10 version via GIT and validates its ok

Thanks Dom. I plan to test it this week and report back here. If anyone else wants to test this, here is the git info that I added to my composer.json in the repositories section:

"drupal/masonry_views": {
            "type": "package",
            "package": {
                "name": "drupal/masonry_views",
                "version": "2.x-dev",
                "type": "drupal-module",
                "source": {
                    "type": "git",
                    "url": "https://git.drupalcode.org/project/masonry_views.git",
                    "reference": "9cf47eae179ddca42dcb4883461cbd555cca4809"
                }
            }
        }

Then you can reference the 2.x version of the module. Aka "drupal/masonry_views": "^2.0",

@Dom. I was able to have a view working with masonry_views as the display format.

The biggest issue I had was including "px" in the Gutter Width setting (px isn't needed). Ideally there would be a warning to prevent people doing what I did, but that is a separate issue.

+1 from me on this. Thanks!

Thank you nmillin for mentioning that! The "px" was also wat killed my masonry view.

Hi @nmillin, @zJoriz :
Next week at DrupalDevDays Vienna, I will have time to focus on polishing the module for a release.
Would you have the time to list the issues remaining making this difficult to use ?

I notice you had trouble with the "Gutter Width setting". SHould I change the caption or description to be more helpfull ?
Also, I could probably provide a "layout" dropdown option with "none" by default. Other options could be "2 columns", "3 columns", "4 columns" for instance. It would inject the minimal CSS (olivero compatible) to get the module work with that number of columns by default.
That would also serve as a tutorial for others to implement their own custom CSS.

Any other improvment that would be worth it before I release a 2.0 version ?

Thanks a lot for your help and sorry for being so slow at delivering here.

+1 for #19. For me I had a 0 and I just removed it and now it's working.

Thanks!