@SomebodySysop, No, I didn't had to uninstall the module(s). Lenient allowed me to do D9 -> D10 upgrade with patched modules in place. I had 5 modules in total that were D10 compatible with patches.
Here are the steps that worked for me. Try if these work for you.
1. If not already done, composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/highlight"]'
2. composer require drupal/core-recommended:^10 drupal/core-composer-scaffold:^10 drupal/core-project-message:^10 drupal/recommended-project:^10 --no-update
If there are any D10 only compatible modules, you can add them in step 2.
3. Composer update --with-all-dependencies OR Composer update --with-all-dependencies --dry-run
@SomebodySysop, For modules that are made D10 compatible using patch(es), composer doesn’t allow upgrading the core to D10. Lenient allows to bypass this for specific modules. More information at https://github.com/mglaman/composer-drupal-lenient. I have used this on a couple of projects and I had no issues.
Try a D10 update dry run (composer update "drupal/core-*" --with-all-dependencies --dry-run) and see if it still complains about vefl.
@SomebodySysop, please see comment #5 ✨ Drupal 10 support? RTBC . You can use these commands.
composer config minimum-stability dev
composer require mglaman/composer-drupal-lenient
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/vefl"]'
@jcmartinez, sure I can work on the module. Can you please give me appropriate permissions to the module and repo?
Fixed the following error.
ArgumentCountError: Too few arguments to function Drupal\Core\Asset\JsCollectionOptimizerLazy::optimize(), 1 passed in /app/web/modules/contrib/h5p/src/H5PDrupal/H5PDrupal.php on line 241 and exactly 2 expected in Drupal\Core\Asset\JsCollectionOptimizerLazy->optimize() (line 65 of /app/web/core/lib/Drupal/Core/Asset/JsCollectionOptimizerLazy.php).
superman369 → created an issue.
Great. Thanks.
superman369 → created an issue.
@dalemoore, you can use drupal-lenient plugin to install modules that are not yet D10 compatible and apply patches. Here are the commands.
composer config minimum-stability dev
composer require mglaman/composer-drupal-lenient
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/vefl"]'
@ady1503, the error you mentioned is addressed in https://www.drupal.org/project/vefl/issues/3341550 🐛 TypeError: Illegal offset type in isset or empty Needs review
Masonry API 2.0 (D10 compatible) is released on 20th April.
https://www.drupal.org/project/masonry/releases/2.0.0 →
@minorOffense, thanks for providing the patch. I tested it and found an issue in the following scenario.
Here are the steps.
1. Login on a new browser session.
2. On TFA page, enter the authentication code from the email, DON'T select "Remember this browser for 30 days?" and verify.
3. Logout from the website.
4. Login again in the same browser session.
5. The user is prompted for the authentication code on the TFA page, but the email with the code is not automatically sent. I had to click "Send" to get the email.
It's working fine for other scenarios when selecting to remember the browser for 30 days.
Thanks for looking into this.
wildcats369 → created an issue.
@Mingsong thank you for the patch tfa-2930541-60.patch. However, I still see the bug mentioned in #40 and #59. I am on 8.x-1.0. Here are the steps.
1. Login on a new browser session.
2. On TFA page, enter the authentication code from the email, select "Remember this browser for 30 days?" and verify.
3. Logout from the website.
4. Login again in the same browser session.
5. The user is logged in without TFA page and shows the message "You have logged in on a trusted browser.".
6. However, the authentication code for the 2nd login is sent to the email.
Thanks for looking into this.