Trying to access array offset on value of type int

Hello @superman369 thanks for the bug report and the patch.

It would actually be better to avoid casting values, and instead update the conditional to check if the value is a string or not a string. Casting to a string has some hidden overhead here, and we can definitely avoid it.

I'd be okay with:

if ((is_int($key) || $key === '' || $key[0] !== '#') && is_array($child))

Or

if ((!is_string($key) || $key === '' || $key[0] !== '#') && is_array($child))

The latter might be better because it verifies that they key is associative (a string) before treating it as a string. The first option should also work because PHP only allows integers and strings as array keys.

Thanks for the quick response and the updated PR.

I've merged this in, and have a release coming soon that will include this.

Great. Thanks.

Automatically closed - issue fixed for 2 weeks with no activity.