- Issue created by @joachim
- First commit to issue fork.
- Merge request !12330Issue #3528994: docs for hook_views_query_alter() fail to import the class for a parameter → (Closed) created by annmarysruthy
- 🇬🇧United Kingdom joachim
Perfect, thanks!
(Remember to set issues to 'Needs review' when they're ready! :)
JS test failures are unrelated. RTBC.
- 🇮🇳India divyat
I have replicated this locally & the provided solution works fine.
Here are the screenshots attached - 🇬🇧United Kingdom joachim
@divyat There's no need to take screenshots of code being applied -- we can see the diff on gitlab and gitlab tells us that the MR can be merged cleanly.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇬🇧United Kingdom joachim
I don't know what PHPStan is complaining about, but api.php files aren't executed, so it doesn't matter.
PHPCS is happy and that's what counts.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India shashikant_chauhan
Sorry, in my browser data was not update to date when I tried to unassigned.
Updated to RTBC, again.
-
longwave →
committed 97cc7747 on 10.5.x
Issue #3528994 by annmarysruthy, joachim: hook_views_query_alter() docs...
-
longwave →
committed 97cc7747 on 10.5.x
-
longwave →
committed 2039e4aa on 10.6.x
Issue #3528994 by annmarysruthy, joachim: hook_views_query_alter() docs...
-
longwave →
committed 2039e4aa on 10.6.x
-
longwave →
committed 99ee2a84 on 11.2.x
Issue #3528994 by annmarysruthy, joachim: hook_views_query_alter() docs...
-
longwave →
committed 99ee2a84 on 11.2.x
-
longwave →
committed 13a1d338 on 11.x
Issue #3528994 by annmarysruthy, joachim: hook_views_query_alter() docs...
-
longwave →
committed 13a1d338 on 11.x
- 🇬🇧United Kingdom longwave UK
Thanks for the fix. Backported down to 10.5.x as a docs-only bug fix.
Committed and pushed 13a1d338a4b to 11.x and 99ee2a84ebe to 11.2.x and 2039e4aaf6e to 10.6.x and 97cc774765c to 10.5.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.