Found in https://www.drupal.org/project/experience_builder/issues/3471978 📌 Media Library dialog styling Active
In dialog.position.js, in the resetSize() function we have the following logic:
if (
option === 'height' &&
event.data.$element.parent().outerHeight() < adjustedValue
) {
adjustedValue = 'auto';
}
which basically makes the height option function as maxHeight. I think this behaviour is incorrect and also makes it hard to have dialog with iframes in it (because they use the height they have available and not the height it requires)
I think we just should remove the lines above, and recommend someone to use maxHeight and height = 'auto' instead.
Happy to put this behind a BC option if that makes sense.
Active
11.0 🔥
javascript
Hi @johnwebdev, could you please provide some steps to reproduce this issue?
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.