Warning For Rendered Views

I checked it, it works fine for me.

The last submitted patch, 2: html-title-warnings-3278540.patch, failed testing. View results →

Moved the changes from #2 in a merge request, and all tests passed.

So I was trying to reproduce this issue. It seems that there's another issue at play here that actually seems to render the code in the if statement moot anyway because we are checking for $this->options['settings']['link_to_entity'] === TRUE.

The problem here is that $this->options['settings']['link_to_entity'] is in fact the number 1 instead of the boolean TRUE

Given that, we need to fix that check so this can be reproducible. Given that, Immediately looking at the code I can see that prior to this fix, $alter['rendered']['#title']['#context']['value'] was always created and always a string or Markup object because of $this->htmlTitleFilter->decodeToMarkup() always returns that type. With this fix, that array item doesn't exist and "may" cause unexpected side effects, but I don't know that for certain. It also seems like this would only ever happen if for what ever reason the "title" was empty some how from upstream.

No amount of me messing around with a node and view settings in the UI got me an empty value there. So I have to assume that this has to be on some other type of entity and possibly a broken view configuration?

Given that, after fixing the check in the patch, I'm not receiving any bad side affects. I would feel much more comfortable with steps to reproduce this and/or a view this happens on for us to inspect. However, given the realtivly simple nature of this fix, I'll go ahead and mark it RTBC