Patch #17 worked for me on v2.0.2 and drupal 11.0.9
It is also, in my opinion, the correct way to fix this. Verified working.
I think this will work. But since the calling function on 339 doesn't care about a return value and 554 is just looking for a value, should the return of the function be a bool and the returns refactored accordingly? Happy to do it, but thought it may be a better way to go.
ElusiveMind → created an issue.
Be sure you have patched Facets 2.x for Drupal 10.3 until it is rolled into their release
https://www.drupal.org/project/facets/issues/3052574 🐛 Facets with AJAX not working in most of situations Needs review
What about the ones with « business critical » needs for a D10 release ? In such case you should not use open source software without editor support
Wow..... just..... wow.
Opigno relies on multiple contributed modules tied together through a composer distribution with patches to core and other contributed modules that are heavily version dependent for the patches. This is likely due to the age of these dependencies.
I've built my own distribution of this because I had to cobble two distributions together - Opigno and Open Social into a single multisite install (don't ask).
So the task is two parts. Both are significant:
1. Update the Opigno specific contributed modules. At this point, I would go with Drupal 11/10 hybrid and not just 10. Just my personal preference but I realize that may not be an option for some.
2. Update the Opigno specific contributed modules to work with updated dependencies (groups, etc).
It's not a small effort. I can understand why Opigno is doing this, but I do not support it. They've taken community contributed work and rolled it into a SaaS project which tarnishes open source in my opinion. I'm not going to beat them up about it because it wouldn't change anything. But fool me one, shame on me. Won't be fooled again.
I don't know if I could contribute to this. It will depend on my client's willingness to fund our portion of the work. Unfortunately, I am too committed to my paid projects and personal projects to turn this into a pet project. But I would offer logistical help, as much institutional knowledge as possible and code when possible.
I wish I could be more help, but I am being honest in the assessment here.
My team contemplated forking a while back. And it is a lot and, as a company, we don't have funding for it. As for Drupal 10, that is one thing, but some of the dependent libraries such as H5P are not happy under PHP 8.2 or 8.3 although we did update it ourselves to work with 8.2 and are working to do the same with 8.3.
Unless there is someone with some significant pockets, this is waaaaay bigger than a simple fork of the project. I'm game to help, we'd need to figure out some kind of organization and who is willing to help out since there are so many modules, pieces, profiles and project creation from Composer.
Let me know what you all think.
This is not cool. They list themselves as an open source project but they;'ve admitted to closing their source on this for their "paying customers" first. Doesn't this violate some licensing issue within Drupal's license? This, at its very least, flies in the face of the spirit of open source.
If it's not open source.... stop advertising it as such.
This is tricky. Pantheon, while it does do composer install as part of its packaging and updating does not necessarily require it. I am torn between keeping this as-is and documenting that the plugins should be installed/updated locally and then pushed up via GIT.
I welcome thoughts.
Patch 10 seems to work - Merged to dev.
Regarding Merge Request 10:
The drush.services.yml file should not be deleted. Removing it causes the drush commands to not be seen.
Tested and passed
THis works. Can we get it pushed to a release please for D10 updates?
I have tested this and things seem great. Can we roll this into at least a dev bnranch for Drupal 10 composer installs?
These changes are in the dev branch for installing on Drupal 10 sites. Needs testing (of which I am doing as well) before we can issue a release.
Greetings everyone. I am going to be working as a new maintainer for this module on behalf Zivtech. I'll be setting up the dev 2.0 branch and be taking contributions toward the Drupal 10/CKeditor 5 version. I will also see about updating the existing release to support Drupal 10 and CKEditor 4 for legacy purposes.
Re-rolled for Drupal 9 and 1.0.1
ElusiveMind → made their first commit to this issue’s fork.
ElusiveMind → made their first commit to this issue’s fork.
Rolled an update for ExternalAuth 2.0 as a merge request based on Jody's original work. Testing looks OK so far, but will report back once there is more.
ElusiveMind → made their first commit to this issue’s fork.
Re-rolled for Drupal 10 compatibility as per Rector and Upgrade Status
It is worth noting that this patch is in the 2.x branch - so if you are using this patch you will not need it in 2.x.