- Issue created by @cameron prince
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 5:35am 16 November 2023 - 🇮🇳India viren18febS
Hi @cameron prince
I have fixed the issues and added a patch, please review
Thanks - First commit to issue fork.
- 🇦🇺Australia elc
The patch above simply comments out rather than fix the problem. There seem to be a rash of these kinds of patches.
The issue at hand is that functions declared in the MY_MODULE.api.php file should start with
hook_
and not the name of the module.Fix being:
* @param object $embed * The embed json decoded object as provided by Embed::getEmbedObject(). */ -function ckeditor_media_embed_ckeditor_media_embed_object_alter(&$embed) { +function hook_ckeditor_media_embed_object_alter(&$embed) { $title_exists = ( !empty($embed->title) && $title = Html::escape($embed->title)
- Status changed to RTBC
12 months ago 8:17am 26 November 2023 - Status changed to Fixed
7 months ago 3:30am 1 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.