Automated Drupal 10 compatibility fixes

https://www.drupal.org/project/ckeditor_media_embed/issues/3341750 ✨ CKEditor 5 support? Needs review

How is this progressing?

So, what is planned for this module? continue with 8.x-1.x branch to keep d10 + ckeditor4 ? In that case a dependency on ckeditor 4 contributed module need to be specified.

Maybe is better to move efforts on a new branch with support for d10 + core's ckeditor 5 ?
. I put my efforts in https://www.drupal.org/project/ckeditor_media_embed/issues/3341750 ✨ CKEditor 5 support? Needs review where is the code of a working d10 + core's ckeditor 5.

To allow for smoother upgrade process to Drupal 10.
Hoping for a commit and a soft release to support Drupal 10 + CKEditor 4

Only for testing:
Having the issue fork 3286502-8-x-1-x-drupal-10-support in the composer.json file.
In the repositories

  "repositories": {
    "drupal": {
      "type": "composer",
      "url": "https://packages.drupal.org/8",
      "exclude": [
        "drupal/ckeditor_media_embed"
      ]
    },
    "drupal/ckeditor_media_embed": {
      "type": "git",
      "url": "https://git.drupalcode.org/issue/ckeditor_media_embed-3286502.git"
    }
  },

and in require

  "require": {
    "drupal/core": "~10.0",
    "drupal/ckeditor_media_embed": "dev-3286502-8-x-1-x-drupal-10-support-10 as 1.11.0"
  },

These changes are in the dev branch for installing on Drupal 10 sites. Needs testing (of which I am doing as well) before we can issue a release.

Drupal Version 10.0.10
PHP Version 8.1.23
drush/drush 12.2.0
drupal/ckeditor 1.0.2
drupal/ckeditor_media_embed dev-1.x 41ab6bf

When the command drush ckeditor_media_embed:update is run, it returns this warning:

In LegacyServiceInstantiator.php line 282:

You have requested a non-existent parameter "ckeditor_media_embed_install".

This could be an incompatibility with Drush 12 similar to this issue:
https://www.drupal.org/project/warmer/issues/3368778 💬 Drush 12 compatibility Needs review

Yes, I tried with Drush v11.6.0 and now it's working.

Eduardo Morales Alberti → made their first commit to this issue’s fork.

The problem of #19 and #20 are solved by changing the definition order of the services.
Adding MR

Automatically closed - issue fixed for 2 weeks with no activity.