Remove Dynamic Entity Reference (DER) dependency

Created on 19 July 2023, 12 months ago
Updated 8 March 2024, 4 months ago

Problem/Motivation

πŸ’¬ using dynamic_entity_reference brings in triggers and uninstalling does not get rid of them Active

Steps to reproduce

Proposed resolution

Clone functionality as suggested by @eiriksm in πŸ› Version 2.0.0-alpha1 is incompatible with Drupal 9.5.4. RTBC

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany C-Logemann Frankfurt/M, Germany

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @C-Logemann
  • πŸ‡©πŸ‡ͺGermany C-Logemann Frankfurt/M, Germany
  • First commit to issue fork.
  • Status changed to Needs review 9 months ago
  • πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

    I'm setting to Needs Review because I did a very rough WIP for an idea on how we could do this.

    The gist of the idea:
    Instead of storing the entity_id field as a DER, just store an internal link and derive the entity data from loading the internal path (kind of like the menu_link_content module in core does)

    That way even if the entity has been deleted we would have a reference to where it came from.

    Does this idea gel with the maintainers?

  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    64 pass, 32 fail
  • πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

    The failures are expected BTW, I just need some confirmation on the approach before I tackle those.

  • πŸ‡³πŸ‡΄Norway eiriksm Norway

    I am very open and positive to this. The implementation details can be tweaked too I guess, but I can't see why this would not cover at least most of the usecases. One aspect that I do not know if works or not is if an entity type does not actually have a canonical URL. Is that possible or common? If I created a custom entity type , could I opt to not have it have a canonical URL?

  • πŸ‡©πŸ‡ͺGermany C-Logemann Frankfurt/M, Germany

    First of all @joelpittet’s thank you to move forward on this.

    I currently have no time to review because of customer projects. But in one project I will soon create at least one entity type which don't need a canonical route definition. This makes sense when if an entity is just for storing data or its managed via other entities. A good example is the paragraph module and its entity type. Currently there is no "links" section defined.

  • πŸ‡¨πŸ‡¦Canada joelpittet Vancouver

    I guess for the paragraphs module (and others like it, storage β†’ module for example).

    You'd probably want the host entity URL anyway, right? Currently the URL is shown (when possible) on the report page.

  • πŸ‡³πŸ‡΄Norway eiriksm Norway

    Sure but I was referring to being able to load (or save for that matter) the entity you want to check from the URL πŸ€“

  • πŸ‡¨πŸ‡¦Canada joseph.olstad

    joseph.olstad β†’ made their first commit to this issue’s fork.

  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 4 months ago
    64 pass, 32 fail
Production build 0.69.0 2024