Version 2.0.0-alpha1 is incompatible with Drupal 9.5.4.

Created on 8 March 2023, about 2 years ago
Updated 6 August 2024, 8 months ago

Problem/Motivation

Version 2.0.0-alpha1 is incompatible with Drupal 9.5.4.

The linkchecker 2.0.0-alpha1 module requires the installation of the Dynamic Entity Reference module, version ^3.0 or ^4.0. It turns out that these versions are incompatible with Drupal 9.5.4.

Therefore, it is my understanding that linkchecker 2.0.0-alpha1 is incompatible with Drupal 9.5.4.

Steps to reproduce

Install Drupal 9.5.4
Install Dynamic Entity Reference 8.x-2.0-alpha19
Install Linkchecker 8.x-1.1
And now, try to update to Linkchecker 2.0.0-alpha1, and....

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

2.0

Component

Miscellaneous

Created by

🇧🇷Brazil astutonet Sao Paulo, SP

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @astutonet
  • 🇺🇸United States emptyvoid

    Yeah just assume it is for Drupal 10 only.

    Since the dependency Dynamic Entity Reference pulled a fast one a few months ago and made everything a hard Drupal 10 only.
    Screwed up four modules I'm using that depended on that code.

    (sigh)

    8.x-1.1 GUIs work but the core detection classes fail completely generation 1000s of issues in watchdog.

    Sadly don't have a viable alternative.. have to use 3rd party web crawelers I guess.

  • First commit to issue fork.
  • Status changed to Needs review about 2 years ago
  • 🇦🇺Australia VladimirAus Brisbane, Australia

    Please try this one.
    That should work.

  • 🇺🇸United States DamienMcKenna NH, USA

    I think it should only add ^2.0? Adding ^1.16 might introduce incompatibilities.

  • 🇧🇷Brazil astutonet Sao Paulo, SP

    Yeap! This one in #6 works.

  • Status changed to RTBC about 2 years ago
  • 🇮🇳India rckstr_rohan

    reviewed the issue on Link Checker module on D9.5, MR !41 is good , no issue found after installation.
    Moving to RTBC. Thanks

  • 🇩🇪Germany jurgenhaas Gottmadingen

    For those who want to use this module in version 2 on Drupal 9, until the MR is being merged, you can add a repository and requirement to your composer.json like this:

    "repositories": {
        "drupal/linkchecker": {
          "type": "git",
          "url": "git@git.drupal.org:issue/linkchecker-3346793.git"
        },
        ....
    },
    "require": {
      ....
      "drupal/linkchecker": "dev-3346793-version-2.0.0-alpha1-is as 2.0"
    }
    
  • Status changed to Needs review over 1 year ago
  • 🇩🇪Germany c-logemann Frankfurt/M, Germany

    Since DER is using triggers in Version 2 and 4 the dependency of Linkchecker to DER is very problematic in my opinion: 💬 using dynamic_entity_reference brings in triggers and uninstalling does not get rid of them Active

    Because of the trigger problematic I don't want to test something with v2 2/4 of DER and others need to report about this. The reported Problem. was with v2 of DER.

    I don't want to block people/projects who like to use v2/4 of DER but I would feel better if we just depend on v3 if v1 wouldn't work anymore as reported in #6.

    We don't have a real code fix just to "open" the composer dependency. When @DamienMcKenna is right we can use this:
    "drupal/dynamic_entity_reference": "^2.0 || ^3.0 || ^4.0"

    This will still allow DER v2/v4. But I strongly recommend v3.

    @all testers: Please report which versions of DER and Core you are using. And again: I will not spend any time to test DER v2/v4 setups.

    This Issue is just another reason for me to get rid of this DER dependency and I will discuss this with the other maintainers.

  • 🇩🇪Germany c-logemann Frankfurt/M, Germany

    @DamienMcKenna: Can you share a link or maybe explain what's the problem with DER 8.x-1.16?

    Because DER v3 is only working with D10+ we need a solution for this, too.

  • 🇩🇪Germany jurgenhaas Gottmadingen

    Please report which versions of DER and Core you are using.

    Core 9.5.10
    DER 8.x-1.16

    No issues so far.

    This Issue is just another reason for me to get rid of this DER dependency

    Quite understandably. Features that may depend upon DER should be extracted into their own integration module. That makes dependency management so much easier.

  • 🇳🇴Norway eiriksm Norway

    I can't find the issue right now, but I have previously argued that our dependency on it is there only for that very tiny little functionality, so we could instead just duplicate the parts we need from it. It really is not a lot to duplicate, and the module would be much easier to maintain :)

  • 🇩🇪Germany c-logemann Frankfurt/M, Germany

    @eiriksm Maybe we only discussed this in a chat :-)
    I added a new Issue for that: 📌 Remove Dynamic Entity Reference (DER) dependency Needs review

  • Status changed to RTBC over 1 year ago
  • 🇩🇪Germany jurgenhaas Gottmadingen

    For the original purpose if this issue, I'm setting this to RTBC so that it can be merged and people can then use the 2.x alpha release more easily.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update about 1 year ago
    86 pass
  • 🇩🇪Germany jurgenhaas Gottmadingen

    I have rebased the MR for the latest changes in 2.0.x

    Any chance that this minor change gets committed? Even if not required long-term, it would just solve an issue without the chance of breaking anything.

  • Pipeline finished with Skipped
    about 1 year ago
    #113826
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update about 1 year ago
    86 pass
  • 🇩🇪Germany c-logemann Frankfurt/M, Germany
  • Status changed to Fixed 9 months ago
  • 🇦🇺Australia VladimirAus Brisbane, Australia

    Thank you! Committed! 🥃

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024