Compatibility with Drupal 10.3

Created on 7 May 2024, about 2 months ago
Updated 21 June 2024, 5 days ago

Problem/Motivation

Testing out a site on 10.3.x and getting this error:

Fatal error: Uncaught TypeError: Drupal\monolog\Logger\MonologLoggerChannelFactory::__construct(): Argument #1 ($messenger) must be of type Drupal\Core\Messenger\MessengerInterface, Symfony\Component\HttpFoundation\RequestStack given, called in /data/app/core/lib/Drupal/Component/DependencyInjection/Container.php on line 261 and defined in /data/app/modules/contrib/monolog/src/Logger/MonologLoggerChannelFactory.php:72

Steps to reproduce

  • Add very basic kernel test
  • Add OPT_IN_TEST_NEXT_MINOR=1 to the variables section of .gitlab-ci.yml

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mstrelan
  • Merge request !20OPT_IN_TEST_NEXT_MINOR → (Merged) created by mstrelan
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update about 2 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    about 2 months ago
    Total: 151s
    #165941
  • 🇦🇺Australia mstrelan

    Well that didn't cause tests to fail, I guess because we only have unit tests. Nevertheless, see LoggerChannelFactory no longer implements ContainerAwareInterface and its constructor must be called . However, MonologLoggerChannelFactory does not extend from LoggerChannelFactory, so I'm not sure if that is applicable.

  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update about 2 months ago
    Waiting for branch to pass
  • Pipeline finished with Failed
    about 2 months ago
    Total: 181s
    #165947
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update about 2 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    about 2 months ago
    Total: 150s
    #165950
  • Status changed to Needs work about 2 months ago
  • 🇦🇺Australia mstrelan

    Added a kernel test to demonstrate the issue. Pipeline passing on 10.2.x and failing on 10.3.x.

  • First commit to issue fork.
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update about 1 month ago
    Waiting for branch to pass
  • Pipeline finished with Failed
    about 1 month ago
    Total: 148s
    #175203
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update about 1 month ago
    Waiting for branch to pass
  • Pipeline finished with Failed
    about 1 month ago
    Total: 150s
    #175213
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update about 1 month ago
    Waiting for branch to pass
  • Pipeline finished with Success
    about 1 month ago
    Total: 179s
    #176943
  • Status changed to Needs review about 1 month ago
  • 🇺🇦Ukraine quadrexdev Lutsk

    Maybe there could be a more elegant solution to this problem, but this one at least resolves the issue for my project.

    Please review.

  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update about 1 month ago
    Waiting for branch to pass
  • Pipeline finished with Success
    about 1 month ago
    Total: 149s
    #177005
  • First commit to issue fork.
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update about 1 month ago
    Waiting for branch to pass
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 30 days ago
    Waiting for branch to pass
  • Pipeline finished with Failed
    30 days ago
    Total: 376s
    #183732
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 30 days ago
    Waiting for branch to pass
  • Pipeline finished with Failed
    30 days ago
    Total: 216s
    #183734
  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 30 days ago
    Waiting for branch to pass
  • Pipeline finished with Success
    30 days ago
    Total: 149s
    #183738
  • 🇺🇦Ukraine chesn0k Odessa

    I think we need to back to this since there will be a release Drupal 10.3 soon and this module will block the update

    The changes look good

  • 🇦🇺Australia acbramley

    Bump, 10.3 is out now. The pipeline is green, we should also turn off Drupal CI.

  • Open on Drupal.org →
    Core: 10.2.x + Environment: PHP 8.1 & MySQL 8
    last update 5 days ago
    Waiting for branch to pass
  • Pipeline finished with Skipped
    5 days ago
    #204491
  • Status changed to Fixed 5 days ago
  • 🇮🇹Italy lussoluca Italy

    Committed!

    I'll release a new version of the module later today

Production build 0.69.0 2024