- Issue created by @cgoffin
- Assigned to abhishek_virasat
- Merge request !51Issue #3389739: Argument #1 ($link) must be of type Drupal\linkchecker\LinkCheckerLinkInterface, null given → (Open) created by cgoffin
- last update
almost 2 years ago 86 pass - 🇧🇪Belgium cgoffin
Here also a patch file that can be used in your projects.
- Status changed to Needs review
almost 2 years ago 11:26am 26 September 2023 - last update
almost 2 years ago Patch Failed to Apply - 🇳🇴Norway eiriksm Norway
This sounds like the same issue as https://www.drupal.org/i/3247070 →
Could you have a look there and see if we can close this one and collaborate on a fix in that issue? 🤓
- Issue was unassigned.
- 🇦🇺Australia timfletcher
The workaround for me was to disable link rewriting entirely in the Linkchecker settings (the default is to rewrite links after 3 failed checks).
The patch that returns when no $link is found 🐛 TypeError in LinkStatusHandle.php Needs work suppresses the error in the site logs, but saving a page still shows the white screen (WSOD).
For context, I have LC indexing all rich text fields on my site, including in paragraphs. It hasn't completed scanning all fields yet, not sure if that could be causing any clashes?
- First commit to issue fork.
- last update
about 1 year ago 87 pass - 🇺🇦Ukraine quadrexdev Lutsk
I reproduced this issue and prepared a fix here - https://git.drupalcode.org/project/linkchecker/-/merge_requests/51
a) Added post_update hook to fix orphaned entries in queues
b) Added cleanUpQueues method that is being called in linkchecker_entity_delete for instances of LinkCheckerLinkInterface.
c) Updated/added new testsPlease review
- Assigned to c-logemann
- 🇩🇪Germany c-logemann Frankfurt/M, Germany
Because I could not reproduce this error I only tried to get the MR compatible again.
@quadrexdev Because you could reproduce this error you can maybe check if the additional changes of related issue 🐛 TypeError in LinkStatusHandle.php Needs work comment #19 is needed or not. If you think everything is fine it's ok for me if you merge by yourself.
- 🇺🇦Ukraine quadrexdev Lutsk
I'll take a look, thanks @c-logemann for putting your effort to improve this
- 🇺🇦Ukraine quadrexdev Lutsk
@c-logemann I re-checked this issue, reproduced this problem again, and the changes from MR are fixing the problem. Also, this one - https://www.drupal.org/project/linkchecker/issues/3247070 🐛 TypeError in LinkStatusHandle.php Needs work is about the same problem, so we may close it as a duplicate, no changes required.
P.S. I see that the cspell job is failing now due to the updated cspell.json file from the gitlab templates. Since it will be necessary to update config props/schema -> it is an API change that should be handled in the next major release. Moved it here - https://www.drupal.org/project/linkchecker/issues/3531794 📌 Fix cspell issues Active for 3.0.x.
I can't merge it for some reason, dealing with this