🇧🇪Belgium @cgoffin

And here also a patch for v2.3.0.

Queue worker is added, here also a patch to use in your projects.

cgoffin → created an issue.

I removed the check to see if a file is permanent to allow generating image styles for temporary files. I also upload a patch you can use in your project.

cgoffin → created an issue.

Here also a patch for v2.2.1.

I took a different approach by checking if the openid connect client plugin is an instance of the Keycloak class. I updated the MR and here also a patch file.

cgoffin → made their first commit to this issue’s fork.

I mark this ticket as fixed as the MR is merged and the adjustments are in release 4.1.9.

That is possible indeed when you always use the queue for sending the mails. But if that option isn't checked we cannot use it. That's why I create a new queue item.

Here also a patch for v 6.2.x.

cgoffin → created an issue.

I provided a solution via the issue fork, here also a patch for this solution.

cgoffin → created an issue.

Here also a patch that adds the views handler to the PollChoice entity.

cgoffin → created an issue.

Changes added via fork.

cgoffin → created an issue.

I have no idea why it needed to be reverted, so added it again.

Code changes added. Here also a patch file.

cgoffin → created an issue.

I also noticed that using the DeprecationHandler to render the content sent to the personalization tool, loses the attachments because the elements variable isn't passed by reference anymore. For this reason, I changed the code to do a manual check and call to the right method. Here also a patch for v4.1.8.

It still doesn't work for the Acquia Site Studio modal component. This is because the div containing the modal is replaced to the top of the body and isn't in the context anymore. For this reason I updated the attachment of the behaviors to do it for the full page instead of for only the context. Here also a patch with the adjustment.

I noticed a race condition where the event listener often is added after the triggering of the event. Moving adding the event listener outside of the Drupal behavior fixed this. Commit added and here also a patch against 4.1.8.

I switched the method to retrieve the base url so it also contains the subdirectory (see MR). Here also a patch to use in your projects.

cgoffin → created an issue.

There was a wrong table name in my previous adjustments. Patch updated.

I changed the adjustments of my colleague Marcin by changing the already available unique key entity_uuid to a primary key. This is the same for both tables. We also noticed that the combination of entity_type and entity_id isn't always unique in the subscriber table.

cgoffin → made their first commit to this issue’s fork.

There was a missing newline at the end of the patch file. Here the new version.

I rebased the changes from the dev branch. Here also an up to date patch.

cgoffin → made their first commit to this issue’s fork.

After updating to v2.10 the throbber is rendered when opening the modal, but never removed. This blocks the entire page.

I created a patch from the MR to be used with composer.

I created a patch from the MR to be used with composer.

Here also a patch file.

cgoffin → created an issue.

It seems the upload of the patch file changes the encoding. No idea how to fix this. But in the fork the encoding seems good.

There were some encoding issues in the translation files. Here also a new patch.

Here a new patch against v1.8.0.

@kjl16 @drunken monkey we can also remove the data-autocomplete-appendTo attribute and append it to the parent with the jQuery .parent() selector. Does that sound like a good solution?

uiAutocomplete.element.autocomplete( "option", "appendTo", uiAutocomplete.element.parent());

instead of

uiAutocomplete.element.autocomplete( "option", "appendTo", uiAutocomplete.element.attr('data-autocomplete-appendTo'));

in search_api_autocomplete.js

Nice job adding the localization js files. I extended this by loading the correct js for the active language (a little bit based on how ckeditor5 does it). Here also an updated patch file.

cgoffin → made their first commit to this issue’s fork.

@jrockowitz I helped Dave with this request and during our investigation we also looked at the Webform Attachment submodule. But we don't have an upload field on the webform. Our use case is that a user needs to fill in a webform in order to get the attachment via mail. The attachment isn't uploaded by the visitor. In the email handler you can add text for you mail message, but you can't add an attachment.

We also had a look into extending and even decorating the EmailWebformHandler plugin, but decorating a plugin doesn't seem to work yet (see https://www.drupal.org/project/drupal/issues/2958184 → ). Extending would mean that we have 2 different email handlers or alter the definition of the original plugin to use the extended class. We didn't like having 2 separate handlers only to be able to add an attachment and also wanted to avoid having problems with other modules extending.

Because there is already a check to see if attachments are supported it seemed to be logical for us to add this functionality to the EmailWebformHandler plugin instead of extending.

But what do you think that, for our use case, is the best approach?

cgoffin → made their first commit to this issue’s fork.

cgoffin → made their first commit to this issue’s fork.

apaderno → credited cgoffin → .

Found another place where there is a PHP deprecation message, see attached patch.

Another patch for 1.4.0.

Found another bug with missing use statements.

Fixed a bug in de code changes.

I tried to refactor, but also messed up some branches. My apologies. I created the new branch 3390319-add_queue_mechanism which started from the 1.0.x version. Here also a patch file to use in your projects.

apaderno → credited cgoffin → .

I think it is also better to catch all exceptions thrown, because we now sometimes see a '503 Service Unavailable'.

cgoffin → made their first commit to this issue’s fork.

cgoffin → created an issue.

cgoffin → created an issue.

Here also a patch against the 1.0.0 version.

cgoffin → created an issue.

And also a patch that applies to the 1.0.0 version.

Here also a patch file to be used in your projects.

cgoffin → created an issue.

Here also a patch file that can be used in your projects.

cgoffin → created an issue.

I also uploaded attachments larger than 3MB without a problem. Maybe the Graph mail documentation isn't accurate?

I changed the logic to add the attachments conform to what the webform module returns and also what the symfony_mailer module uses. Here also a patch file.

cgoffin → made their first commit to this issue’s fork.

Tested and worked fine.

I added the from address back to the mail_body. We have a mailbox with mail aliases and to make sure the correct from address is set, we need the from address.

Code added to the issue fork, here also a patch file.

cgoffin → made their first commit to this issue’s fork.

Here a patch to fix the problem. I also reverted https://www.drupal.org/project/graph_mail/issues/3383302#comment-15221696 📌 Use 'From' email address for the sendmail POST user ID RTBC based on my comment.

I updated the patch.

Which part of the patch isn't on topic?

For me this is also a breaking change. I also think you should never allow to use the from address because it can cause e-mails not being send, or seen as SPAM. To avoid this, the reply-to header/property is used. In this way you can send from a general mailbox, but the receiver can still reply to the mail.

The webform module also makes use of the reply-to header and populates it with the from address if not filled in.