Drupal 10 compatibility for 1.x version

Patch looks good but need to remove depreciated function too. please refer the the article and replace all the decpreciated functions, https://api.drupal.org/api/drupal/deprecated/9.3.x?type=&deprecated_textfilter=&order=reference_count&sort=desc

Please check, I created merge request for branch 8.x-1.x. Checked by Drupal upgrade status, there is no depreciated function at now.

Drupal 10 compatibility 8.x-2.0-alpha5 version released.

Are there any plans on updating the 8.x-1.0-version to be Drupal 10-compatible and what is the future for the 1.0-branch?

The issue I have with updating to 8.x-2.0 is that it is using the menu_link-field module. I haven't any documentation for migrating the menu items from menu_ui to menu_link-fields.

If you have an existing site the issue becomes that the menu links created via menu_ui are not shown to the end user, presenting them with an empty menu item field. To the user it seems that the page does not have a menu link item attached to it and it may lead to a user adding a duplicate menu entry to the same content.

There is also no way of updating/removing the old menu item without navigating to "Admin - Structure - Menu - Manage" which is in my case a hurdle as we have large menus and finding correct items in the structure is complicated without the ability to do so in the "edit node"-form.

I've applied all the rector patches in the Merge request so far, but it doesn't appear that that is enough to get the module D10 ready. It appears there must be a change in the way the menu link is handled in Drupal 10. If a maintainer is here and can shed light on their plans for the module it would help to determine whether it would be time well spent to try and get the module going on Drupal 10 or not.

Are there any plans on updating the 8.x-1.0-version to be Drupal 10-compatible and what is the future for the 1.0-branch?

I have the exact same need/question. I would like to use the 1.0 version on D10.

I spent a good chunk of time digging in and trying to figure out why this module is not working, and I didn't come out of it with an answer for how to make it work, I can see what is going on in this module that isn't working.

In menu_link_weight.node.inc\menu_link_weight_form_node_form_alter The code checks whether $form['menu']['link'] is set. $form['menu'] itself never exists, so the alter never runs. There is a hook in core menu_ui.module: menu_ui_form_node_form_alter that should be setting that up, but that alter is never run. The menu part of the form appears to be being handled somewhere else in Drupal 10.

I tried searching for change records → that might highlight what has changed but came up empty there too.

I'm sorry. I was testing on an install that wasn't fresh. Specifically, it had the menu_link module installed. The menu_link module disrupts how the menu_link is added to the form and causes this module not to work.

This seems less than ideal because the similarity of the module names may lead some to believe that this is a module in the menu_link ecosystem when in fact, installing menu_link will break this module. I'll try to do a bit more in-depth research into this, and open a separate ticket. For now though, on a clean install, the module does seem to work on Drupal 10.

I hope someone can review it.

The current state of the open merge requests don't fully provide D10 compatibility. So I am attaching a patch instead.

I have attached a patch that provides D10 compatibility for the 1.0 version (8.x-1.0) of this module.

Ahead of a new 8.x-1.x release of this module, you can apply this patch using composer-drupal-lenient to allow you to upgrade to Drupal 10.

ultrabob → closed merge request !9

Merge Request 7 now has the change to the .module file that @ChrisSnyder added in his patch. I have confirmed that the module continues to work on a D10 with the change applied, so I'll leave it marked RTBC

Thanks everyone, I'll try to get this released shortly.

Awesome! Thanks @ultrabob

Automatically closed - issue fixed for 2 weeks with no activity.

Found another place where there is a PHP deprecation message, see attached patch.