Is this still an issue with the latest versions of Drupal? Is this reproducible without other CKEditor modules enabled?
Fixed in 2.0.0
Thank you for catching this azinck!
The composer-merge plugin is a necessary evil, mainly because Drupal does not have a clean way of managing frontend dependencies that a contrib module/theme may require. The plugin makes it easier to manage these depenencies of dependencies that may have their own "repositories" that need to be defined.
Some examples:
- Recomended use by the webform module → ( community docs saying the same thing →
- Use by Better Exposed Filters ✨ Add composer.libraries.json Active
- Use by Timepicker module
- Use by the Klaro consent management module → :
Created a patch file from MR to allow patching this issue on my project. It may be helpful for others who run into this issue before it is resolved in a release.
chrissnyder → created an issue.
This module is great for indexing content into Coveo using Search API. For rendering the search experience on the frontend I would recommend leveraging the components provided by Coveo to take advantage of Coveo's features (UI, Facets, Usage, Analyitics). I would recommend exploring Coveo Atomic
Created a patch file from MR to allow patching this issue on my project. It may be helpful for others who run into this issue before it is resolved in a release.
Created a patch file from MR to allow patching this issue on my project. It may be helpful for others who run into this issue before it is resolved in a release.
Created a patch file from MR to allow patching this issue on my project. It may be helpful for others who run into this issue before it is resolved in a release.
The changes in the MR address this issue. The URL pattern for HIPAA coveo instances should be confirmed as I was only able to verify the pattern for non-HIPPA coveo instances.
chrissnyder → created an issue.
chrissnyder → created an issue.
chrissnyder → created an issue. See original summary → .
Merge request !23 should address the issue.
chrissnyder → created an issue. See original summary → .
When I create modules/libraries I normally target the supported versions. This allows the use of the latest features of the language/framework and makes maintaining it easier.
PHP 7 and PHP 8.0 are currently EoL (End of Life). Drupal 8 and 9 are also considered EoL. When I create code i normally target the supported versions.
What version of Drupal and PHP are you trying to use this module on?
And thank you for submitting a patch that can be used by others who many be trying to use this module on older versions.
chrissnyder → made their first commit to this issue’s fork.
Fixed in 2.1.2
Fixed. This was included in the 2.1.1 release
To address this issue we will no longer override ConfigFormBase::__construct()
chrissnyder → created an issue.
Addressed the phpcs, eslint, and cspell issues. The PHPStan issue will be corrected in a follow up issue because it related to a D10.3/D11 change.
chrissnyder → created an issue.
chrissnyder → created an issue.
Tested. This fix works.
@ansonwhan This change works. I think you can tag a new release with this feature.
chrissnyder → changed the visibility of the branch 3331113-cant-override-configuration to hidden.
chrissnyder → made their first commit to this issue’s fork.
> I don't think we will backport this on 2.x branch.
A backport to the 2.x branch would be welcome. Should I open a new ticket to patch the 2.x branch or add a patch to this issue for 2.x?
chrissnyder → made their first commit to this issue’s fork.
smustgrave → credited chrissnyder → .
There are still errors and issues that need to be addressed See https://git.drupalcode.org/project/sitewide_alert/-/merge_requests/49
There are still deprecations that need to handled in order to make this module combatible with Drupal 11. Updated and new MRs welcome!
See the failed phpstan tests on the MR or those seen in sitewide_alert.2.2.1.upgrade_status.post_rector.txt → .
chrissnyder → made their first commit to this issue’s fork.
ChrisSnyder → made their first commit to this issue’s fork.
ChrisSnyder → changed the visibility of the branch 3349054-javascript-operators-in to hidden.
Core issue. Resolved by 🐛 JavaScript operators in Needs work .
If the filter allowed tags is checked everything is stripped except the allowed tags. It should skip to filter this part of the content, no?
It does not. The filter operates separately from the CKEditor HTML Embed plugin. There are cases (security, design adherance, perdicatable markup, etc) where a site's configuration will still want to limit the allowed tags even when using the HTML Embed plugin.
On the text format that has the HTML Embed button, do you have "Limit allowed HTML tags and correct faulty HTML" filter enabled? If you do, does the issue still occur if you disable that filter?
On the text format that has the HTML Embed button, do you have "Limit allowed HTML tags and correct faulty HTML" filter enabled? If you do, does the issue still occur if you disable that filter?
kopeboy is correct. The best solution is to create an additional text format.
ChrisSnyder → made their first commit to this issue’s fork.
Has anyone tested this patch to make sure it still works for sites using Bootstrap 4? We should ensure it does not cause any regressions for those still using Bootstrap 4.
@UriDrupal The patch/changes were merged, and a new release was deployed.
Update to the latest version of the module with the change: composer require drupal/address_map_link:^1.4
Merged and new release tagged. Sorry for the delay on this.
ChrisSnyder → made their first commit to this issue’s fork.
Should this be a configurable option on the text format?
I have tried, but unfortunately, I am not able to reproduce the issue. Is there any additional context you can provide? Does this happen if you clear PHP opcaches or any other caching that might be caching the container (memcache/redis)? Does the issue still occur on the latest version of Drush 12, Drush 12.4.3? ARe there any additional logs or stack traces you can provide for this issue?
I don't think this is possible within the scope of this module. If needed this need to be resolved within the External Link Popup module see https://www.drupal.org/project/external_link_popup/issues/3303109 → .
ChrisSnyder → made their first commit to this issue’s fork.
ChrisSnyder → made their first commit to this issue’s fork.
@liquidcms Is this still an ongoing issue?
Would it be possile to include this feature as a configuration option so that the existing functionality is preserved for those who need it and the new ability to avoid the extra request is avoided for others?
There are no current plans. However, this is a good idea. If a MR with this feature is introduced I would be happy to include it in the next release.