Add "title" attribute to YouTube, Vimeo, and Playlist embeds

Based on patch from #11, but I made few small improvements:
1. No new translation strings, since there's almost 80k installations and some/many of them might have made translations.
2. Removed unrelated coding standard fixes, so its easier to review and get committed.
3. Corrected the return type of oEmbedData()

Added the related issue 📌 Accessibility enhancements for html output of iframe tag (title, id, name, inner A link) Needs review . Patch → on issue has some related/duplicate code, but it has two interesting features that might be left for follow-up:
- Transliterates and removes some unwanted characters from the title.
- Adds $instace_id argument to renderEmbedCode, so title's will be unique if there's multiple instances of same video on page.

And caching the response.

Added the tests and removed single undefined function (filterCharaters()) from patch on #13.

This fixes the tests other than ProviderUrlParseTest. That would need updating mocks. I'm willing to do that, if that increases the changes of commit.

Thanks for the fixes +1

And small improvement by handling the cases if returned json is not valid.

And small improvement by handling the cases if returned json is not valid.

Watchout: #11 is the last patch supported on PHP:7.4.

All the more recent patches contributed afterwards (#12 to #18) use the null safe operator (?->) which is supported from PHP 8 onwards, therefore crashes on PHP 7.4, with the following error:

The website encountered an unexpected error. Please try again later.
ParseError: syntax error, unexpected '->' (T_OBJECT_OPERATOR) in Composer\Autoload\{closure}() (line 110 of modules/contrib/video_embed_field/src/Plugin/video_embed_field/Provider/YouTube.php).

It would be great if we could get a more recent version of the patch compatible with 7.4, but that's not necessarily a priority,

Otherwise, patch from #18 works great on PHP 8.1.

Thanks again to everyone for the great help with this ticket and contributions.

Small change to decrease severity of logging. This could be debated, but the reasoning is that it will produce noise to logs (eg. when forwarding only emergency/critical/error messages to log service) everytime private video is rendered on cold caches.

+++ b/src/ProviderPluginBase.php
@@ -103,6 +103,42 @@ abstract class ProviderPluginBase extends PluginBase implements ProviderPluginIn
+        $data = json_decode($body);

I think it would be best to use \Drupal\Component\Serialization\Json::decode

+++ b/src/Plugin/video_embed_field/Provider/Vimeo.php
@@ -48,11 +49,12 @@ class Vimeo extends ProviderPluginBase {
+    $url = sprintf("https://vimeo.com/api/oembed.json?url=%s", $this->getInput());

Shouldn't we use Url::fromUri(...)->toString(), so the url parameter is properly encoded?

Whoops, discard patch #22, I forgot point 2.
This implements both points.

wrong interdiff in #23...

I forgot to update Vimeo::getRemoteThumbnailUrl... This should work.
It also addresses #20 I believe (PHP 7.4 compatibility) but I have not tested that to confirm.
Attaching new interdiff, still from 21.

I have 2 more suggestions:

1. Normalize URLs before requesting the oembed endpoint
Most providers accept multiple URL patterns, but this isn't necessarily true when requesting the oembed data.
I noticed that many providers only accept some URL patterns when passed to the oembed endpoint.
And unlike core's Media oembed, video_embed_field doesn't validate that the given URL returns oembed data, before saving/storing data.
It is relevant for getting Youtube playlist title, e.g:
- Raw URL (we get the video title): https://www.youtube.com/oembed?url=https%3A%2F%2Fwww.youtube.com%2Fwatch...
- Normalized (we get the playlist title): https://www.youtube.com/oembed?url=https%3A%2F%2Fwww.youtube.com%2Fplayl...

Also, normalizing would also prevent unnecessary calls to the endpoint for minor/irrelevant URL changes (e.g. http/https, www/non-www, query strings changing, etc).
This is especially relevant when combined with other patches accepting more patterns, such as #3060201: Youtube Privacy Enhanced Mode (using -nocookie.com) (8.x-1.x) → .
I have added some more test cases.

2. Small change to title format
What about normalizing the titles to "@provider | @title" instead of "@provider Video (@title)".
The video title often contains parentheses, and some providers are not necessarily videos.

james.williams → made their first commit to this issue’s fork.

I've spun up a merge request for the most recent patch. However, I'm no fan of the title format, especially as it is forced even when no title could be retrieved from the oembed data - which can make it look something like 'Vimeo | 12345'. Perhaps the title could be made configurable and/or skipped over if it wasn't retrieved from the oembed data?

OK - see my last commit; the format of the title is now configurable (which avoids adding a new translatable string too), and there's a configuration option to avoid falling back to using the video ID. So by default, titles will come out using that '@provider | @title' format, but those of us who might want something else can configure that to '@title' and untick the box to use a fallback at all.

Tests are finally passing via phpunit :)