🇨🇦Canada @RobLoach

robloach → created an issue.

Confirmed it's something with the action module. Try this...

drush pm:install action
drush cr

Visit /admin/structure/ai-agent/add

You get the white screen:

The website encountered an unexpected error. Try again later.

Error: Call to a member function newInstance() on null in Drupal\ai\Plugin\AiFunctionCall\Derivative\ActionPluginDeriver->resolveRootDataType() (line 183 of modules/contrib/ai/src/Plugin/AiFunctionCall/Derivative/ActionPluginDeriver.php).

MR over at https://git.drupalcode.org/project/ai/-/merge_requests/624

May not be the best solution around it though. Perhaps we have it return the same `$type` instead of an empty string?

Pushed up a change over at https://www.drupal.org/project/ai/issues/3525540 🐛 Error: Call to a member function newInstance() with ActionPluginDeriver Active ... May not be the best solution around it though. Merge Request: https://git.drupalcode.org/project/ai/-/merge_requests/624

robloach → created an issue.

Looks good, thanks. Do we need to update the docs for this? Seems intuitive enough to not really need mentioning 🤷

The other thing I'd like to have when entering drush ai is an interactive shell that continuously chats with you back and forth.

Here's the initial Merge Request that includes the basic drush ai:chat command that sends the request to the LLM. Would love some ideas on how it could improve.

I think it would be really cool to expose some function calling to allow the AI to run Drush commands for you. Then you could do stuff like...

drush ai "Create a log in link for Jeff, and then clear the cache"

robloach → created an issue.

The issue exists in both 1.1.x and 1.0.x.

The merge request is at https://git.drupalcode.org/project/ai_agents/-/merge_requests/118 to fix this.

robloach → created an issue.

robloach → changed the visibility of the branch 3516448-fatal-error-on to hidden.

Ran into this when upgrading to the latest 1.1.x, and the proposed change fixed it. In the Merge Request, I fixed up the whitespace. Looks good, but would appreciate another eye.

robloach → made their first commit to this issue’s fork.

Attached is the patch against Drupal 10.4.x, with the non-consequential parts removed to avoid the conflicts.

hestenet → credited robloach → .

hestenet → credited robloach → .

Added a few updates in the markdown as well. MR here: https://git.drupalcode.org/project/distributions_recipes/-/merge_request...

robloach → made their first commit to this issue’s fork.

This was fixed in the upstream AI module. Should be part of 1.1.

Looks pretty good, had just one non-consequential question at https://git.drupalcode.org/project/ai_agents/-/merge_requests/102#note_5... .

Having getter/setters for chatHistory makes sense to me. We could add docs @see-ing the functions, but the rest of the protected variables don't do this, so I'd say this is good to go either way.

Uploaded an alternative solution over at https://www.drupal.org/project/ai/issues/3520814 🐛 Call to undefined method OpenAiChatMessageIterator::getTools() Active .

Optimally, we should be strict about the getTools() method being in the interface, but I think this is a good work-around for providers that may not implement getTools(). Merge request over at https://git.drupalcode.org/project/ai/-/merge_requests/572 .

robloach → created an issue.

Added toggles for the TITLE and DESCRIPTION to make it backward compatible, and allows you to manually provide the file if you really want to.

Got an idea for the upgrade path: Add a checkbox for title and description which toggles whether or not they're displayed. Default to ON.

Ran into this issue. The Merge Request fixes it, though it looks like the tests failed. I'm not 100% sure, but are these the new class names?

• ToolsInput
• ToolsFunctionInput

Thanks for the changes.

Thanks for pushing up the module, davituri. I've started bringing in features from my original prototype into this module. The first part is dynamically building the Title and Description: https://www.drupal.org/project/llmstxt/issues/3519314 📌 Add Title/Description to Config Page Needs review

Providing fields for the people to enter information, rather than having them write markdown, will ease the user experience, and perhaps allow the llms.txt file to be a bit more dynamic.

robloach → created an issue.

Improved some of the JavaScript in the MR here:
https://git.drupalcode.org/project/ai_agents/-/merge_requests/79

Nothing changes for the user, it just removes jQuery, adds Drupal Behaviors, along with once().

robloach → created an issue.

Thanks, this directory should be fine to remove.

robloach → created an issue.

robloach → created an issue.

robloach → created an issue.

There's a lot of conflicts in here.

Worked well here. I added a small tweak so that it doesn't call prePrompt() twice. This applies to both 1.1.x and 1.0.x.

robloach → made their first commit to this issue’s fork.

Tested locally, and worked here.

Side-note: Should we also check the validity of $value[$id . '_model'] ?

robloach → created an issue.

quietone → credited robloach → .

Minor change. Worked locally.

Minor updates. Working on D11.

Tested locally, and worked well.

hestenet → credited robloach → .

robloach → created an issue.

Here's the patch against 4.2.x.

@avpaderno Looks like it's now validating on https://www.rssboard.org/rss-validator/check.cgi?url=https%3A%2F%2Fwww.k...

The W3C one seems to have a cached version, or something.

This is relevant on 10.3.x?

We ran into something similar on the Vimeo URLs. The options that you pass in as URL parameters are stripped when creating the iFrame for the oembed.

Thanks for the review. I'll have a look to see if we can get the feed validating.

robloach → created an issue.

Tested this out, and worked flawlessly. Was confused when running the related SQL it didn't output any results. This patch fixes the false positive.

The diff applies to Drupal 10.3 as well, so just a rebase/cherry-pick should work fine, but here's the same patch if needed.

I believe this was fixed in the upstream github repo at https://github.com/pantheon-systems/search_api_pantheon/pull/197 .

If you're on composer, you can use that instead of the Drupal repo...

``` json
"pantheon-systems/search_api_pantheon": "^8",
```

Aside from Alex Pott tone updates, it looks like there are some changes that seem unrelated to adding recipe API docs? Namingly...

1. In EntityCreate.php
2. SimpleConfigUpdate.php

I made the comments inline on the MR at https://git.drupalcode.org/project/distributions_recipes/-/merge_request...

kim.pepper → credited robloach → .

And here's the patch from 3.0.3

Fixed the merge conflict.

Fixed in https://git.drupalcode.org/project/newrelic_transactions/-/commit/961bbc...

Done.

robloach → made their first commit to this issue’s fork.

robloach → created an issue.

robloach → made their first commit to this issue’s fork.

The Merge Request still applies cleanly. Here's the patch.

Sounds like there were some chnages to the pipeline? Mind having another look at the test results and pulling the latest into this new branch? Thanks!

Pushed forwards.

Thanks!

robloach → made their first commit to this issue’s fork.

Merged! Thanks so much for pushing this forwards.

robloach → made their first commit to this issue’s fork.

+1 While I am unable to add Maintainers, I do have the ability to make commits. If you go through the issue queue, and mark some as RBTC, I'm happy to push changes forwards.

robloach → created an issue.

robloach → created an issue.

What @thony1199 brought up originally is about using a strict Content Security Policy, which can block external network requests. It's best to bring down external libraries, and serve them directly through Drupal.

Whether or not that's the primary concern, it does make sense to remove this library outright. Internet Explorer was retired two years ago on June 15, 2022, and is no longer supported by Drupal. The polyfill is no longer needed.

Looks good!

Thanks so much, dolszewski!

An hard opinionated option would be to explicitly require Drupal >=10.2.

RobLoach → created an issue.

Thanks!

Thanks a lot for the update here. Really appreciate it.

Thanks so much for the fix!

RobLoach → made their first commit to this issue’s fork.

Yes, you'll have to add both cases. The exact string that's passed through the t() function.