Earth
Account created on 18 May 2006, about 18 years ago
#

Merge Requests

More

Recent comments

πŸ‡¨πŸ‡¦Canada RobLoach Earth

What @thony1199 brought up originally is about using a strict Content Security Policy, which can block external network requests. It's best to bring down external libraries, and serve them directly through Drupal.

Whether or not that's the primary concern, it does make sense to remove this library outright. Internet Explorer was retired two years ago on June 15, 2022, and is no longer supported by Drupal. The polyfill is no longer needed.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Looks good!

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Thanks!

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Thanks a lot for the update here. Really appreciate it.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Thanks so much for the fix!

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Yes, you'll have to add both cases. The exact string that's passed through the t() function.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Looks like a PHPUnit test is failing.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

I'm fine with that. Thanks @DamienMcKenna.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth
πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Technically that's a dupe of this one, check the creation dates :) .... Either way I'm happy to have more eyes on fixing caching.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Updated the patch to the latest in 3.0.x, and removed the list syntax change as it's unrelated.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Found another PHP strict issue. Here's a patch for plain too...

πŸ‡¨πŸ‡¦Canada RobLoach Earth

While I understand re-saving the configuration can fix this, one should likely not depend on $this->configuration['swiftmailer'] always being there. With the config not there, this code would be fine in PHP <= 5, but PHP is a bit more strict nowadays. I'd recommend bringing this change in because it will save many other cases where this issue occurs.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ created an issue.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Opened as a 3.x release. Thanks, all!

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Thanks so much, Mauricio! Really appreciate it.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Siri, send me patches for all the modules. Thanks.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Thanks @apaderno... I'll keep watch on the other issue, and re-consider this queue if there's no progress.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

IIRC, Drupal 9.5 requires PHP >= 8.0, so may need to do one of these...

https://git.drupalcode.org/project/components/-/merge_requests/37

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Thanks for the updates. Good catch.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

RobLoach β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Would like to get a stable version out, but would love to get this issue in beforehand: https://www.drupal.org/project/components/issues/2707849 ✨ Allow components to define asset libraries Needs work

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Thanks for all the work here, everyone. How does this approach differ from https://www.drupal.org/project/components/issues/2707849 ✨ Allow components to define asset libraries Needs work ?

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Small fix to switch the string to use single-quotes instead of double quotes. We're not processing any variables in the string so ' is what we want. Thanks all!

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Nice work, all. Patch applies well. I like where this is going, but the new asset library integration is missing some tests. Would it be possible to add a small check to see if library assets are applied?

For those who prefer git over .patches:

* MR: https://git.drupalcode.org/project/components/-/merge_requests/36
* Issue Fork: https://git.drupalcode.org/issue/components-2707849/-/tree/2707849-allow...
* Diff: https://git.drupalcode.org/project/components/-/merge_requests/36.diff

πŸ‡¨πŸ‡¦Canada RobLoach Earth

I'm not sure about applying this to 2.x when the 3.x branch already targets Drupal 9/10. Make the upgrade to 3.x instead.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Also note that there's a new version of the module at https://www.drupal.org/project/ckeditor_a11ychecker/issues/3394274 πŸ“Œ Create a version compatible with CKEditor5 Needs review

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Have another volunteer ;-) https://www.drupal.org/project/ckeditor_a11ychecker/issues/3416325 πŸ’¬ Offer to help Co-Maintain Needs review

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Two feedback items...

  1. Update SVG icon to be the standard accessibility icon https://www.svgrepo.com/svg/501803/a11y
  2. Update label to be "Accessibility Checker", as it is a bit more user-friendly
πŸ‡¨πŸ‡¦Canada RobLoach Earth

Keeping it in here is fine. Thanks, ilfelice.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Thanks for the updates!

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Works well! Nicely done. Happy to help maintain the module to help push this patch forwards as a 3.x release if anyone adds me as a maintainer. Thanks again, @o_tymoshchuk.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Nice work! While this could do it for CKEditor 4, the CKEditor 5 approach may be more desirable for some:
https://www.drupal.org/project/ckeditor_a11ychecker/issues/3394274 πŸ“Œ Create a version compatible with CKEditor5 Needs review

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Dup https://www.drupal.org/project/ckeditor_a11ychecker/issues/3296732 πŸ“Œ Automated Drupal 10 compatibility fixes RTBC

πŸ‡¨πŸ‡¦Canada RobLoach Earth

I'm happy to help push this patch up and make a release if anyone adds me as a maintainer.

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Need a namespace declaration at the top of BalloonPanelPlugin.php...

``` php
use Drupal\Core\DrupalKernel;
```

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Dup https://www.drupal.org/project/ckeditor_balloonpanel/issues/3296738 πŸ“Œ Automated Drupal 10 compatibility fixes RTBC

πŸ‡¨πŸ‡¦Canada RobLoach Earth

Thanks for putting together the module. I did laugh when I saw it.

The library is licensed MIT or GPL-2, so there's no problem copy/pasting it directly into the module. Happy to make consumption and maintenance easier. It is available on Packagist as a `component` type:
https://packagist.org/packages/robloach/jquery-once

Though, that could complicate things, as it specifies a dependency on components/jquery. Removing the defined dependency may make things easier?

Also, if anyone wants to help maintain the library, lemme know in the github.

Production build 0.69.0 2024