robloach → created an issue.
Here's the patch against 4.2.x.
@avpaderno Looks like it's now validating on https://www.rssboard.org/rss-validator/check.cgi?url=https%3A%2F%2Fwww.k...
The W3C one seems to have a cached version, or something.
This is relevant on 10.3.x?
We ran into something similar on the Vimeo URLs. The options that you pass in as URL parameters are stripped when creating the iFrame for the oembed.
Thanks for the review. I'll have a look to see if we can get the feed validating.
robloach → created an issue.
Tested this out, and worked flawlessly. Was confused when running the related SQL it didn't output any results. This patch fixes the false positive.
The diff applies to Drupal 10.3 as well, so just a rebase/cherry-pick should work fine, but here's the same patch if needed.
I believe this was fixed in the upstream github repo at https://github.com/pantheon-systems/search_api_pantheon/pull/197 .
If you're on composer, you can use that instead of the Drupal repo...
``` json
"pantheon-systems/search_api_pantheon": "^8",
```
Aside from Alex Pott tone updates, it looks like there are some changes that seem unrelated to adding recipe API docs? Namingly...
- In EntityCreate.php
- SimpleConfigUpdate.php
I made the comments inline on the MR at https://git.drupalcode.org/project/distributions_recipes/-/merge_request...
kim.pepper → credited robloach → .
And here's the patch from 3.0.3
Fixed the merge conflict.
Done.
robloach → made their first commit to this issue’s fork.
robloach → created an issue.
robloach → made their first commit to this issue’s fork.
The Merge Request still applies cleanly. Here's the patch.
Sounds like there were some chnages to the pipeline? Mind having another look at the test results and pulling the latest into this new branch? Thanks!
Pushed forwards.
robloach → made their first commit to this issue’s fork.
Merged! Thanks so much for pushing this forwards.
robloach → made their first commit to this issue’s fork.
+1 While I am unable to add Maintainers, I do have the ability to make commits. If you go through the issue queue, and mark some as RBTC, I'm happy to push changes forwards.
robloach → created an issue.
robloach → created an issue.
What @thony1199 brought up originally is about using a strict Content Security Policy, which can block external network requests. It's best to bring down external libraries, and serve them directly through Drupal.
Whether or not that's the primary concern, it does make sense to remove this library outright. Internet Explorer was retired two years ago on June 15, 2022, and is no longer supported by Drupal. The polyfill is no longer needed.
Thanks so much, dolszewski!
An hard opinionated option would be to explicitly require Drupal >=10.2.
RobLoach → created an issue.
Thanks a lot for the update here. Really appreciate it.
Thanks so much for the fix!
RobLoach → made their first commit to this issue’s fork.
Yes, you'll have to add both cases. The exact string that's passed through the t() function.
RobLoach → created an issue.
RobLoach → created an issue.
Looks like a PHPUnit test is failing.
Thanks!
RobLoach → created an issue.
I'm fine with that. Thanks @DamienMcKenna.
RobLoach → created an issue.
RobLoach → created an issue.
RobLoach → created an issue.
Thanks!
RobLoach → made their first commit to this issue’s fork.
RobLoach → created an issue.
RobLoach → created an issue.
RobLoach → created an issue.
RobLoach → created an issue.
RobLoach → made their first commit to this issue’s fork.
RobLoach → created an issue.
RobLoach → created an issue.
RobLoach → created an issue.
RobLoach → created an issue.
RobLoach → created an issue.
RobLoach → created an issue.
RobLoach → created an issue.
RobLoach → created an issue.
RobLoach → created an issue.
RobLoach → made their first commit to this issue’s fork.
RobLoach → created an issue.
Technically that's a dupe of this one, check the creation dates :) .... Either way I'm happy to have more eyes on fixing caching.
Updated the patch to the latest in 3.0.x, and removed the list syntax change as it's unrelated.
Found another PHP strict issue. Here's a patch for plain too...
While I understand re-saving the configuration can fix this, one should likely not depend on $this->configuration['swiftmailer'] always being there. With the config not there, this code would be fine in PHP <= 5, but PHP is a bit more strict nowadays. I'd recommend bringing this change in because it will save many other cases where this issue occurs.
RobLoach → created an issue.