Earth
Account created on 18 May 2006, over 19 years ago
#

Merge Requests

More

Recent comments

🇨🇦Canada RobLoach Earth

Having a follow up makes sense. Tested and the variable comes in the template correctly. Thanks!

🇨🇦Canada RobLoach Earth

Can do some research around this, while paired with Create Document Loader Normalization Layer Active

ETD 1w

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

I'm not sure field_validation is required across all of those modules. Looking through the class usage, it looks like...

  • ai_validation: Requires token
  • ai_validation: Requires field_validation
  • ai_content_suggestions: Require token
  • ai_content_suggestions: Requires field_widget_actions
  • ai_automators: Requires field_widget_actions

Doing a search for use Drupal\field_validation or use Drupal\field_widget_actions is an one way to find the PHP class dependencies.

🇨🇦Canada RobLoach Earth

I was having a look through this, and while I cleaned up the z-index usage by overriding the Olivero styles, it broke Olivero's Toolbar on Mobile.

@thamas, are you able to have a look? You likely know more than I in this matter. A better solution may be to shift the body over, perhaps.

🇨🇦Canada RobLoach Earth

Where to place AI CKEditor tool in toolbar. Maybe on the farthest right, or to the left of "Source"

To the left of "Source" makes sense to me.

I'm currently trying to decide which AI tools should be enabled with this recipe. Maybe "Generate with AI", "Reformat HTML", and "Summarize". We could also enable them all, or provide a boolean recipe input for each tool

Those three are good. Doing all of them may overwhelm the user.

One issue I've run into, with setProperties and simpleConfigUpdate, we'll have to also set other settings in editor.editor.content_format, including "ckeditor5_alignment", "ckeditor5_heading", "ckeditor5_list", "ckeditor5_sourceEditing", and "media_media", otherwise it throws an error. In other words, we'll have to override all existing config for the Content text format, unless there's a config action I'm unaware of. This might be an opportunity for a new config action.

Artem referenced this long-running issue: https://www.drupal.org/project/distributions_recipes/issues/3431330#comm...

Maybe having the override for the existing config is the best way. I like your idea of introducing a new config action for this, but starting small is likely best. Mind creating a new issue for that?

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

robloach made their first commit to this issue’s fork.

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

When installing the Gemini Provider, it selected the newly correct values. Nice find on that notice.

Question: Should we worry about an upgrade path from embedding-001 to gemini-embedding-001?

🇨🇦Canada RobLoach Earth

While this changeset is working, I have two questions...

  1. I believe DeepChat will replace this one. Should we also apply the same thing there, or is what's there acceptable?
  2. Since we have the `role` available, I think we could likely use it in the existing template?
  3. diff --git a/modules/ai_chatbot/templates/ai-chatbot-message.html.twig b/modules/ai_chatbot/templates/ai-chatbot-message.html.twig
    index 12769104..142aae31 100644
    --- a/modules/ai_chatbot/templates/ai-chatbot-message.html.twig
    +++ b/modules/ai_chatbot/templates/ai-chatbot-message.html.twig
    @@ -6,7 +6,7 @@
       ]
     %}
     
    -<div class={{ classes|join(' ') }}>
    +<div class="{{ classes|join(' ') }}"{% if role %} role="{{ role }}"{% endif %}>
     
     	<img src="{{ bot_image }}" alt="" width="32" height="32">
     
    
🇨🇦Canada RobLoach Earth

I can test this one out.

🇨🇦Canada RobLoach Earth

Thanks, rebase did it.

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

Yeah, copied the entries from the other listings. We could likely correct them, though I assume Artem is good with it :)

🇨🇦Canada RobLoach Earth

EZ

🇨🇦Canada RobLoach Earth

Updated the relevant documentation for follow ups from the release, including...

  • Slack communications
  • Heading Text
  • Release notes process

Merge Request: https://git.drupalcode.org/project/ai/-/merge_requests/1090

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

The releases are out, though we could tackle a few follow ups...

  1. Ensure the release notes github repo is solid
  2. Update documentation about the Slack message copy
🇨🇦Canada RobLoach Earth

Here's a screenshot with the CSS fix Merge Request:

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

In a mobile context, the Close button appears. This is the CSS that hides the close button when you're on desktop...

ai/modules/ai_chatbot/css/toolbar-chatbot.css

@media (min-width: 1024px) {
  .toolbar-button.close {
    display: none;
  }
}
🇨🇦Canada RobLoach Earth

Thanks b_sharpe. Made a follow up that may improve the UX surrounding AI Prompts:
UX: AI Prompts: Improve UX around initial setup Active

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

Had a run through of this with a fresh Drupal CMS 2.x, and was unable to reproduce...
- Drupal 11.3.2
- AI 1.2.5

I have noticed a few issues in the Gin issue queue related to the form actions, which are probably not related...

Proposed Resolution

Close as "cannot reproduce".

🇨🇦Canada RobLoach Earth

Green.

🇨🇦Canada RobLoach Earth

Seems rather important to greenlight the 1.1.x release again. Merged in the latest from 1.1.x to ensure the pipes are clear.

🇨🇦Canada RobLoach Earth

robloach made their first commit to this issue’s fork.

🇨🇦Canada RobLoach Earth

Merge Request around the above documentation change: https://git.drupalcode.org/project/ai/-/merge_requests/1090

Will leave this unassigned for now until the prep team picks it up.

🇨🇦Canada RobLoach Earth

Sounds good, I could also take on the documentation updates we found from last release too:

  1. Update release docs that we always should create an issue for a release
  2. Document - Gitlab - create the tags via UI
  3. Changed title in documentation: Confirmed Fixes Issues -> QA Test
🇨🇦Canada RobLoach Earth

Should this meta issue also cover 1.1.9?

🇨🇦Canada RobLoach Earth

Capturing follow ups here in the mean time....

  • Create discuss issue: QA on patch releases, how to reproduce and how to test.
  • Update release docs that we always should create an issue for a release
  • Force gitlab to have #[number] on merging/squash
  • Document - Gitlab - create the tags via UI
  • Changed title in documentation: Confirmed Fixes Issues -> QA Test
  • Change the release script so we just do [#issues] --- DONE
🇨🇦Canada RobLoach Earth

Added some updates for AI Migrate Agent. Thanks Suchi.

🇨🇦Canada RobLoach Earth

A good workaround until it's fixed elsewhere.

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

I can do some testing on this over the next week to see if I can replicate it.

🇨🇦Canada RobLoach Earth

While there will likely be further changes, I've gone through the commits...

1.1.8

<h2>[1.1.8] - 2026-01-07</h2>
<p>Issues resolved since <a href="https://www.drupal.org/project/ai/releases/1.1.7" rel="nofollow">1.1.7</a>: 3</p>
<h3>Contributors (2)</h3>
<p><a href="https://www.drupal.org/u/marcus_johansson">Marcus_Johansson</a>, <a href="https://www.drupal.org/u/joevagyok">joevagyok</a></p>
<h3>Changelog</h3>
<p>Changes since <a href="https://www.drupal.org/project/ai/releases/1.1.7">1.1.7</a> (<a href="https://git.drupalcode.org/project/ai/-/compare/1.1.7...1.1.x">compare</a>):</p>
<h4>Bug</h4>
<ul>
  <li><a href="https://www.drupal.org/i/3532220">#3532220</a>: Change the messenger on Automators to interface</li>
  <li><a href="https://www.drupal.org/i/3563722">#3563722</a>: Fix wrong AiCKEditor namespace declarations.</li>
  <li><a href="https://www.drupal.org/i/3565610">#3565610</a>: Fix Composer previous minor"</li>
</ul>

1.2.5

<h2>[1.2.5] - 2026-01-07</h2>
<p>Issues resolved since <a href="https://www.drupal.org/project/ai/releases/1.2.4" rel="nofollow">1.2.4</a>: 10</p>
<h3>Contributors (9)</h3>
<p><a href="https://www.drupal.org/u/marcus_johansson">Marcus_Johansson</a>, <a href="https://www.drupal.org/u/a.dmitriiev">a.dmitriiev</a>, <a href="https://www.drupal.org/u/joevagyok">joevagyok</a>, <a href="https://www.drupal.org/u/loominade">loominade</a>, <a href="https://www.drupal.org/u/ritarshi_chakraborty">ritarshi_chakraborty</a>, <a href="https://www.drupal.org/u/svendecabooter">svendecabooter</a>, <a href="https://www.drupal.org/u/szloredan">szloredan</a>, <a href="https://www.drupal.org/u/udhayykumargmail.com">udhayykumargmail.com</a>, <a href="https://www.drupal.org/u/valthebald">valthebald</a></p>
<h3>Bugs</h3>
<ul>
  <li><a href="https://www.drupal.org/i/3560133">#3560133</a>: Get values using nestedarray on updateForm</li>
  <li>feat: <a href="https://www.drupal.org/i/3555648">#3555648</a> Issue using "Automator alt text" action with Field widget actions</li>
  <li>Issues/3540486: Translate CKEditor plugin ignores language_source = lang</li>
  <li><a href="https://www.drupal.org/i/3563674">#3563674</a>: Fix Field Widget Actions Schema is invalid</li>
  <li><a href="https://www.drupal.org/i/3553940">#3553940</a>: Add flex-wrap to AI Tools wrapper when not inside modal</li>
  <li><a href="https://www.drupal.org/i/3563722">#3563722</a>: Fix wrong AiCKEditor namespace declarations.</li>
  <li><a href="https://www.drupal.org/i/3555808">#3555808</a>: documentatio: Document the release</li>
  <li><a href="https://www.drupal.org/i/3564433">#3564433</a>: Fix inconsistent form prefix in STT explorer</li>
  <li><a href="https://www.drupal.org/i/3565610">#3565610</a>: Fix Composer previous minor</li>
  <li>Fix schema for AI CKEditor plugins</li>
</ul>
<h3>Feature</h3>
<ul>
  <li><a href="https://www.drupal.org/i/3562877">#3562877</a>: Added @RobLoach to release management</li>
</ul>
<h3>Misc</h3>
<ul>
  <li>Deprecate AI translate in the current stable version</li>
  <li>Removed index.md from ai_logging docs link.</li>
  <li>mark deepchat.bundle.js as minified</li>
  <li>Resolved unnecessary forms issue on Prompt Creation</li>
</ul>
🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

Looks good, thanks! Opened up a MR for it over at https://git.drupalcode.org/project/read_more_field/-/merge_requests/14 .

🇨🇦Canada RobLoach Earth

Considering this makes an effort in updating the library, may be good to prioritize it. Thanks for the push, I may be able to help out in testing this in the next couple weeks.

🇨🇦Canada RobLoach Earth

Detect the source plugin configuration. Update with the latest changes.

🇨🇦Canada RobLoach Earth

Got it represented in the mkdocs now. There's also a menu item for Breaking Changes too +1.

🇨🇦Canada RobLoach Earth

The Merge Request certainly is growing, and I've tried to consolidate some of the documentation where possible. Hopefully it isn't too complicated, though I like the step by step method we've put together here.

🇨🇦Canada RobLoach Earth

Thanks for the reviews, all. Working on updating it accordingly.

🇨🇦Canada RobLoach Earth

Made some updates around formatting, along with a section on handling Breaking Changes in this Merge Request. Preview.

There are some minor formatting and wording nits and typos that can be cleaned up (but not from my phone :)

Hope I've addressed most of these, though there will likely be some remaining.

there is too much duplication of documentation

With the latest changes, it does seems to be a bit clearer. I understand the need to split Minor/Major, Patch, and Security release documentation, but it does get verbose, which is likely a good thing.

I see that we are primarily following the industry Drupal standards (mostly based on https://semver.org/), but I believe everyone has their own interpretation of what constitutes a minor or major version change.

I agree that we should follow Drupal & semver as close as possible, and this documentation somewhat reflects that. I've made sure to link to it where it makes sense in the latest updates.

@a.dmitriiev - I think that should be on QA yes

Added a section for the QA Team, though it's an empty block right now. Do we have the list of QA peeps available?

Questions

  1. I've suggested the adoption of the Breaking Change (BC) tag to highlight breaking changes easier. If there's a Breaking Change component, it'll make it easier. Do you think just the tag is enough?
  2. The Release Notes Generator worked pretty well for me, though it did need some tweaking to match what we expect. Is this something that the Gitlab Releases could eventually handle for us?
  3. Speaking of Release Notes, since they seem pretty important, would it make sense for us to eventually have this captured them in a CHANGELOG.md or similar like keep a changelog.com? May make it easier to curate the notes prior to release.
🇨🇦Canada RobLoach Earth

Testing out this tag.

🇨🇦Canada RobLoach Earth

Going through a review of this, and happy to pick up Releases where needed. Will post my thoughts inline on the MR. Self-assigning for now.

🇨🇦Canada RobLoach Earth

It's up.

🇨🇦Canada RobLoach Earth

robloach created an issue. See original summary .

🇨🇦Canada RobLoach Earth

I think MR47 fixed this for me. Nice work. Was able to configure things without issue.

🇨🇦Canada RobLoach Earth

Yessir.

🇨🇦Canada RobLoach Earth

Thanks for the revert. If we do take something like this on, we should likely be specific about which `td` we're targeting. Is there a parent class that we could hit?

🇨🇦Canada RobLoach Earth

> Is MR44 another approach to solve the same problem?

It looks like that's some tests. Doesn't solve the problem.

🇨🇦Canada RobLoach Earth

Which version of Drupal?

🇨🇦Canada RobLoach Earth

This adds the type-hint, and checks if the input is NULL.

🇨🇦Canada RobLoach Earth

Thanks for the add. I'll be able to have a look over the next couple weeks.

🇨🇦Canada RobLoach Earth

I tested this out, and it seems to work. Thanks a lot.

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

Thanks so much for the add, and cleaning up the queue. Are there any issues you'd like prioritized?

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

robloach created an issue.

🇨🇦Canada RobLoach Earth

I'd say go for it. Thanks so much for the help.

🇨🇦Canada RobLoach Earth

Here's a new patch with a is_array() in there. Not the best "fix", but will avoid the warning.

🇨🇦Canada RobLoach Earth

The Summary provides an accurate screenshot of what you get with the Link field with a description. I'm experiencing the exact same thing with a basic Link field. The tables.css inlines the components. Reverting the change with the patch in #7 "fixes" it.

Production build 0.71.5 2024