disqus_migration_plugins_alter() should not assume that migrate_drupal is enabled

Created on 13 September 2023, 10 months ago

Problem/Motivation

List of migrations fails when disqus is enabled, but (core) migrate_drupal is not.

Steps to reproduce

Uninstall disqus (if it is enabled)
Enable migrate, migrate_tools and migrate_plus modules
Create a migration
Enable disqus
Go to admin/structure/migrations
List of migrations is empty

Why this happens:

in function disqus_migration_plugins_alter():

<?php

  $disqus_plugin = DisqusDeriver::getSourcePlugin('disqus_enabled_content_types');
  assert($disqus_plugin instanceof DrupalSqlBase);

?>

Full class name of DrupalSqlBase is Drupal\migrate_drupal\Plugin\migrate\source\DrupalSqlBase, so, if migrate_drupal is not installed, $discus_plugin won't be created, resulting in an empty list of migrations.

Proposed resolution

Check that migrate_drupal is enabled

Remaining tasks

Write the patch

🐛 Bug report

Status

Needs review

Version

2.0

Component

Code

Created by

🇧🇬Bulgaria valthebald Sofia

Live updates comments and jobs are added and updated live.

migrate

Comments & Activities

Issue created by @valthebald
Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7
last update 10 months ago
Not currently mergeable.
@valthebald opened merge request.
Comment 10 months ago →
System Message
valthebald → closed merge request !9
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7
last update 10 months ago
Composer require failure
@valthebald opened merge request.
Status changed to Needs review 10 months ago2:56pm 13 September 2023
Comment 10 months ago →
🇧🇬Bulgaria valthebald Sofia

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024