Sofia
Account created on 11 February 2008, about 17 years ago
#

Merge Requests

More

Recent comments

🇧🇬Bulgaria valthebald Sofia

Bumping the target version

🇧🇬Bulgaria valthebald Sofia

Bumping the version + MR is not mergable at the moment

🇧🇬Bulgaria valthebald Sofia

@vivek panicker: I tested with core 10.4 and ai 1.0.x, and it worked for me. Can you provide more details about your configuration? Are variation fields marked as translatable with AI? Another place to check is AI translate settings /admin/config/ai/ai-translate, especially entity reference section

🇧🇬Bulgaria valthebald Sofia

@marcus_johansson can this be merged to 1.1.x as well please?

🇧🇬Bulgaria valthebald Sofia

@vivek panicker: I have asked ChatGPT and Gemini to analyze and find possible grammatical mistakes in the source code of ai_agents, and here are some other places to fix/improve:

  1. AiAgentExplorerController.php line 84: "Check if its a json response." Should be "Check if it's a JSON response." (capitalize JSON and add an apostrophe
  2. line 137: "The actual task, will support files later." should be "The actual task will support files later." (unnecessary comma)
  3. Drupal\ai_agents\Attribute\AiAgent.php line 11 "The ai provider attribute" AI should be capitalized.
  4. Drupal\ai_agents\Form\AiAgentPromptChanger.php line 13 "Configure on AI Agent." sounds confusing and misleading

I wonder if those should be handled in the same or separate issue?

🇧🇬Bulgaria valthebald Sofia

@mrdalesmith: simple and effective! Nice catch, marking RTBC

🇧🇬Bulgaria valthebald Sofia

Bumping the version + suggest more generic approach

🇧🇬Bulgaria valthebald Sofia

Changed the documentation of translate text call

🇧🇬Bulgaria valthebald Sofia

@mrdalesmith: The issue this patch tries to solve: out of the box, with AI module alone or AI recipe in Drupal CMS), users have "Translate text" operation type on the settings screen, and the list of providers that implement this operation type, is empty.

Which is confusing, and the most frequent question I get from the new users trying to use AI translation capabilities, is why they cannot use OpenAI or Claude for translation.

By "any other you might be using", I am aware only about deepl implementing "Translate text" operation, and this is not mentioned on the AI settings screen.

🇧🇬Bulgaria valthebald Sofia

Closing since meetup was cancelled

🇧🇬Bulgaria valthebald Sofia

@scott_euser: I tried to address all you remarks in gitlab:

1. Clearer hook_requirements()
2. Handle case for null source language
3. Model selection on the AI settings screen
3. hook_update() that sets default translate provider when it's empty

Can you check if you still get escaped HTML?

🇧🇬Bulgaria valthebald Sofia

valthebald made their first commit to this issue’s fork.

🇧🇬Bulgaria valthebald Sofia

@dunx, those are exactly the steps to confirm the patch is working, thank you!
I dare move it back to RTBC (I know, formally I shouldn't do it as a patch author, but there was no change in the code, only clarification of the review process)

🇧🇬Bulgaria valthebald Sofia

@dunx: You get published translation with applied patch too?

🇧🇬Bulgaria valthebald Sofia

With symfony mailer, you can use Sendgrid as sending transport as described here https://www.drupal.org/project/sendgrid_integration/issues/3256519 Compatibility with Symfony Mailer Closed: works as designed .

That way you just use default contact form

🇧🇬Bulgaria valthebald Sofia

When translated entity implements EntityPublishedInterface, keep the published status from original entity.

🇧🇬Bulgaria valthebald Sofia

valthebald made their first commit to this issue’s fork.

🇧🇬Bulgaria valthebald Sofia

Fixed links to issues

🇧🇬Bulgaria valthebald Sofia

@mrdalesmith: this issue is not about consent management in general (this should be handled elsewhere, and Drupal CMS is going to use Klaro manager for that), but about getting user consent when data is sent for external data processing by the provider.

For locally hosted providers like llama, this is not an issue, but when a user communicates with (as an example) a chatbot, they need to be aware their input may be sent outside of the website.

🇧🇬Bulgaria valthebald Sofia

I faced the same issue and was going to suggest a similar fix :)
Patches fixes the issue, yet I have a small suggestion (wrote in gitlab)

🇧🇬Bulgaria valthebald Sofia

I have created https://www.drupal.org/project/solrlog as a separate project, to allow installations without patching search_api_solr

🇧🇬Bulgaria valthebald Sofia

Add reference to valthebald/ddev-matomo ddev plugin

🇧🇬Bulgaria valthebald Sofia

@jan kellermann I'm equally amazed by your knowledge of the EU laws as I am disappointed by implied restrictions to deliver meaningful functionality to our clients...

🇧🇬Bulgaria valthebald Sofia

As far as stickyHeaderState is entirely client-processed and is not collected/processed by the server (who should it be?), I'd argue it's not a subject to GDPR or similar regulations.
GDPR, as it states in the very first article, is about

...rules relating to the protection of natural persons with regard to the processing of personal data and rules relating to the free movement of personal data.

since there is no processing of personal data, I'd say there is no need to get user consent

🇧🇬Bulgaria valthebald Sofia

Fixed most of the comments (2 left are for the future).
Also, brought back editing of default translation prompt (patch to have per-language left it hidden) and display of default prompt that has a condition

🇧🇬Bulgaria valthebald Sofia

@mkalkbrenner did you have a chance to check this?

🇧🇬Bulgaria valthebald Sofia

Tested and works for text fields attached to entity being translated and referenced entities

🇧🇬Bulgaria valthebald Sofia

valthebald made their first commit to this issue’s fork.

🇧🇬Bulgaria valthebald Sofia

Solr-based logger mimicking dblog UI - https://www.drupal.org/project/search_api_solr/issues/3475570 Provide Search API-based alternative to dblog Active

🇧🇬Bulgaria valthebald Sofia

valthebald changed the visibility of the branch 3475570-solronly to hidden.

🇧🇬Bulgaria valthebald Sofia

valthebald changed the visibility of the branch 3475570-logger to hidden.

🇧🇬Bulgaria valthebald Sofia

@mkalkbrenner sure, I will create a MR later today

🇧🇬Bulgaria valthebald Sofia

@mkalkbrenner: PoC of lighter, Solr-only logger implementation https://git.drupalcode.org/sandbox/valthebald-3476169
TL;DR; where possible, I followed dblog patterns, replacing database specifics with solarium queries

Production build 0.71.5 2024