- Issue created by @Aporie
- @aporie opened merge request.
- 🇭🇷Croatia Aporie
I had a bit of time, so I tried to deliver the full MR.
I hope I haven't forgotten any call to translated prompt configs. I'm not very familiar with the suite of modules yet, so I simply searched any call for
ai_translate.settings
.The test generates warning, but fixing them would be out of scope. Plus, it's mostly applying few changes in plugins regarding the returned types. No emergency before D12.
Overall, I think it's ready for testing / review.
- 🇧🇬Bulgaria valthebald Sofia
@Aporie nice touch!
Can you please review the messages in https://git.drupalcode.org/issue/ai-3536092/-/jobs/5926826, and also ensure that the code applies to 1.2.x? Since this is schema changing, we probably need an update hook to change existing configurations, especially is this will be backported to 1.1.x - @aporie opened merge request.
- 🇭🇷Croatia Aporie
Hi @valthebald,
I've rebased on 1.2.x and fixed the pipeline.
For the hook update, it was in the branch already. I've tested it, and it should move config saved in previous schema in the new one and delete stale config objects. Though, worth second testing / review of course.
If we need to backport this to 1.1.x, we might need to re-create another branch.
Or maybe I should have done that before merging 1.2.x in it :( ...
- 🇧🇬Bulgaria valthebald Sofia
Added some comments on PR (first one is a deal breaker)
-
valthebald →
committed b904e879 on 1.2.x authored by
aporie →
Resolve #3536092 "Schema errors for"
-
valthebald →
committed b904e879 on 1.2.x authored by
aporie →
Automatically closed - issue fixed for 2 weeks with no activity.