- Issue created by @mingsong
- Merge request !7924Issue #3445375: Supported attribute(s) not showing in CKEditor 5 Source... → (Open) created by mingsong
- 🇦🇺Australia mingsong 🇦🇺
The test to reproduce this issue.
https://git.drupalcode.org/project/drupal/-/merge_requests/7924.patch
- 🇦🇺Australia mingsong 🇦🇺
It seems that something related to
<$text-container
at line 455 in ckeditor5.ckeditor5.yml file.https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/ckedi...
The $text-container variable seems wan't replaced with the actual tag name, which is '
' tag in this case.
- 🇦🇺Australia mingsong 🇦🇺
Another example is
<h2 class="text-align-center">
which trigger another error message:
The following attribute(s) are already supported by available plugins and should not be added to the Source Editing "Manually editable HTML tags" field. Instead, enable the following plugins to support these attributes: .
In which, the plugin name is missing from the message.
- 🇦🇺Australia mingsong 🇦🇺
I believe this bug is caused by Drupal\ckeditor5\HTMLRestrictions::applyOperation() function.
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/ckedi...
As the function description suggested, it is supposed to support wildcard within an element name. Therefore, the wildcard $text-container should be resolved into a concrete tag, such as a P tag. But actually result is opposite.
- Status changed to Needs review
12 months ago 3:40pm 9 May 2024 - 🇩🇪Germany lmoeni
I ran into this problem recently in 10.1/10.2 while editing my text editor. I tested the 10.2 patch with 10.2.6 and it works perfectly.
Thanks! - Status changed to Needs work
11 months ago 3:19pm 16 May 2024 - 🇺🇸United States smustgrave
Can the issue summary be completed please.
Proposed solution needs to be filled in
if a UI issue before/after screenshots should be included
Thanks!
- Status changed to Needs review
11 months ago 1:03am 17 May 2024 - 🇦🇺Australia mingsong 🇦🇺
Thanks @Stephen.
The summary has been updated as required.
- 🇺🇸United States smustgrave
smustgrave → changed the visibility of the branch 11.x to hidden.
- Status changed to Needs work
11 months ago 5:19pm 19 May 2024 - 🇺🇸United States smustgrave
Thanks for updating issue summary, updates look good.
Left some comments on the MR but a lot of the comment updates, period additions, etc seem to be out of scope of this issue. Code sniffer wasn't failing before without these changes
Test coverage is great.
- Status changed to Needs review
11 months ago 4:03am 20 May 2024 - 🇦🇺Australia mingsong 🇦🇺
Thanks @Stehpen for the review.
I correct those out of scope comments.
Regarding other changes, I believe they are necessary as they are part of the fix for this bug.
It is ready for review again.
- Status changed to Needs work
10 months ago 2:26pm 11 July 2024 - 🇺🇸United States smustgrave
Only posted a few threads but believe there are still a dozen or so out of scope changes adding comments, punctuation, etc. Would say that could be a follow up issues (maybe novice maybe not).
- 🇦🇺Australia mingsong 🇦🇺
Without those changes, those PHPUnit tests would fail.
- 🇳🇿New Zealand quietone
Fixes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
Hi, I am experiencing this issue. It would be great if it could be made release ready.
Until I applied this as a patch it was impossible for me to complete some of my work, because without the information missing from the error message I couldn't progress