🇩🇪Germany @lmoeni

I can also confirm that patch #4 and the MR solves the problem with Drupal 10.4.1 and Admin Toolbar 3.5.1.

I ran into some issues in my projects because we don't have the basic_html text format and workbench was already installed.
I added a new merge request with a new update hook.
Only the relevant parts of the view config should get changed.
Can you reopen this issue?

lmoeni → made their first commit to this issue’s fork.

1.6 works with 10.2 and 10.3 I just tested it with a plain drupal project.
But I created a new merge request for this issue. The config was only changed for new installations but existing projects still have this problem.
I wrote an update hook which only changes the values that were changed in the previous merge request.

When I want to edit the roles field of the view I get the message The submitted value entity_reference_label in the Display type element is not allowed. . That is why I also changed they display type value in the update hook and the initial configuration.

lmoeni → made their first commit to this issue’s fork.

Super, dankeschön! Ich hoffe das die Änderung auch im Modul übernommen wird.
Das mit dem Haltepunkt hatte ich auch übersehen, da macht Breakpoint wirklich mehr Sinn.

joachim namyslo → credited lmoeni → .

Ich bekomme bei einer Installation durch das Modul Image Widget Crop auch die Fehlermeldung:

 [error]  Import of string "Dieses Feld ist so konfiguriert, dass je nach Haltepunkt des <b>Bartik</b>-Themas in der Standardanzeige unterschiedliche Bilder (mit unterschiedlichen Zuschneidezonen/Seitenverhältnissen) angezeigt werden.<br/>
<b>Haltepunkte für Bildstile:</b>
<ul>
<li>Breit (min. Breite: 851 px) => Klein (320 x 180) mit Zuschneiden 16:9</li>
<li>Schmal (min-width: 851px bis max-width: 850px) => Mittel mit einfachem Zuschnitt</li>
<li>Mobil => Mittel - (300 x 330) mit Zuschnitt 4:3</li>
<li>Fallback => Klein - (320 x 180) mit Zuschnitt 16:9</li>
</ul><br/>

Um mit verschiedenen Reaktionen zu experimentieren, ändern Sie den <a href=„/admin/config/media/responsive-image-style/crop_example_responsive“ target=„_blank“>Crop Example Responsive Image Style</a><br/>" was skipped because of disallowed or malformed HTML. 

Dies ist die betroffene Übersetzung: https://localize.drupal.org/translate/languages/de/translate?sid=2916938
Der Fehler wird wahrscheinlich durch die
verursacht. Ich hatte das bei der Übersetzung korrigiert, mir war erst danach aufgefallen, dass es in dem zu übersetzenden String vom Modul selbst schon falsch drin ist.
Mir war auch noch aufgefallen, dass sich in der Übersetzung die falschen Anführungszeichen eingeschlichen haben.

Die Übersetzung wird nur von einem Untermodul verwendet in einer Beispiel Konfiguration. Vielleicht könnten wir die Übersetzung vorerst entfernen?
Ich hab ein Issue in dem Modul direkt aufgemacht.

lmoeni → changed the visibility of the branch 3499308-translation-strings-skipped to hidden.

lmoeni → created an issue.

I just commited some changes. I think this will fix "4. "Newsletters" extra field on user entity => exception as below.". The error does not appear anymore if the user create form has the newsletter field.
How can I recreate "1. Page that has newsletter attached"?

I implemented the changes. I hope this is better now. Can you take a look again?

I combined patches #30 and #41 in a new MR.
I used patch #41 but still got the error while creating a user. The check for the email in simplenews_user_insert() was missing.

lmoeni → made their first commit to this issue’s fork.

When I click the user icon, the page just reloads, and I stay on the home page.

I came across this issue while using multiple plugin types. I can confirm that this only occurs for the plugin types that are not the default plugin type.
The user does not get redirected to the overview but instead also has a "Skip and finish" button. When the user clicks on that button, the status message: "Setup of TFA Email one-time password (EOTP) canceled." appears, which suggests that the setup did not happen but it did.

I removed most of the tfaNextSetupStep() function in a patch, which solved this problem for me. I could not find any further issues without the removed code.

Hi, thanks for this module :)
Do you already have a approximate date in mind to release 1.0.0?

I implemented the changes for the TOTP and HOTP setup.

lmoeni → created an issue.

Thanks for taking a look at it and for your suggestion. I changed it a little bit so now it should be ready for testing.

I created a merge request with my proposed resolution.

lmoeni → created an issue.

Danke für den Hinweis mit der Richtlinie, die hatte ich irgendwie übersehen.
Ich schaue mir das alles mal in Ruhe an.

lmoeni → created an issue.

I rerolled the patch for Drupal 10.3.5.

I noticed this in my projects too. The patch fixes the issue for me.

I think I worded it incorrectly. The isEmpty() method was used to check whether the display_id was empty before the validation took place.
Which class do you mean? I couldn't find a validate() method in the class that ViewsReferenceItem extends.

lmoeni → created an issue.

I created a new issue for it. I use Claro as my backend theme but I think they changed the icon in 10.3. It looks different in 10.2.

lmoeni → created an issue.

The merged changes from this issue result in the drag and drop button being misaligned when it is collapsed or while editing. It's not aligned with the text anymore.

Tested with Drupal 10.3.1/10.3.2 and Paragraph 1.18.

I ran into this issue when I created an newsletter (Simplenews) which threw the warnings that the jquery_ui modules are missing:

 User warning: The following theme is missing from the file system: jquery_ui in Drupal\Core\Extension\ExtensionPathResolver->getPathname() (line 63 of core/lib/Drupal/Core/Extension/ExtensionPathResolver.php).
    Deprecated function: dirname(): Passing null to parameter #1 ($path) of type string is deprecated in Drupal\Core\Extension\ExtensionPathResolver->getPath() (line 85 of core/lib/Drupal/Core/Extension/ExtensionPathResolver.php).

Sadly, update hooks do not work in themes as themes do not have the install file like modules do. That's why the update is not detected.
Defining the dependencies in the info.yml breaks the installation process for me:
Unable to install theme: 'theme_name' due to unmet module dependencies: 'jquery_ui, jquery_ui_draggable, jquery_ui_resizable'.
Tested with Drupal 10.2.3 and 10.3.1 + Bootstrap 3.31. I would not recommend using the patch. Instead I would install the modules in your own profile/module till there is a working solution for this issue.

#17 works great for me. Thank you!

lmoeni → created an issue.

I recently ran into this issue while installing the domain_menu_access module.
This does not happen when the menu_item_extras module is not installed.

I'm using the following versions:
Drupal: 10.2.7
Menu Item Extras: 3.0.2
Domain Menu Access: 2.0.0

The update hook fixed the problem for us. Thanks!

I tested the patch from #9 which works fine. Thanks!
I agree with @kaszarobert that this should be published soon.

I tested the MR today and it works fine when I use the Images button (except the things discussed in the comments starting from #87).
I cannot get it working with the media library though. Is there anything that I need to keep in mind while testing it with the media library?

I ran into this problem recently in 10.1/10.2 while editing my text editor. I tested the 10.2 patch with 10.2.6 and it works perfectly.
Thanks!

I just checked it with 10.2.7-dev and I'm still getting the error. I'll expand and refine the steps.
Not sure if it's relevant but I used the Claro backend theme.

lmoeni → created an issue.

#11 worked for me with 3.0.0-alpha2 and Drupal 10.2.5.
I'm not seeing the error that #16 mentions.

I fixed the failing test and adjusted the link formatter test with an longer url and empty 'trim_length' value.
Can someone take a look at this?

lmoeni → made their first commit to this issue’s fork.

Tested #15 with the Claro theme on Drupal 10.1 and 10.2.
It looks good and does only apply the margin to single-item buttons.

Schon mal danke für das Überprüfen der eingereichten Übersetzungen. :)
Das mit den Div-Tags ist natürlich echt unschön.

I tested patch #17 on Drupal 10.1.2 and can confirm that it works.
Thanks for the patch!

I'm having the same issue that you described but for me it's when I reference a paragraph.
I'm using the Paragraphs module and changed the entity reference form display to "Inline entity form - Complex".

When I edit the entity reference field I get a AJAX error and this is what appears in the log:

TypeError: menu_ui_node_builder(): Argument #2 ($entity) must be of type Drupal\\node\\NodeInterface, 
Drupal\\paragraphs\\Entity\\Paragraph given in menu_ui_node_builder() (line 311 of core/modules/menu_ui/menu_ui.module).
 call_user_func_array('menu_ui_node_builder', Array) (Line: 307)\nDrupal\\Core\\Entity\\EntityForm->buildEntity(Array, Object) (Line: 155)\nDrupal\\Core\\Entity\\ContentEntityForm->buildEntity(Array, Object) (Line: 186)\nDrupal\\Core\\Entity\\ContentEntityForm->validateForm(Array, Object)\ncall_user_func_array(Array, Array) (Line: 82)\nDrupal\\Core\\Form\\FormValidator->executeValidateHandlers(Array, Object) (Line: 275)\nDrupal\\Core\\Form\\FormValidator->doValidateForm(Array, Object, 'node_normal_page_edit_form') (Line: 118)\nDrupal\\Core\\Form\\FormValidator->validateForm('node_normal_page_edit_form', Array, Object) (Line: 593)\nDrupal\\Core\\Form\\FormBuilder->processForm('node_normal_page_edit_form', Array, Object) (Line: 325)\nDrupal\\Core\\Form\\FormBuilder->buildForm(Object, Object) (Line: 73)\nDrupal\\Core\\Controller\\FormController->getContentResult(Object, Object)\ncall_user_func_array(Array, Array) (Line: 123)\nDrupal\\Core\\EventSubscriber\\EarlyRenderingControllerWrapperSubscriber->Drupal\\Core\\EventSubscriber\\{closure}() (Line: 583)\nDrupal\\Core\\Render\\Renderer->executeInRenderContext(Object, Object) (Line: 124)\nDrupal\\Core\\EventSubscriber\\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)\nDrupal\\Core\\EventSubscriber\\EarlyRenderingControllerWrapperSubscriber->Drupal\\Core\\EventSubscriber\\{closure}() (Line: 166)\nSymfony\\Component\\HttpKernel\\HttpKernel->handleRaw(Object, 1) (Line: 74)\nSymfony\\Component\\HttpKernel\\HttpKernel->handle(Object, 1, 1) (Line: 58)\nDrupal\\Core\\StackMiddleware\\Session->handle(Object, 1, 1) (Line: 48)\nDrupal\\Core\\StackMiddleware\\KernelPreHandle->handle(Object, 1, 1) (Line: 106)\nDrupal\\page_cache\\StackMiddleware\\PageCache->pass(Object, 1, 1) (Line: 85)\nDrupal\\page_cache\\StackMiddleware\\PageCache->handle(Object, 1, 1) (Line: 48)\nDrupal\\Core\\StackMiddleware\\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)\nDrupal\\Core\\StackMiddleware\\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)\nDrupal\\Core\\StackMiddleware\\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)\nDrupal\\Core\\DrupalKernel->handle(Object) (Line: 19)\n", name: "AjaxError", stack: "@https://nrwgov.ddev.site/core/misc/ajax.js?v=10.1.2:196:32\n@https://nrwgov.ddev.site/core/misc/ajax.js?v=10.1.2:1889:3\n" }
ajax.js:196:32

This is not occuring when I create the entity reference.

I can also confirm that this did not occur in 2.0.0-rc6 and seems to be releated to the changes in: https://www.drupal.org/project/inline_entity_form/issues/3375555 ✨ Add a FieldFormatter to display rendered menu Postponed

The merge request looks good. Just needs to be rebased.

lmoeni → created an issue.

lmoeni → created an issue.

Is there a reason why 10.0.0 is supposed to stay on Symfony 6.2?
The current requirement in 10.0.x also allows 6.3 to install.
Shouldn't we backport or lock the version to 6.2 then?

lmoeni → created an issue.

In the meantime this patch solves the issue.

I added a patch for Drupal 10.

The patch did not work for me, I had to add a div to make it a little bit more specific.
I added a patch in case someone has the same issue.

• Drupal 9.5.3
• PHP 8.1
• Seven theme
• Paragraphs 1.15

I checked and the linkit filter runs before the spamspan filter.

lmoeni → created an issue.

Do you plan on making a release for this issue?