- Issue created by @edyuenyw
- Status changed to Needs work
almost 2 years ago 11:54pm 27 March 2023 18:57 15:48 Running- Status changed to Needs review
almost 2 years ago 1:17am 24 May 2023 - Status changed to RTBC
over 1 year ago 12:26pm 24 July 2023 - 🇮🇳India Moni_10
Hi @edyuenyw, the patch applied successfully and it's working fine for me. Here's the before and after screenshot.
RTBC ++ - 🇺🇸United States caesius
+1 RTBC, applied patch and it's working as described
- Status changed to Needs work
over 1 year ago 9:22pm 30 August 2023 - 🇨🇭Switzerland berdir Switzerland
this is not the result I'm seeing, I can reproduce the problem, but the patch results in also adding margin-top and the text is then aligned on top of the button, not the center. I'm also missing spacing between the to and the paragraph field name. What theme is that?
- 🇮🇳India anweshasinha
Hi,
I have made necessary changes by adding apace beside the dropdown and created a patch in drupal 9.5.x. I have attached the patch and the interdiff file. Please review the patch and let me know. - Status changed to Needs review
over 1 year ago 8:20am 6 September 2023 - last update
over 1 year ago 180 pass - Status changed to RTBC
over 1 year ago 7:32pm 28 September 2023 - 🇺🇸United States caesius
Attached are videos showing the issue on fresh installs of both Drupal 9.5 and 10.1 and then testing both patches in this issue. I could not see a difference between the patches on either version of Drupal and I certainly didn't see the problem @Berdir mentioned.
As far as I'm concerned either patch works perfectly fine, but I'm really confused by Berdir's comment re: spacing problems. Someone even minimally familiar with this project's CSS should make the decision on which patch to apply, but FWIW I've been using the first patch on a project for a few months now and have not noticed any issues.
I'll mark this RTBC and a maintainer can make a final decision.
- 🇺🇸United States caesius
Correction:
It does seem that the 2nd patch addresses this issue better than the 1st one, since it appears the 1st patch also inadvertently affects single-paragraph-type buttons without the dropdown.
1st patch:
2nd patch:
You'll see the 1st patch adds undesired extra margin to the right of the button.
- 🇺🇸United States caesius
For the record, these patches seem to cause minimal changes/disruption in Seven, per the attached screenshots. The only downside to Patch #9 is that it adds more margin to multiple-item dropbuttons than it does to single-item dropbuttons, but this should be an okay trade-off when considering the theme is deprecated.
That said, other admin themes may end up seeing the same thing, so perhaps this is a Claro core issue where the right-hand spacing for multi-item dropbuttons is nonexistent compared to single-item buttons.
- Status changed to Needs review
over 1 year ago 8:14pm 2 October 2023 - last update
over 1 year ago 180 pass - 🇺🇸United States caesius
The actual issue appears to be that in Claro, the widget is given the
form-actions
class which makes the entire thing a flex container. This causes every DOM node in the widget -- the button, the word "to," and the<em>
phasized text -- to be considered an independent flex item with no gap between them. I triedcolumn-gap
but this put much more spacing after the word "to" than before it (i.e. after the button) even after removing the margin for.placeholder
I think we should ensure
block
display ofform-actions
for the paragraphs widget to avoid the issue and ensure consistent spacing between themes. This also means we can get rid of some of the other Claro-specific CSS rules. Screenshots of Claro and Seven with this patch applied. - 🇮🇳India swatidhurandhar
Tested patch from #15 in D9.5. It applies cleanly and fixes the margin issue in themes like claro and olivero. In seven theme issue wasn't there, so patch doesn't affect it much.
This ticket can be moved to RTBC + 1. - Status changed to RTBC
about 1 year ago 11:40am 15 January 2024 - 🇩🇪Germany lmoeni
Tested #15 with the Claro theme on Drupal 10.1 and 10.2.
It looks good and does only apply the margin to single-item buttons. - Status changed to Postponed: needs info
7 months ago 11:59am 6 August 2024 - 🇨🇭Switzerland berdir Switzerland
I think this was at least a partial duplicate of 📌 Some styling no longer applies due to form-actions -> field-actions html change Fixed , this issue was older, but I went through the other one first. Please test if anything still needs to be fixed.
- Status changed to Closed: outdated
7 months ago 6:06pm 6 August 2024 - 🇺🇸United States caesius
I tested this on Paragraphs dev and it looks fixed. Thanks!