๐Ÿ‡ฎ๐Ÿ‡ณIndia @Moni_10

Account created on 29 May 2020, over 4 years ago
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi @pjcdawkins, The patch applied successfully. And it's working fine.
RTBC ++

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi @ckrina, I've tried to replicate this issue on my local but for me it's working fine. Can you please mention which theme and which drupal version are you using?
Attaching screen recording for the same. Here I used Drupal version - 9.5.x

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi @tonytheferg, Created a patch to fix this issue. Attaching recording for reference as before and after applying this patch.
Please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi @zartab farooquee. I've tried to reproduce this issue but all the icons are visible for me. Can you please specify the scenario where it's happening or mention which icons is missing from the editor?
Thanks

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi, @Mark Shi. I tried to reproduce this issue as per your mentioned steps above. But, I'm unable to see this issue from my side. Attaching an screenshot for reference.
Can you please mention specific steps or specific breakpoint where this issue arises? So, I can able to reproduce it well. Thanks

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi, created a patch to fix that issue. Attaching screenshot as well. Please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Sure thanks @bnjmnm. Created new patch to fix the visibility of pipe and slash icon with attached screenshot. Please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi @bnjmnm, Here's the patch to fix this issue. Also, I have attached screenshot after fix. Please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hey @bnjmnm. I accidentally clicked on create an MR, unable close it as there's no option available for me to close an MR. Please ignore it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

@bnjmnm This style was for back_to_site icon, but as you say we can ignore that as I'm creating new issue for this. Also, I'd Added @saschaeggi, because I already confirmed same with him before mentioning these above icon related issues.
So, we following as per the issue summary, then we're good to move into RTBC.
Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi @bnjmnm Thanks for letting me know. Also, Changes that you can see in the file comes after formatting the document. If you actually compare the file code with the older one there's only formatting related issue(spacing) being fixed. So, That's the reason you can see this conflict between both file. There's only backtosite style been added from my end.

Hi, @saschaeggi, As per @bnjmnm comment above, Can we create a separate issue for this icon?

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi @edyuenyw, the patch applied successfully and it's working fine for me. Here's the before and after screenshot.
RTBC ++

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi, I've created a patch to fix that issue. Attaching after_modal.png screenshot as well.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

hi @bnjmnm As we are only covering the toolbar icon in this issue. we somehow missed "back to site" icon in gin's secondary toolbar. So, I have created a patch included your MR changes as well to fix that, As I'm struggling with creating an MR as don't have the access rights to push the code. Attaching an image after applying your MR and image after applying my patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi, I was working on forced colors/High contrast mode on Gin theme and found few issues related to missing icon on overall site. So, currently working on these fixes. Here's few screenshots as example.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi @bnjmnm Thanks for sharing the detail. I've tested that MR !269 and it's looking good. So, Moving it to RTBC. Attaching the before and after screenshot after applying the MR.

Testing Steps to Emulate forced color mode in a browser :

  1. Go to Dev tool.
  2. Press CMD+Shift+P (for mac) and CTRL+Shift+P (for windows).
  3. Type "Rendering" in Run command.
  4. Change dropdown "Emulate CSS media feature forced-colors" dropdown from "No emulation" to "Forced-colors: active".
๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi, @bnjmnm As, I was reviewing this issue, this issue is not reproducible on my local environment. Can you please provide Steps to reproduce this issue?

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi @Atropoides Can you please share your custom code base for the field widget? So that I can try and replicate this on my local.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hello @joshuasosa. Created a patch to fixed the overflow issue for the chosen single select dropdown in view's modal and also fix the height of that field. Attaching the before and after screenshot.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi @manojbisht_drupal I applied this patch and it's working fine. So, Moving it to RTBC. Attaching before and after screenshots for the same.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hii I've tested the above MR. Seems working fine for me. So, Moving this to RTBC
Here's before and after screenshot.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi @DieterHolvoet Above MR is working fine for me. Moving this to RTBC
Attaching before and after screenshot.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hey @DieterHolvoet While reviewing your MR, I saw some padding differences between single and multi select dropdown list, and also no result found was not themed as well, So Iโ€™ve created a patch to fix that.
Hereโ€™s some before and after images.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

@keelanfh The MR! 260 is working fine. Moving it to RTBC. Attaching working screen recording as well.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hey @paucala this MR! 56 doesn't belong to this issue summary. we can create new issue for this.
@shyam_bhatt The patch is working fine. Moving to RTBC

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi, the given information is not enough to reproduce this issue. I've tested it with different user roles and it seems working fine. Please provide the steps to reproduce this issue with screenshots. So, that it can be replicate easily.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

Hi,
Tested the MR MR! 4 with version 8.9.21 on my local, but it's working fine and resolved the issue.

Testing Steps:
1. Install the Drupal 8.9.21 version.
2. Install and set Robotic theme - version 8.1.1.
3. Enable the robotic theme and Place the search form block in Primary region
4. Clear the cache and reload the page.

Testing result: passed

Production build 0.71.5 2024