Hi @pjcdawkins, The patch applied successfully. And it's working fine.
RTBC ++
Hi @ckrina, I've tried to replicate this issue on my local but for me it's working fine. Can you please mention which theme and which drupal version are you using?
Attaching screen recording for the same. Here I used Drupal version - 9.5.x
Hi @tonytheferg, Created a patch to fix this issue. Attaching recording for reference as before and after applying this patch.
Please review.
Hi @zartab farooquee. I've tried to reproduce this issue but all the icons are visible for me. Can you please specify the scenario where it's happening or mention which icons is missing from the editor?
Thanks
Hi, @Mark Shi. I tried to reproduce this issue as per your mentioned steps above. But, I'm unable to see this issue from my side. Attaching an screenshot for reference.
Can you please mention specific steps or specific breakpoint where this issue arises? So, I can able to reproduce it well. Thanks
Hi, created a patch to fix that issue. Attaching screenshot as well. Please review.
Moni_10 โ created an issue.
Sure thanks @bnjmnm. Created new patch to fix the visibility of pipe and slash icon with attached screenshot. Please review.
Hi @bnjmnm, Here's the patch to fix this issue. Also, I have attached screenshot after fix. Please review
Hey @bnjmnm. I accidentally clicked on create an MR, unable close it as there's no option available for me to close an MR. Please ignore it.
Thanks @bnjmnm. Working on this.
@bnjmnm This style was for back_to_site icon, but as you say we can ignore that as I'm creating new issue for this. Also, I'd Added @saschaeggi, because I already confirmed same with him before mentioning these above icon related issues.
So, we following as per the issue summary, then we're good to move into RTBC.
Thanks.
Hi @bnjmnm Thanks for letting me know. Also, Changes that you can see in the file comes after formatting the document. If you actually compare the file code with the older one there's only formatting related issue(spacing) being fixed. So, That's the reason you can see this conflict between both file. There's only backtosite style been added from my end.
Hi, @saschaeggi, As per @bnjmnm comment above, Can we create a separate issue for this icon?
Hi @edyuenyw, the patch applied successfully and it's working fine for me. Here's the before and after screenshot.
RTBC ++
Hi, I've created a patch to fix that issue. Attaching after_modal.png screenshot as well.
Moni_10 โ created an issue.
hi @bnjmnm As we are only covering the toolbar icon in this issue. we somehow missed "back to site" icon in gin's secondary toolbar. So, I have created a patch included your MR changes as well to fix that, As I'm struggling with creating an MR as don't have the access rights to push the code. Attaching an image after applying your MR and image after applying my patch.
Hi, I was working on forced colors/High contrast mode on Gin theme and found few issues related to missing icon on overall site. So, currently working on these fixes. Here's few screenshots as example.
Hi @bnjmnm Thanks for sharing the detail. I've tested that MR !269 and it's looking good. So, Moving it to RTBC. Attaching the before and after screenshot after applying the MR.
Testing Steps to Emulate forced color mode in a browser :
- Go to Dev tool.
- Press CMD+Shift+P (for mac) and CTRL+Shift+P (for windows).
- Type "Rendering" in Run command.
- Change dropdown "Emulate CSS media feature forced-colors" dropdown from "No emulation" to "Forced-colors: active".
Hi, @bnjmnm As, I was reviewing this issue, this issue is not reproducible on my local environment. Can you please provide Steps to reproduce this issue?
Hi @Atropoides Can you please share your custom code base for the field widget? So that I can try and replicate this on my local.
Hello @joshuasosa. Created a patch to fixed the overflow issue for the chosen single select dropdown in view's modal and also fix the height of that field. Attaching the before and after screenshot.
Moni_10 โ created an issue.
Hi @manojbisht_drupal I applied this patch and it's working fine. So, Moving it to RTBC. Attaching before and after screenshots for the same.
Hii I've tested the above MR. Seems working fine for me. So, Moving this to RTBC
Here's before and after screenshot.
Hi @DieterHolvoet Above MR is working fine for me. Moving this to RTBC
Attaching before and after screenshot.
Hey @DieterHolvoet While reviewing your MR, I saw some padding differences between single and multi select dropdown list, and also no result found was not themed as well, So Iโve created a patch to fix that.
Hereโs some before and after images.
@keelanfh The MR! 260 is working fine. Moving it to RTBC. Attaching working screen recording as well.
Hey @paucala this MR! 56 doesn't belong to this issue summary. we can create new issue for this.
@shyam_bhatt The patch is working fine. Moving to RTBC
Hi, the given information is not enough to reproduce this issue. I've tested it with different user roles and it seems working fine. Please provide the steps to reproduce this issue with screenshots. So, that it can be replicate easily.
Hi,
Tested the MR MR! 4 with version 8.9.21 on my local, but it's working fine and resolved the issue.
Testing Steps:
1. Install the Drupal 8.9.21 version.
2. Install and set Robotic theme - version 8.1.1.
3. Enable the robotic theme and Place the search form block in Primary region
4. Clear the cache and reload the page.
Testing result: passed