Collapse many secondary tabs on mobile

Created on 13 May 2022, almost 3 years ago
Updated 12 May 2023, almost 2 years ago

Problem/Motivation

According to the Claro style guide, only the primary tabs are collapsed on mobile. The secondary tabs are all displayed. However, this could become very overloaded if there are many tabs.

Steps to reproduce

You will find the Claro style guide here or you can look at the screenshot below.

Proposed resolution

Maybe it would make sense to set an upper limit for secondary tabs, where you say that, for example, from 5 secondary tabs, they are also collapsed on mobile.

โœจ Feature request
Status

Active

Version

10.1 โœจ

Component
Claroย  โ†’

Last updated about 5 hours ago

Created by

๐Ÿ‡จ๐Ÿ‡ญSwitzerland romina_ferrario

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States m.stenta

    We may be interested in this within the farmOS distribution also. We make heavy use of tabs (both primary and secondary), and we have a lot of users on mobile. We use Gin (which inherits the secondary tab styling/behavior from Claro).

    I'm curious if there is a mechanism we could use to try collapsing our secondary tabs? I'm not familiar with how this behavior gets applied to the primary tabs currently. If I find any more information I will share it here.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States m.stenta

    We came up with our own solution in farmOS, which basically overrides the templates and CSS to make the secondary tabs collapse in the same way that the primary ones do. Screenshot attached. (Note that we are using the Gin theme, which inherits the tab behavior from Claro).

    Would this be worth pursuing as a core enhancement?

  • First commit to issue fork.
  • last update over 1 year ago
    Custom Commands Failed
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany hille

    I have changed the behaviour of the secondary tabs to be more useable with small displays.
    Its basically the same as the primary tabs.

  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany hille

    I have changed the behaviour of the secondary tabs to be more useable with small displays.
    Its basically the same as the primary tabs.

  • 39:08
    38:05
    Running
  • Status changed to RTBC over 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Moni_10

    Hii I've tested the above MR. Seems working fine for me. So, Moving this to RTBC
    Here's before and after screenshot.

  • last update over 1 year ago
    29,562 pass
  • last update over 1 year ago
    29,566 pass
  • last update over 1 year ago
    29,571 pass
  • last update over 1 year ago
    29,801 pass
  • Status changed to Needs work over 1 year ago
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany luenemann Sรผdbaden, Germany

    The current approach of MR !4262 always collapses when the secondary tabs overflow. The proposed solution is different.

    Set to Needs work (NW) for Issue summary update (IS update).

    I think a claro maintainer should have a look at the proposed solution.

  • First commit to issue fork.
  • Pipeline finished with Success
    4 months ago
    Total: 260s
    #315818
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia nayana_mvr

    Pipeline was not shown in the Merge Request and there was an option to create pipeline. After clicking that, the .gitlab-ci.yml file changes got committed to the MR. Not sure why that happened and why that file was missing in the first place. I tried creating a new branch but that also doesn't have .gitlab-ci.yml. Can somebody please look into it? Sorry for the inconvenience caused.

  • Pipeline finished with Failed
    4 months ago
    Total: 4345s
    #315829
Production build 0.71.5 2024