🇩🇪Germany @luenemann

Still need work for #75 (#67)

Test are passing now!

Fix

• code style
• phpstan basline
• test dependencies to node
• missing permission in tests

There is ✨ Add theming template and prepare logic for rendering icons Active to merge Icon API module → into core. I guess that's could be closed as duplicate.

Test only job fails as expected:
https://git.drupalcode.org/issue/drupal-3456417/-/jobs/3168817

Upgrade issue link.

@liquidcms MR !10 got committed in #97 and released in 3.3.

Fixed missing return type in new tests.

luenemann → made their first commit to this issue’s fork.

luenemann → changed the visibility of the branch 3171835-field-groups-marked to hidden.

This still needs tests and a new merge request for 11.x could be created...

@pameeela I guess it's 🌱 [12.x] [meta] Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 12 core Active .

• Fixed dependency in olivero_test module of system module
• Code Style fix

There's an error in TaxonomyImageTest

Drupal\Tests\taxonomy\Functional\TaxonomyImageTest::testTaxonomyImageUpload
    Behat\Mink\Exception\ResponseTextException: The text "Created new term" was not found anywhere in the text of the current page.

The error message on the page:

You do not have access to the referenced entity (file: 1).

luenemann → made their first commit to this issue’s fork.

luenemann → changed the visibility of the branch 3405137-make-parameter-optional to hidden.

luenemann → changed the visibility of the branch 3405137-missing-display-check to active.

luenemann → changed the visibility of the branch 3405137-missing-display-check to hidden.

@Anybody the code in #4 is my suggested change. Thank you for turning it into a MR.

@grevil I am not sure which change is preferable.

By looking at this again I thinks MR !24 won't work. If there are extra_fields for that entity bundle it will probably fail.

I am going to hide MR !24.

Still Needs work for target change on MR !10 to 2.1.x (@abramm)

@Mingsong thanks you for the review, sorry for the late response.

I have reviewed your changes and think they should be reverted, see the comments in the MR.

Maybe it is possible to add an integration test with smart_date. I'd like to give it a try.

Please review the MR !69

luenemann → created an issue.

This change removes support for datetime and daterange formatters / field types.

• timezone is a setting of TimestampFormatter
• timezone_override is a setting of DateTimeFormatterBase

Fullcalendar View should support both settings. #2976922-28: Add functionality for all-day events → even reverts these changes.

1. +++ b/src/FullcalendarViewPreprocess.php
   @@ -160,8 +160,8 @@ class FullcalendarViewPreprocess {
   -    $timezone = !empty($start_field_option['settings']['timezone']) ?
   -    $start_field_option['settings']['timezone'] : date_default_timezone_get();
   +    $timezone = !empty($start_field_option['settings']['timezone_override']) ?
   +    $start_field_option['settings']['timezone_override'] : date_default_timezone_get();
        // Set the first day setting.
   

   This reverts changes from 🐛 Entries always rendered with the field selected timezone Fixed . But that removes support for datetime and daterange formatters.
   timezone is a setting of timestamp formatter.
   This should be fixed in a separat issue to support both formatters.

2. +++ b/src/FullcalendarViewPreprocess.php
   @@ -332,7 +332,7 @@ class FullcalendarViewPreprocess {
   -              elseif (strpos($end_field_option['type'], 'daterange') !== FALSE) {
   +              elseif (strpos($end_field_option['type'], 'daterange_default') !== FALSE) {
   

   This change removes support for daterange_plain and daterange_custom formatters. It should be reverted.

Needs work for 2.

At a first loot this relates to ✨ Add functionality for all-day events Active .

Test only fails as expected: https://git.drupalcode.org/issue/drupal-2107455/-/pipelines/210442/test_...

It's also possible to just change the Signature of entity_extra_field_display to allow for null. The method can handle that.

function entity_extra_field_display(
  string $type,
  array &$build,
  EntityInterface $entity,
  ?EntityDisplayInterface $display
): void {

@crafter You should close this as a duplicate then.

Test only job failed with expected message: https://git.drupalcode.org/issue/drupal-3413508/-/jobs/614074#L54

This should be converted to a Merge Request. Change Status to Needs Review if you think it's ready.

📌 Restrict access to empty top level administration pages for overview controller Fixed touches the same function as this patch. Is that issue fixing the same problem?

hestenet → credited luenemann → .

luenemann → changed the visibility of the branch 3405798-config-deleted-during to active.

luenemann → changed the visibility of the branch 3405798-config-deleted-during to hidden.

Fixed link to project page.

Patch from #7 still applies to 10.1.x.

Sorry, service colorbox.gallery_id_generator is in use.

But use Drupal\Component\Utility\Crypt; is missing:

+++ b/colorbox.module
index 6b216e2..23c9a87 100644
--- a/colorbox.theme.inc

--- a/colorbox.theme.inc
+++ b/colorbox.theme.inc

+++ b/colorbox.theme.inc
+++ b/colorbox.theme.inc
@@ -8,6 +8,7 @@

@@ -8,6 +8,7 @@
 use Drupal\file\Entity\File;
 use Drupal\image\Entity\ImageStyle;
 use Drupal\Component\Utility\Xss;
+use Drupal\responsive_image\Entity\ResponsiveImageStyle;
 

@@ -139,6 +82,190 @@ function template_preprocess_colorbox_formatter(&$variables) {
+    $image_id = $entity_id . '-' . Crypt::randomBytesBase64(8);

No complete review!
The patch should use the service colorbox.gallery_id_generator introduced in #2935266: Make gallery id generation function independent. → , released in 8.x-1.7 on 5 March 2021

Commit don't show up. Here is the lint to the commit:
https://git.drupalcode.org/project/drupal/-/commit/dcd0ec7160cfa09cf700954b629775c5267ed0f9

luenemann → created an issue.

luenemann → created an issue.

I'm unsure if this is a won't fix or a regression on #3168326: Dropbuttons in table cells are potentially unusable if it includes options with long text length. → .

Maybe ✨ Add new Splitbutton render element to eventually replace Dropbutton Needs work can solve this.

After screenshot:

But this was changed in #3168326: Dropbuttons in table cells are potentially unusable if it includes options with long text length. → .

IS update for Steps to reproduce.

This isn't fixed / committed.

Setting to needs review to run tests.

More then 3000 tests are failing, for example:

1) Drupal\Tests\system\Functional\Module\InstallUninstallTest::testInstallUninstall
Array to string conversion

/var/www/html/core/lib/Drupal/Core/Extension/ModuleHandler.php:399
/var/www/html/core/lib/Drupal/Core/Extension/ModuleInstaller.php:385      <<<<<<<<<<< Changed by MR !4330
/var/www/html/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/var/www/html/core/includes/install.inc:557
/var/www/html/core/includes/install.core.inc:1114
/var/www/html/core/includes/install.core.inc:707
/var/www/html/core/includes/install.core.inc:578
/var/www/html/core/includes/install.core.inc:121
/var/www/html/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:290
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:553
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:366
/var/www/html/core/modules/system/tests/src/Functional/Module/ModuleTestBase.php:31
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

The current approach of MR !4262 always collapses when the secondary tabs overflow. The proposed solution is different.

Set to Needs work (NW) for Issue summary update (IS update).

I think a claro maintainer should have a look at the proposed solution.

@robertoperuzzo You can set preferred-intall in composer.json config (https://getcomposer.org/doc/06-config.md#preferred-install) . Use

composer config preferred-install.drupal/entity_reference_revisions source

@google01 the MR !5 does not apply to a released version because entity_composite_relationship_test.info.yml is changed by drupal.org release packaging.

As a solution you could switch to a git checkout of entity_reference_revisions like this:

composer reinstall --prefer-source drupal/entity_reference_revisions

It seems to work but did no extensive testing.

luenemann → created an issue.

Updating the proposed solution to document the changes of $this->value = REQUEST_TIME;, see #79.

Per #75 this was fixed by 🐛 ckeditor5 balloon area not shown in modal Fixed for gin.

#2095195: Remove deprecated field_attach_form_*() → had a todo about a new hook:

+++ b/core/modules/node/node.api.php
@@ -91,7 +89,7 @@
- *   - field_attach_form()
+ *   - @todo hook for EntityFormDisplay::buildForm()

That todo got lost in #2216535: Replace Node overview topic and Node API topic with Entity Hooks topic → 8 commits later.

8.x-1.7 was released 20 December 2022, and the fix is in that release. See https://www.drupal.org/project/views_ajax_history/releases/8.x-1.7 →

catch → credited luenemann → .

Ah - this was backported to 9.5.

Reproduced with Drupal 10.1.x-dev.

@hudri regarding #10: I think this is not about a custom theme. I would like gin_toolbar to play nice with Drupals default theme.

Olivero changed it's behavior in Drupal 10, see Slack message by @mherchel:

Is that Drupal 9 or 10? Within D10, Olivero uses the new custom CSS properties to place the header. Within D9, we only check for the CSS classes added by the toolbar

I've checked with

1. Drupal 10
2. Gin 8.x-3.0-rc2
3. Gin Toolbar 8.x-1.0-rc1

Still reproduceable.

In Drupal 9 it's not a problem, only Drupal 10. Didn't check Drupal 10.1.x

Commit to 9.5.x is missing:
https://git.drupalcode.org/project/drupal/-/commits/9.5.x?search=Issue+%...

• fix #334 reference
• convert comment references to links with dreditors help

Cannot reproduce on D9.

Relevant changes made in #3277809: Use Drupal.displace()'s new CSS variables to place Olivero's fixed header → , maybe #3291729: Refactor Olivero styles to use new --drupal-displace variables and ensure that toolbar/buttons are always visible → .

So Olivero D10 changed header positioning to use displace instead of fixed toolbar height values. Maybe worth a CR. But the Drupal toolbar had data-offset-top attribute before. Maybe gin_toolbar should have used it before.

I don't see the commit to 10.0.x?

I didn't test on Drupal 9, only Drupal 10.

Hm - i just came to evaluate this module and left a comment.
So next step is to reproduce the Issue on my side.

I just had an idee to avoid administerusersbyrole.settings at all. Attach the configuration to each role config via third_party_settings.

1. But a config import would delete any new Roles, not present in the export.
2. Agree needs to be addressed.

Custom Commands Failed, phpstan baseline needs to be updated.

I guess it's not about tour.module.

Add attribute data-offset-top only for the vertical toolbar layout.

It's not perfect for the horizontal toolbar:

Screenshot of proposed solution:

luenemann → created an issue. See original summary → .