Remove even more of the aggregate stale file threshold and state entry

Simple cleanup.

Interesting, I didn't find this when I reviewed 📌 Remove the aggregate stale file threshold and state entry Fixed because it's setting the asset type dynamically 😬

I'm not 100% sure we can remove this. Isn't this needed for the deprecated asset collection optimizers to work? 🤔

I didn't find this when I reviewed #3301573: Remove the aggregate stale file threshold and state entry because it's setting the asset type dynamically 😬

Yeah me neither :(

I'm not 100% sure we can remove this. Isn't this needed for the deprecated asset collection optimizers to work?

The deprecated asset collection optimizers set this themselves. If you were running them, they'd be writing the files directly to disk and updating the state entries too, you'd never hit the asset controller in the first place.

e.g.

$map[$key] = $uri;
$this->state->set('drupal_css_cache_files', $map);

in CssCollectionOptimizer::optimize()

+++ b/core/modules/system/src/Controller/AssetControllerBase.php
@@ -191,10 +191,6 @@ public function deliver(Request $request, string $file_name) {
       $uri = $this->dumper->dumpToUri($data, $this->assetType, $uri);

The return value here is no longer used.

Good point.

Thanks for the explanation in #5. Looks like #6 has been addressed too.

Committed 0bde716 and pushed to 11.x. Thanks!

Will this also be committed to 10.1.x?

I think it could be, moving there.

Patch from #7 still applies to 10.1.x.

Cherry-picked to 10.1.x.

Automatically closed - issue fixed for 2 weeks with no activity.