The Needs Review Queue Bot โ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 12:55pm 3 March 2023 - Status changed to Needs work
over 1 year ago 3:49pm 8 March 2023 - ๐บ๐ธUnited States smustgrave
Taking a look at the patch I see the upgrade path but no tests for it.
- ๐บ๐ธUnited States devkinetic
I have a view using database search api that has this issue. Adding/removing terms require a cache flush for them to apply within the exposed filter. This patch doesn't help as it doesn't add cache tags based on taxonomy within the DB search. May be a new issue, but the result is the same.
- Status changed to Needs review
over 1 year ago 9:16am 19 April 2023 - last update
over 1 year ago 29,287 pass - ๐ฎ๐ณIndia mohit_aghera Rajkot
- Adding a test case for validating config save of views.
- Resolving merge conflicts as patch was not getting applied on 10.1.x head. - Status changed to RTBC
over 1 year ago 11:31pm 19 April 2023 - ๐บ๐ธUnited States smustgrave
Upgrade tests look good, and fail locally.
- Status changed to Fixed
over 1 year ago 4:00pm 20 April 2023 - ๐ฉ๐ชGermany luenemann Sรผdbaden, Germany
catch โ credited luenemann โ .
- ๐ฌ๐งUnited Kingdom catch
@luenemann pointed out that the patch didn't address #50 and the update may not catch all cases. I think rather than copying more logic to detect when the view needs to be updated we could instead just load and save every view in the update. Reverted so we can re-commit with that change.
- Status changed to Needs work
over 1 year ago 8:26am 25 April 2023 - Status changed to Needs review
over 1 year ago 11:17am 25 April 2023 - last update
over 1 year ago 29,303 pass, 2 fail - ๐ณ๐ฑNetherlands Lendude Amsterdam
Made the update hook save all Views and added the 'only when exposed' option to the adding of tags and added test coverage for that.
Let's see what this does.
Local update testing seems to be broken for me, so let's see what the bot thinks....
The last submitted patch, 70: 2900248-70.patch, failed testing. View results โ
- Status changed to Needs work
over 1 year ago 9:00pm 25 April 2023 - ๐บ๐ธUnited States dww
Saw this in Slack, tagging to be smashed. ๐ I hope to look more closely soon...
- ๐บ๐ธUnited States socalerich
I am on 10.1.2 and I have this same issue. I have some exposed filters that are taxonomies. If I add or edit a content type that has an entity reference to one of these taxonomies, the taxonomy does not show up in my exposed filter as a choice unless I clear the cache. I just applied the patch in #70, but it did not fix the issue. Do I need to apply the patch from #70 AND #63?
- ๐บ๐ธUnited States devkinetic
I haven't been able to work around this issue yet, but I'm still on D9. I ended up installing https://www.drupal.org/project/rebuild_cache_access โ and instructing my authors of the one and only time to use it, and to schedule that during non peak hours.
I will be on D10 within the next month or so, and can certainly test this again at that point. I'd love to be able to remove that button.
- last update
9 months ago Patch Failed to Apply