- 🇦🇺Australia acbramley
Re #148 I think we need a review with fresh eyes. This was put back into NW in #118 with a bug in masquerade but @berdir pointed out this may be a bug in the module itself in #134
However, we may need to rethink this entirely based on that comment as well. I agree it's not the greatest solution, especially given the amount of seemingly unrelated changes made to get this to work.
- 🇦🇺Australia jannakha Brisbane!
So my test case is:
I'm moving access checks from hook_ENTITY_TYPE_access into RouteSubscriber.I've got a custom RouteSubscriber which adds Requirement with '_custom_access' based on user/entity on routes:
$collection->get('entity.node.delete_form')
$collection->get('entity.node.edit_form')the routes are not accessible when conditions are met - as expected
but on views Edit/Delete operations are visible (although they lead to access denied/error page)after applying patch #135 (to Drupal 10.4.5) - views operations are displayed as expected (no edit/delete ops when they should not be) just like when access was handled in hook_ENTITY_TYPE_access.
hurray!what else is required to release this issue?
PS now the issue is "Delete" op appears on "Edit" form when it's forbidden by RouteSubscriber/custom access execution.
If I won't find an existing issue, I'll create a new issue for that. here's existing issue for Media https://www.drupal.org/project/drupal/issues/2998824 🐛 MediaAccessControlHandler update/delete access caching is not correct Needs workPPS back to hook_ENTITY_TYPE_access for now (unless there are better suggestions?)
- 🇺🇸United States smustgrave
3 months has past so closing out, but don't worry if still a valid task this can be re-opened by anyone.
Thanks!
- 🇺🇸United States smustgrave
Thank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
- 🇺🇸United States smustgrave
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
