- 🇮🇳India vsujeetkumar Delhi
Reroll patch created for 9.5.x, Please have a look.
- Status changed to Needs work
over 1 year ago 8:37am 27 March 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 5:36pm 27 March 2023 - Status changed to Needs work
over 1 year ago 6:19am 28 March 2023 - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Both phpstan and phpcs are unhappy about the latest patch.
- Status changed to Needs review
over 1 year ago 7:02am 28 March 2023 - Status changed to Needs work
over 1 year ago 7:14am 28 March 2023 - Status changed to Needs review
over 1 year ago 7:48am 28 March 2023 - Status changed to Needs work
over 1 year ago 8:53am 28 March 2023 - 🇮🇳India TanujJain-TJ
Adding a reroll patch for 10.1.x and fixing all CCF issues and some other phpcs issues.
- Status changed to Needs review
over 1 year ago 8:54am 28 March 2023 - Status changed to Needs work
over 1 year ago 2:40pm 28 March 2023 - 🇺🇸United States smustgrave
Removing credit for #101, 103, 105, 108, 109, and 111 for the bad rerolls. It's expected to check your patches before uploading
You can check for build errors make sure to run
./core/scripts/dev/commit-code-check.sh
before uploading a patch to make sure there are no issues with code formatting. see https://www.drupal.org/docs/develop/development-tools/running-core-devel... →Also some were missing interdiffs and none mentioning how the patch no longer applies per the new policy. The file sizes fluctuates why is that?
Honestly next reroll should start at 97
Support for 9.5.x based on #111.
Then I made some adjustments, and when both translation and Content Moderation were enabled in the site, an exception occurred.
Steps, 1 Add node in en language, and publish en language.
2 Add the translation of ja language for it, but do not publish ja language.
At this point there will be no information about the language in the taxonomy_index table.
It cannot be displayed in the view.
This is considered an unusual error on our site. Published languages should be visible to anonymous users.
Unpublished languages may be checked in the normal workflow, it cannot affect the normal published display.- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Build Successful Following the advice from #112, from #97, that seems more reasonable.
Also, this is only in 9.5.x.- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Build Successful - last update
11 months ago Composer error. Unable to continue. - last update
11 months ago Custom Commands Failed - last update
8 months ago Patch Failed to Apply - 🇮🇳India sumit_saini
Patch in #120 is missing a use statement for Node class.
Updated patch in #120 to fix it. (created for 10.2.x) - First commit to issue fork.
- Merge request !7968Issue#2889486: Add language value to contextual filter of taxonomy. → (Open) created by sakthi_dev
- Status changed to Needs review
5 months ago 11:20am 1 August 2024 - Merge request !9023Issue #2889486 by kriboogh: "Has taxonomy term" contextual filter does not... → (Open) created by kriboogh
- Status changed to Needs work
5 months ago 11:47am 1 August 2024 - Status changed to Needs review
5 months ago 1:06pm 1 August 2024 - Status changed to Needs work
5 months ago 1:28pm 1 August 2024 - 🇺🇸United States smustgrave
Before anyone reviews can the MRs and patches be cleaned up. Not sure which MR is to be reviewed the most recent one is for 10.3 but should be against 11.x but don't want to make that assumption. Also patches should be hidden.
- Status changed to Needs review
5 months ago 7:32am 2 August 2024 - 🇧🇪Belgium kriboogh
MR!9023 is for 10.3 (patch 127)
MR!7968 is for 11 (patch 124)
- Status changed to Needs work
4 months ago 10:56pm 8 August 2024 - First commit to issue fork.
- 🇮🇳India shalini_jha
I have updated the code based on PR feedback and fixed the pipeline for the failing test. moving this to NR.
Kindly review. - 🇮🇳India sagarmohite0031
Hello,
MR applied successfully, Both articles are displayed in both languages.
Also can add filter.
Check attachments- The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.