"Has taxonomy term" contextual filter does not take the language value into account

Reroll patch created for 9.5.x, Please have a look.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rerolling for 10.x, couldn't generate an inderdiff

Both phpstan and phpcs are unhappy about the latest patch.

Fixed CCF.

#105 Fixed CCF.

Well no, it still fails.
Please run the script locally before using the drupal.org resources.

core/scripts/dev/commit-code-check.sh --drupalci

Adding a reroll patch for 10.1.x and fixing all CCF issues and some other phpcs issues.

Removing credit for #101, 103, 105, 108, 109, and 111 for the bad rerolls. It's expected to check your patches before uploading

You can check for build errors make sure to run ./core/scripts/dev/commit-code-check.sh before uploading a patch to make sure there are no issues with code formatting. see https://www.drupal.org/docs/develop/development-tools/running-core-devel... →

Also some were missing interdiffs and none mentioning how the patch no longer applies per the new policy. The file sizes fluctuates why is that?

Honestly next reroll should start at 97

Support for 9.5.x based on #111.
Then I made some adjustments, and when both translation and Content Moderation were enabled in the site, an exception occurred.
Steps, 1 Add node in en language, and publish en language.
2 Add the translation of ja language for it, but do not publish ja language.
At this point there will be no information about the language in the taxonomy_index table.
It cannot be displayed in the view.
This is considered an unusual error on our site. Published languages should be visible to anonymous users.
Unpublished languages may be checked in the normal workflow, it cannot affect the normal published display.

fixed test.

Following the advice from #112, from #97, that seems more reasonable.
Also, this is only in 9.5.x.

Infinite loop updb.

Fixed CCF failure, added interdiff for same

Re-rolled patch from #118 for 10.2.x

Fixed CCF failure in #119, added interdiff for same

Patch in #120 is missing a use statement for Node class.
Updated patch in #120 to fix it. (created for 10.2.x)

Add patch for MR!7968.
Fixed phpcs and tests.

Added MR for roll-back to 10.3 and patch.

Fixed mysql issue with primary key creation on 10.3

Before anyone reviews can the MRs and patches be cleaned up. Not sure which MR is to be reviewed the most recent one is for 10.3 but should be against 11.x but don't want to make that assumption. Also patches should be hidden.

MR!9023 is for 10.3 (patch 127)

MR!7968 is for 11 (patch 124)

Left some comments on MR.

I have updated the code based on PR feedback and fixed the pipeline for the failing test. moving this to NR.
Kindly review.

Hello,
MR applied successfully, Both articles are displayed in both languages.
Also can add filter.
Check attachments-

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

shalini_jha → changed the visibility of the branch 2889486-has-taxonomy-term-10.3 to hidden.

Rebased & fixed conflicts . Moving back to review.

Hi,
Test status - Pass
Issue can be reproduced. Patch applied successfully and issue looks fixed.
Verified on Drupal 11.x- dev
Testing steps-

- Create an article with a tag, for example in english
- Translate the article in french and do not associate the french version with the tag.
- Go to the tag page in english
- See your article in english: OK, normal
- Go to the tag page in french
- See your article in french: the french version of the article is not associated with the tag

Also observed that,A new view filter is created: "Taxonomy term: Node language"
Attaching screenshots for reference.

RTBC+1

jan kellermann → made their first commit to this issue’s fork.

Left comments on MR, thanks for keeping it going!

Thank you for the review and feedback :)
I’ve addressed one of the points. Regarding the hook_update_N test coverage, I haven’t worked on this type of test before, so it is still pending. I’ll try to find a solution for it.