When I applied the #74, the tick mark shown in selected option is getting disappeared when I click on Done button in filters.
So I have fixed it. Please review.
Hi @prashant
Thanks for the confirmation.
Actually I was facing an issue in my Drupal 10 code and the MR is related to the 11.x so I have created it for 10.3.x.
I am not sure how we can use the MR code in the composer patches. Sorry for that.
I am facing the same issue with the Drupal 10.3 version so attaching the updated patch.
I have added the package name. Please review.
Let me work on it.
Below are the PHPSTAN errors
PHP Warning: Undefined global variable $base_path in /var/www/html/drupal10/web/core/includes/common.inc on line 161
Warning: Undefined global variable $base_path in /var/www/html/drupal10/web/core/includes/common.inc on line 161
5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ----------------------------------------------------------------------------------------------------------------------------------------
Line src/PDFToImageBatchHelper.php
------ ----------------------------------------------------------------------------------------------------------------------------------------
117 Parameter $pdf of method Drupal\pdf_to_imagefield\PDFToImageBatchHelper::generateProcessPage() has invalid type Spatie\PdfToImage\Pdf.
133 Parameter $pdf of method Drupal\pdf_to_imagefield\PDFToImageBatchHelper::generatePage() has invalid type Spatie\PdfToImage\Pdf.
------ ----------------------------------------------------------------------------------------------------------------------------------------
------ ---------------------------------------------------------------------
Line src/PDFToImageManager.php
------ ---------------------------------------------------------------------
169 Instantiated class Spatie\PdfToImage\Pdf not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ ---------------------------------------------------------------------
------ -----------------------------------------------------------------------------------
Line src/Plugin/Field/FieldWidget/PDFToImageWidget.php
------ -----------------------------------------------------------------------------------
64 Unsafe usage of new static().
💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
------ -----------------------------------------------------------------------------------
I just investigated on the above and it showing imagick extension is missing as per https://github.com/spatie/pdf-to-image/issues/145
sourabhjain → made their first commit to this issue’s fork.
Updated the link from https://drupal.org/documentation/modules/entity_reference_revisions to https://drupal.org/project/entity_reference_revisions. Please review.
Let me work on it.
I have resolved the error. Please review the MR.
sourabhjain → made their first commit to this issue’s fork.
I am able to replicate the issue.
Let me try to work on this.
I have fixed the issue and created the MR. Please review.
Attaching the screenshot also after changes.
sourabhjain → made their first commit to this issue’s fork.
This theme is using the image instead of icon so we need to create a image for twitter.
I have fixed the issue and created the MR. Please review.
Attaching the screenshot also after changes.
sourabhjain → made their first commit to this issue’s fork.
I have removed the CSS file. Please review it now.
sourabhjain → made their first commit to this issue’s fork.
I have fixed the issue. Please review the MR.
Attaching screenshot as well after applying patch.
@shweta__sharma we have already created a MR 7 so I don't see any reason to create new PR. Could you please close one of them. It will create a confusion.
Removed the Intro section and added project name. Please review it now.
@pefferen I don't see you haven't given credit to anyone apart from you. Is there any specific reason?
I have resolved the issue. Please review MR
Attaching screenshot after update.
I have figured out the issue. Let me try to fix it.
I have resolved all the \Drupal calls issue from the project. Please review it now.
sourabhjain → made their first commit to this issue’s fork.
I have added the dependency injection. Please review the MR 10
sourabhjain → changed the visibility of the branch 3418316-injected-dependencies to hidden.
Let me work on this.
sourabhjain → made their first commit to this issue’s fork.
Fixed CCF failure in #119, added interdiff for same
I have fixed warning mentioned in #11. Please review.
sourabhjain → made their first commit to this issue’s fork.
I have reviewed the changes and its working fine but the menu li colour is white and the background is also white so it is not visible. Could anyone either update the menu background colour or link colour so it will be visible on front end.
sourabhjain → made their first commit to this issue’s fork.
I have fixed most of the errors. Now only three are pending.
FILE: /var/www/html/drupal10/web/modules/contrib/search_api_synonym/src/Import/ImportPluginBase.php
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
95 | WARNING | Possible useless method overriding detected
---------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal10/web/modules/contrib/search_api_synonym/src/Export/ExportPluginBase.php
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
80 | WARNING | Possible useless method overriding detected
---------------------------------------------------------------------------------------------------
FILE: /var/www/html/drupal10/web/modules/contrib/search_api_synonym/src/Form/SynonymSettingsForm.php
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
167 | WARNING | Possible useless method overriding detected
----------------------------------------------------------------------------------------------------
Time: 244ms; Memory: 10MBsourabhjain → made their first commit to this issue’s fork.
@nisha_j Could you please add the interdiff file too.
Hi @vibrasphere
I am trying to generate the issue in Drupal 7 as mentioned module version but not able to replicate the issue. Could you please let us know if we need to enable the other module also together with the User revision.
I have fixed the issue and created the MR. Please review.
Attaching the screenshot also after changes.
sourabhjain → made their first commit to this issue’s fork.
I have fixed the issue and created the MR. Please review.
Attaching the screenshot also after changes.
Let me work on it.
I have fixed the issue and created the MR. Please review.
Attaching the screenshot also after changes.
Let me work on it.
I have fixed the issue and created the MR. Please review.
Attaching the screenshot also after changes.
I have fixed the issue and created the MR. Please review.
Attaching the screenshot also after changes.
I have fixed the issue and created the MR. Please review.
Attaching the screenshot also after changes.
Let me work on it.
@shweta Left sidebar showing for me as well it is showing in the Block demostration but the Right sidebar and highlighted regions are not showing so I have added it.
Attaching the screenshot for block demostration after and before patch.
Please review the MR and let me know if we need to place these regions anywhere else.
Let me work on it.
sourabhjain → made their first commit to this issue’s fork.
sourabhjain → made their first commit to this issue’s fork.
@nitin Could you please check the comments on MR.
Let me work on this.
sourabhjain → made their first commit to this issue’s fork.
sourabhjain → made their first commit to this issue’s fork.
sourabhjain → made their first commit to this issue’s fork.
sourabhjain → made their first commit to this issue’s fork.
Let me work on it.