Update Twitter to X

Proposed Solution
Need to Update the twitter.svg in icons folder and also need to change the twitter to 'X' in social_media.settings.yml

Wrote a patch that changes the twitter icon to the "X" variant, renames the 'Twitter' to 'X' in the form and also changes the api_url to the X variant. Please review.

Verified the #3 patch on 9.5.8, the link, icon, and text is updated for Twitter. Added screenshots for reference, RTBC++

Two things I noticed with the patch is that the SVG is minified now, it should not have to IMO.

We could also maybe get away removing the translate function. As X is not really translatable:|
line 248: 'twitter' => $this->t('X'),

Made the "X" variant of the svg a multiline svg, instead of minified

We could also maybe get away removing the translate function. As X is not really translatable:|
line 248: 'twitter' => $this->t('X'),

I agree and we could also remove it for the other names (e.g. pinterest, facebook etc.) as well.

I couldn't find an official version of the 'X' logo that has the circle around it. The only provided svg on their brand page (https://about.twitter.com/en/who-we-are/brand-toolkit) does not have the circle around the X. I've updated the patch with the version of the svg that is provided on their brand page since the official logo should be used.

I made a mistake in the patch file (the wrong fill colour). Here is a corrected version.

The patch works great, but the logo looks really weird when surrounded by the circle ones. Twitter's old logo allowed for circles (https://about.twitter.com/content/dam/about-twitter/en/brand-toolkit/dow...), so I don't see a reason why we couldn't do the same here, as long we don't change the X color or shape.

Agreed with @davemybes. I have checked the #9 and its looks weird. Attaching screenshot for reference
Let me try to create new.

In this PR I haven't included the changes of changing the api_url as twitter is still using the old URLs.
If we will hit the https://x.com/intent/tweet then it will redirected to the https://twitter.com/intent/tweet so we don't need to change the URL.
Attaching Screenshot after changes.

Just updated the MR by removing any twitter references on the configurations and on the form, since I did this, we would need a hook update, so I have commited one, the following patch is just the current state of the MR since it's hard to patch the MR directly(poiting to a commit)

Tested with the MR! 15 , The Default logo against the dark background is nearly invisible.
Moving it to Need review

Testing Steps :
1. Install Drupal and Social Media share
2. Add the Social media share block in block layout

Hey @divya.sejekan, thanks for your testing, but I don't know if this a problem here, you're gonna see this happening with almost all the icons.
For example: If my background is red, and I want to show the pinterest, the background color will conflict with the icon.

For this scenario you'll have to link another icon, and you can do it easily by accessing the admin/config/services/social-media and changing the default image. So I'll move this back to NR, and here is another patch with the latest stuff from the MR.

it's the X its self that is not white, but it should always be when a black background color is used as circle.
see https://about.twitter.com/en/who-we-are/brand-toolkit

It is strange that this module is not using the original brand colors on all icons.
Same with Linkedin and Facebook. the F should be always white I guess.
(https://about.meta.com/brand/resources/facebook/logo/)
Maybe something for a flow-up to make other the logo's as they should be.

updated the twitter icon to x - icon

The icon X is updated . Since these are default icons and icons can be changed. Verified on Oliver and claro.
Keeping it in Review for further review

Testing Steps :
1. Install Drupal and Social Media share
2. Add the Social media share block in block layout