This is still happening in 2.1.0. However, it does appear that the correct years are shown in the filter (I'm using exposed filter on a date field), even though the setting always shows 2000. I even had one suddenly start to ignore the end year, but resaving the settings fixed that.
The above patch fails, so I've tried rewriting it with a Drupal date function instead of the older PHP one.
Huh, my previous comment didn't have the option to change status...
Confirming that this patch fixes the issue when the date is day 1 of the month.
Can we get a release for this fix? I just installed v4.0.2 on a site that never had it before and the site went down immediately with this error. Uninstalling the module restored the site. Applying the patch and re-enabling it worked perfectly too. I can run composer and apply the patch easily, but a release seems like a good idea for such a drastic error.
With the patch in #19, I'm seeing a fatal error when saving the settings page:
Fatal error: Declaration of SevenShores\Hubspot\Http\Response::getStatusCode() must be compatible with Psr\Http\Message\ResponseInterface::getStatusCode(): int in vendor/hubspot/hubspot-php/src/Http/Response.php on line 326
I'm assuming this is because the hubspot-php library is still 3.2.1?
For #16, I couldn't save the page, because the Client ID & Secret fields are required. If I changed them to not required in the module code, the page saves, but gives an error:
Uncaught PHP Exception Error: "Call to undefined method SevenShores\\Hubspot\\Factory::createWithAccessToken()" at /modules/contrib/hubspot/src/Form/AdminSettings.php line 261
This is also probably due to the old php library. When I use composer to pull the module and patch it, that library does not get updated. If there's a way to make that happen after the patch, let me know how, please.
davemybes → created an issue.
The patch works great, but the logo looks really weird when surrounded by the circle ones. Twitter's old logo allowed for circles (https://about.twitter.com/content/dam/about-twitter/en/brand-toolkit/dow...), so I don't see a reason why we couldn't do the same here, as long we don't change the X color or shape.
Great tip about the Testing CDN option - that appears to have fixed the cookie setting issue. I couldn't understand why cookiepro was working with the production code, though, so I checked the code base and we're overriding that code with the -test code in settings.php for non-prod environments. So that explains why it worked with that module.
I really appreciate your very quick and informative response. And thanks for having a great alternative to cookiepro.
davemybes → created an issue.
Tested this in Drupal 10.1.6 and it worked perfectly. The option to use Fancybox appears properly in the image field and images pop up fine with the caption.
What appears to be happening with the patches is that even though the info.yml file is showing D10 compatibility, composer.lock is still registering it as D9 only, so composer won't actually do the upgrade. We need an actual release to be able to update to D10. The only alternative is to move the module into custom modules and not use composer to update it - at least until a proper release is out.