🇳🇱Netherlands @Martijn de Wit

This could be closed now #3257729 is in.

Feel free to re-open if it doesn't fix this problem.

maybe via https://www.drupal.org/project/drupal/issues/3482385#comment-15842192 📌 Add a feature flag for the procedural hooks bc layer Active

martijn de wit → created an issue.

martijn de wit → created an issue.

Needed this path after we've got an error after upgrading the module

PHP Fatal error:  Declaration of Drupal\imageapi_optimize_webp\Controller\ImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style) must be compatible with Drupal\image\Controller\ImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style, string $required_derivative_scheme) in ..../web/modules/contrib/imageapi_optimize_webp/src/Controller/ImageStyleDownloadController.php on line 36

we are on php v 8.3.1
using D Core 10.3.6

Is there a dependency on a specific version of webform in this change?

Tested the merge request / patch.

Everything seems to work fine now!
Thank you for the quick response!

martijn de wit → created an issue.

If you want to test a patch. Please use the most recent one from the merge request(s).

How about using: ✨ Add a Title Formatter Active

Proposed resolution seems fine.

Thanx for reviewing.

Did you try the merge request ?

Martijn de Wit → created an issue.

Fixed all automated PHPCS

Martijn de Wit → created an issue.

I will add it to the 3.x dev branch. thank you!

Check, thank you! Still have to explore all those gitlab features🙈

🐛 Why is SvgImageWidget inheriting from FileWidget instead for ImageWidget? Active is also solving the same problem. Would be nice if the maintainer chose / close duplicates.

There are now 3 tickets that are trying to solve sort of the same problem.

Think 🐛 Why is SvgImageWidget inheriting from FileWidget instead for ImageWidget? Active would be the preferred one.

It's recommended to use asset-packagist to install JavaScript libraries. Like bower-asset or npm-asset
Add the following to your composer.json file into the repositories section:

 {
        "type": "composer",
        "url": "https://asset-packagist.org"
    }

And extend the 'installer-path' section:

"web/libraries/{$name}": [
        "type:drupal-library",
        "type:bower-asset",
        "type:npm-asset"
    ],

And add a new 'installer-types' section next to the 'installer-path' in the 'extra' section:
"installer-types": ["bower-asset", "npm-asset"],

Would be nice if the merge request is updated with the latest changes from #8

It seems that this is the Site e-mail adres in the 2.x version

You can find this under /admin/config/system/site-information/ -> E-mail.

 $default_from_email = \Drupal::config('system.site')->get('mail');

webform_email_reply/src/Form/WebformEmailReplyForm.php

Apparently the merge request was at the wrong branch...

Fixed this issue at the 2.0 branch.

ok then let's set focus to #20.

Hide all other files...

Added merge request

Martijn de Wit → created an issue.

image styles have a convert task to create a different file format. That is Drupal Core functionality.
Did you use other modules as well? Such as Image Api or other contributed modules?
And is the image style working in just plain Drupal?
To much unknown to reproduce the issue.

Please share some more information about your situation. Now it is not clear it is a bug or something is missing in the configuration or caused by an other module or custom code... etc....

Hiding all old patches

Resolved merge conflicts after 📌 Convert FieldFormatter plugin discovery to attributes Active was committed.

This is already in 10.2 @abelass

See: https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-... → Why it is : "catch committed bcaa369c on 11.x"

Feature plans: Make this module Drupal 10 proof.

The field group module → is already offering such "feature". More kind of a work around because things are not wel managed in core.

The issue ticket where that was developed: #2652642: Allow to position the group in the advanced (sidebar) column →
Hope this ads some extra info / context.

Great to see some fresh conversations are there.

I would like to take maintainer-ship off this module, if possible.

Does the 🌱 [Plan] Improve field creation experience Active fix this issue concerns?

it's the X its self that is not white, but it should always be when a black background color is used as circle.
see https://about.twitter.com/en/who-we-are/brand-toolkit

It is strange that this module is not using the original brand colors on all icons.
Same with Linkedin and Facebook. the F should be always white I guess.
(https://about.meta.com/brand/resources/facebook/logo/)
Maybe something for a flow-up to make other the logo's as they should be.

It was submitted in ✨ Add support for "Search API (tags based)" caching in Views Fixed on the 2.x branch

@camslice did you try the https://www.drupal.org/project/twig_field_value → module?

so it should be fixed in #2901148: Double "Message" wizard naming in views for message entity → for anyone wondering.

Thank you @samir_shukla, indeed this request needs more info.

Browser version. Drupal version. Other libraries when used.
Some screenshots of the browser console with error's

thank you for the help artemboiko. Renaming it to 10.2.x will make things clearer.

Drupal V 10.3 will be branched from 11.x. I don't this will land in 10.2.x because of the size and changes.
So I think all effort should be at the merge request for the 11.x branch.

I think we need al lot of people testing this, maybe a sign off from a (sub)core maintainer ?

We are developing the new version at the 3.x branch.
PHP part is roughly done. JS part has to be done.

@manojbisht_drupal please use the merge request.

And if you need a patch, everyone can download a diff/patch from gitlab and load it local with composer.

(hide patches to get focus on merge request.)

Martijn de Wit → changed the visibility of the branch 2546212-entity-viewform-mode to hidden.

Martijn de Wit → changed the visibility of the branch 11.x to hidden.

Why using the patch from #48?

There is a merge request that is far more recent? containing solution after several discussions with good points ..

It is the new Drupal core branching:
https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-... →

Drupal 10.2 is released

xmacinfo did you already try the new theme/template generator in Drupal ?

Martijn de Wit → created an issue.

Realy like this feature.

Patch works as advertised.

Only asking my self if this could be done with permission. Because there are different permission for for voting up or voting down. Would make more sense to me to use those, then an extra option.

✨ Add Media revision UI Fixed is committed to core 10.2 that will be released end this year

The fact that no one is responding to your question doesn't mean the module is not maintained anymore.

To start with, if you want someone to help you, please add a proper test path.
Maybe some screenshots or a short video of your configuration.

Reading your question; is resulting in a lot of other questions.

• How did you configure the node display settings.
• how did you configure the field display settings.
• what kind of drupal theme are you using
• Are you using the repsonsive image module
• How did you configure the image styles.
• etc..

set to needs review, because there is a patch / merge request.

Hide patch in favour for merge request

set to needs review because there is a patch
and remove assignee

ran into this issue. Patch seems to fix te problem.

Maybe some extra white space between these two fields:

I would opt in for option 3 from #4

Funny fact: If you enable Field Layout (core) module, option 3 is working out of the box.

Agree lets discus it further at ✨ Allow node/entity to display title/label field as normal Needs work

yes I meant content.title. sorry for the confusing.

I didn't check this recently, will try to do it this week and come back at it.

Seems we have to rewrite a part of the module and create an upgrade path.

Ran into this problem during a project. Where we use the JSON API to unlock Drupal fields to a decoupled front end.

After installing the patch we get values back and the error message regarding sterilization is gone.

Our error message:
TypeError: Drupal\serialization\Normalizer\PrimitiveDataNormalizer::normalize(): Return value must be of type ArrayObject|array|string|int|float|bool|null, DateInterval returned in Drupal\serialization\Normalizer\PrimitiveDataNormalizer->normalize()

Core patch is committed 🐛 hook_image_style_flush doesn't get the $path passed to Drupal\image\Entity\ImageStyle::flush() method Fixed

Will check this in coming weeks.

This issue is fixed in 📌 Automated Drupal 10 compatibility fixes Fixed

@Ajeet

You changed
if (strpos($form_key, '#') == 0) {

into

if (strpos($form_key, '#') === 0) {

But your new patch is also changing the document/patch structure with extra spaces etc.
Please provide an inter-div so the new patch can easily be reviewed.

@damien

There is also a discussion here: 📌 Add image preload option to help boost actual and perceived performance Needs work on adding extra options to this list.