🇳🇱Netherlands @Martijn de Wit

Not that I can think of right now.

The implementation is per field. If you came to a solution I'm happy to hear :)

Is the plan to go D11 at 2.x and 3.x or only 3.x ?

tests are there. See #65

Agree that moving the checkboxes should be a follow up. Muted is already in core.

removing the needs screenshot tag.

Adding new screenshots. Made after a clean D11 DDEV + patch from merge request.

1. After adding the patch;
2. The poster field is now added to the video widget ; /admin/structure/media/manage/video/display

Steps to get a custom poster field

1. An image field is needed; admin/structure/media/manage/video/fields
2. "Create a new field" and then choose: "File upload" Select the Image field option.
3. After creating the image field, This field will be selectable at the video widget; /admin/structure/media/manage/video/display

The only thing that could confuse less experienced users in my opinion, is that if you don't understand how to create the "extra" image field that will be displayed in the video widget scenario. The user sees the "thumbnail" image as an option. If a user doesn't understand he/she needs to create a (new) field on the video media entity, then it could be the user is going to search where he can upload the Poster image into the "thumbnail" field. This field is not present in the form display options so it leaves the user clueless what to do.

martijn de wit → changed the visibility of the branch 3504520-templateissue to hidden.

Yeah I tink it would be great if this an option. Just like header and footer.

Didn't find the discussion, good the know.

and yes we are overriding the template with a copy in the custom theme 😊

I don't know if this is a "api" change from typeform or this was just a typo.

Made a merge request to fix it.

martijn de wit → created an issue.

Are your tests all based on the patch in #15 ?

We are using #15 now and it works perfect

that's true.🙈

thank you for all the work @ivnish ! 🙏

Drupal 7 has reached end of life →

Drupal 7 has reached end of life
[#3498240]

I don't know if it is a good idea to make an option to skip the sanitizer. (security etc... )

Why not make the options available: https://github.com/darylldoyle/svg-sanitizer?tab=readme-ov-file#options

There is already a Drupal module doing this:
https://www.drupal.org/project/svg_sanitizer →

Maybe this module can work together with the above one or check the code they wrote.

Question seems to be a duplicate off : 💬 Where to set the default "to" email address Closed: works as designed

also the use case could be a duplicate off: ✨ Prevent duplicates Active

There is a patch available. Changing status.

Would be nice if patch goes into a merge request, so it is visible if patch still applies.

Changing status to "Needs work".

Already fixed in 📌 Drupal 10 compatibility Fixed

well found and small fix with merge request

Think this merge request should be target to 2.X version. (If the bug is still there)

I just can't understand the new page Hero at the frontpage.

It scales the width/height of my entire screen. In my opinion there is no use full information displayed. No call to actions no other use full content. The menu fades away by all the distraction.

The lines in the background make the overall picture very busy, it seems like a lot is happening, but actually nothing is happening.

As a new visitor who never visits drupal.org I would just click the page away, it just scares me.

On mobile view, the hero is cluttered against the message on the frontpage.

Will this be opt-out ? or Opt-in?

IS and code is now opt-out. So default the URL discovery option is enabled.

In #6 SeanB is suggesting to make it Opt-out.

If this option is not needed for Youtube and Vimeo and other big Oembed players I would suggest to make the option Opt-in.

Unfortunately in #227 ✨ Drastically improve Drupal's default linking experience in text fields Needs work the merge request is closed.
I can't reopen it in https://git.drupalcode.org/project/drupal/-/merge_requests/10361. Maybe someone with some extra permissions?

Maybe we can convert this issue to a meta ticket holding all suggested child tickets?

This could be closed now #3257729 is in.

Feel free to re-open if it doesn't fix this problem.

maybe via https://www.drupal.org/project/drupal/issues/3482385#comment-15842192 📌 Add a feature flag for the procedural hooks bc layer Active

martijn de wit → created an issue.

martijn de wit → created an issue.

Needed this path after we've got an error after upgrading the module

PHP Fatal error:  Declaration of Drupal\imageapi_optimize_webp\Controller\ImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style) must be compatible with Drupal\image\Controller\ImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style, string $required_derivative_scheme) in ..../web/modules/contrib/imageapi_optimize_webp/src/Controller/ImageStyleDownloadController.php on line 36

we are on php v 8.3.1
using D Core 10.3.6

Is there a dependency on a specific version of webform in this change?

Tested the merge request / patch.

Everything seems to work fine now!
Thank you for the quick response!

martijn de wit → created an issue.

If you want to test a patch. Please use the most recent one from the merge request(s).

How about using: ✨ Add a tag select list in string Formatter Needs review

Proposed resolution seems fine.

Thanx for reviewing.

Did you try the merge request ?

Martijn de Wit → created an issue.

Fixed all automated PHPCS

Martijn de Wit → created an issue.

I will add it to the 3.x dev branch. thank you!

Check, thank you! Still have to explore all those gitlab features🙈

🐛 Why is SvgImageWidget inheriting from FileWidget instead for ImageWidget? Active is also solving the same problem. Would be nice if the maintainer chose / close duplicates.

There are now 3 tickets that are trying to solve sort of the same problem.

Think 🐛 Why is SvgImageWidget inheriting from FileWidget instead for ImageWidget? Active would be the preferred one.

It's recommended to use asset-packagist to install JavaScript libraries. Like bower-asset or npm-asset
Add the following to your composer.json file into the repositories section:

 {
        "type": "composer",
        "url": "https://asset-packagist.org"
    }

And extend the 'installer-path' section:

"web/libraries/{$name}": [
        "type:drupal-library",
        "type:bower-asset",
        "type:npm-asset"
    ],

And add a new 'installer-types' section next to the 'installer-path' in the 'extra' section:
"installer-types": ["bower-asset", "npm-asset"],

Would be nice if the merge request is updated with the latest changes from #8

It seems that this is the Site e-mail adres in the 2.x version

You can find this under /admin/config/system/site-information/ -> E-mail.

 $default_from_email = \Drupal::config('system.site')->get('mail');

webform_email_reply/src/Form/WebformEmailReplyForm.php

Apparently the merge request was at the wrong branch...

Fixed this issue at the 2.0 branch.

ok then let's set focus to #20.

Hide all other files...

Added merge request

Martijn de Wit → created an issue.

image styles have a convert task to create a different file format. That is Drupal Core functionality.
Did you use other modules as well? Such as Image Api or other contributed modules?
And is the image style working in just plain Drupal?
To much unknown to reproduce the issue.

Please share some more information about your situation. Now it is not clear it is a bug or something is missing in the configuration or caused by an other module or custom code... etc....

Hiding all old patches

Resolved merge conflicts after 📌 Convert FieldFormatter plugin discovery to attributes Active was committed.

This is already in 10.2 @abelass

See: https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-... → Why it is : "catch committed bcaa369c on 11.x"

Feature plans: Make this module Drupal 10 proof.

The field group module → is already offering such "feature". More kind of a work around because things are not wel managed in core.

The issue ticket where that was developed: #2652642: Allow to position the group in the advanced (sidebar) column →
Hope this ads some extra info / context.

Great to see some fresh conversations are there.

I would like to take maintainer-ship off this module, if possible.

Does the 🌱 [Plan] Improve field creation experience Active fix this issue concerns?

it's the X its self that is not white, but it should always be when a black background color is used as circle.
see https://about.twitter.com/en/who-we-are/brand-toolkit

It is strange that this module is not using the original brand colors on all icons.
Same with Linkedin and Facebook. the F should be always white I guess.
(https://about.meta.com/brand/resources/facebook/logo/)
Maybe something for a flow-up to make other the logo's as they should be.

It was submitted in ✨ Add support for "Search API (tags based)" caching in Views Fixed on the 2.x branch

@camslice did you try the https://www.drupal.org/project/twig_field_value → module?

so it should be fixed in #2901148: Double "Message" wizard naming in views for message entity → for anyone wondering.

Thank you @samir_shukla, indeed this request needs more info.

Browser version. Drupal version. Other libraries when used.
Some screenshots of the browser console with error's

thank you for the help artemboiko. Renaming it to 10.2.x will make things clearer.

Drupal V 10.3 will be branched from 11.x. I don't this will land in 10.2.x because of the size and changes.
So I think all effort should be at the merge request for the 11.x branch.

I think we need al lot of people testing this, maybe a sign off from a (sub)core maintainer ?

We are developing the new version at the 3.x branch.
PHP part is roughly done. JS part has to be done.

@manojbisht_drupal please use the merge request.

And if you need a patch, everyone can download a diff/patch from gitlab and load it local with composer.

(hide patches to get focus on merge request.)