🇳🇱 The Netherlands
Account created on 2 October 2006, over 18 years ago
  • Drupal specialist & Partner at Ablerz 
#

Merge Requests

Recent comments

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

thank you for all the work @ivnish ! 🙏

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands
🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands
🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

I don't know if it is a good idea to make an option to skip the sanitizer. (security etc... )

Why not make the options available: https://github.com/darylldoyle/svg-sanitizer?tab=readme-ov-file#options

There is already a Drupal module doing this:
https://www.drupal.org/project/svg_sanitizer

Maybe this module can work together with the above one or check the code they wrote.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Question seems to be a duplicate off : 💬 Where to set the default "to" email address Closed: works as designed

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

also the use case could be a duplicate off: Prevent duplicates Active

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

There is a patch available. Changing status.

Would be nice if patch goes into a merge request, so it is visible if patch still applies.

Changing status to "Needs work".

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

well found and small fix with merge request

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Think this merge request should be target to 2.X version. (If the bug is still there)

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

I just can't understand the new page Hero at the frontpage.

It scales the width/height of my entire screen. In my opinion there is no use full information displayed. No call to actions no other use full content. The menu fades away by all the distraction.

The lines in the background make the overall picture very busy, it seems like a lot is happening, but actually nothing is happening.

As a new visitor who never visits drupal.org I would just click the page away, it just scares me.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

On mobile view, the hero is cluttered against the message on the frontpage.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Will this be opt-out ? or Opt-in?

IS and code is now opt-out. So default the URL discovery option is enabled.

In #6 SeanB is suggesting to make it Opt-out.

If this option is not needed for Youtube and Vimeo and other big Oembed players I would suggest to make the option Opt-in.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Unfortunately in #227 Drastically improve the linking experience in CKEditor 5 Needs work the merge request is closed.
I can't reopen it in https://git.drupalcode.org/project/drupal/-/merge_requests/10361. Maybe someone with some extra permissions?

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Maybe we can convert this issue to a meta ticket holding all suggested child tickets?

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

This could be closed now #3257729 is in.

Feel free to re-open if it doesn't fix this problem.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Needed this path after we've got an error after upgrading the module

PHP Fatal error:  Declaration of Drupal\imageapi_optimize_webp\Controller\ImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style) must be compatible with Drupal\image\Controller\ImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style, string $required_derivative_scheme) in ..../web/modules/contrib/imageapi_optimize_webp/src/Controller/ImageStyleDownloadController.php on line 36

we are on php v 8.3.1
using D Core 10.3.6

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Is there a dependency on a specific version of webform in this change?

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Tested the merge request / patch.

Everything seems to work fine now!
Thank you for the quick response!

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

If you want to test a patch. Please use the most recent one from the merge request(s).

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Proposed resolution seems fine.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Thanx for reviewing.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Did you try the merge request ?

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Fixed all automated PHPCS

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

I will add it to the 3.x dev branch. thank you!

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Check, thank you! Still have to explore all those gitlab features🙈

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

🐛 Why is SvgImageWidget inheriting from FileWidget instead for ImageWidget? Active is also solving the same problem. Would be nice if the maintainer chose / close duplicates.

There are now 3 tickets that are trying to solve sort of the same problem.

Think 🐛 Why is SvgImageWidget inheriting from FileWidget instead for ImageWidget? Active would be the preferred one.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

It's recommended to use asset-packagist to install JavaScript libraries. Like bower-asset or npm-asset
Add the following to your composer.json file into the repositories section:

 {
        "type": "composer",
        "url": "https://asset-packagist.org"
    }

And extend the 'installer-path' section:

"web/libraries/{$name}": [
        "type:drupal-library",
        "type:bower-asset",
        "type:npm-asset"
    ],

And add a new 'installer-types' section next to the 'installer-path' in the 'extra' section:
"installer-types": ["bower-asset", "npm-asset"],

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Would be nice if the merge request is updated with the latest changes from #8

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

It seems that this is the Site e-mail adres in the 2.x version

You can find this under /admin/config/system/site-information/ -> E-mail.

 $default_from_email = \Drupal::config('system.site')->get('mail');

webform_email_reply/src/Form/WebformEmailReplyForm.php

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Apparently the merge request was at the wrong branch...

Fixed this issue at the 2.0 branch.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

ok then let's set focus to #20.

Hide all other files...

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

image styles have a convert task to create a different file format. That is Drupal Core functionality.
Did you use other modules as well? Such as Image Api or other contributed modules?
And is the image style working in just plain Drupal?
To much unknown to reproduce the issue.

Please share some more information about your situation. Now it is not clear it is a bug or something is missing in the configuration or caused by an other module or custom code... etc....

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Hiding all old patches

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Resolved merge conflicts after 📌 Convert FieldFormatter plugin discovery to attributes Active was committed.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

This is already in 10.2 @abelass

See: https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-... Why it is : "catch committed bcaa369c on 11.x"

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Feature plans: Make this module Drupal 10 proof.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

The field group module is already offering such "feature". More kind of a work around because things are not wel managed in core.

The issue ticket where that was developed: #2652642: Allow to position the group in the advanced (sidebar) column
Hope this ads some extra info / context.

Great to see some fresh conversations are there.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

I would like to take maintainer-ship off this module, if possible.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

it's the X its self that is not white, but it should always be when a black background color is used as circle.
see https://about.twitter.com/en/who-we-are/brand-toolkit

It is strange that this module is not using the original brand colors on all icons.
Same with Linkedin and Facebook. the F should be always white I guess.
(https://about.meta.com/brand/resources/facebook/logo/)
Maybe something for a flow-up to make other the logo's as they should be.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Thank you @samir_shukla, indeed this request needs more info.

Browser version. Drupal version. Other libraries when used.
Some screenshots of the browser console with error's

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

thank you for the help artemboiko. Renaming it to 10.2.x will make things clearer.

Drupal V 10.3 will be branched from 11.x. I don't this will land in 10.2.x because of the size and changes.
So I think all effort should be at the merge request for the 11.x branch.

I think we need al lot of people testing this, maybe a sign off from a (sub)core maintainer ?

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

We are developing the new version at the 3.x branch.
PHP part is roughly done. JS part has to be done.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

@manojbisht_drupal please use the merge request.

And if you need a patch, everyone can download a diff/patch from gitlab and load it local with composer.

(hide patches to get focus on merge request.)

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Martijn de Wit changed the visibility of the branch 2546212-entity-viewform-mode to hidden.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Martijn de Wit changed the visibility of the branch 11.x to hidden.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Why using the patch from #48?

There is a merge request that is far more recent? containing solution after several discussions with good points ..

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

xmacinfo did you already try the new theme/template generator in Drupal ?

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands
🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Realy like this feature.

Patch works as advertised.

Only asking my self if this could be done with permission. Because there are different permission for for voting up or voting down. Would make more sense to me to use those, then an extra option.

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

Add Media revision UI Fixed is committed to core 10.2 that will be released end this year

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

The fact that no one is responding to your question doesn't mean the module is not maintained anymore.

To start with, if you want someone to help you, please add a proper test path.
Maybe some screenshots or a short video of your configuration.

Reading your question; is resulting in a lot of other questions.

  • How did you configure the node display settings.
  • how did you configure the field display settings.
  • what kind of drupal theme are you using
  • Are you using the repsonsive image module
  • How did you configure the image styles.
  • etc..
🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

set to needs review, because there is a patch / merge request.

Hide patch in favour for merge request

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

set to needs review because there is a patch
and remove assignee

🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands

ran into this issue. Patch seems to fix te problem.

Maybe some extra white space between these two fields:

Production build 0.71.5 2024