Make it possible to install dependent modules when installing theme

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

This is a definite DrupalWTF as theme builders should expect that listing a module as a dependency of their theme would make it work the same as on another module.

Working on a reroll.

Rerolled, hopefully successfully; the only part I'm not 100% about are the changes to core/lib/Drupal/Core/Extension/ThemeInstaller.php, some refactoring had already been done there on another issue.

Patch #23 was against 9.5.x. This patch is for 10.1.x

Things have been deprecated in the time that passed since the last working patch ⏰⏰⏰⏰💀

Seems there were some failures.

Love the idea though as I would make my themes require the components module.

I believe some (maybe all) of the remaining test failures are due to #3215043: Indicate the non-stable statuses in admin/modules page → . This made some nice changes to the module form experience, but will require the logic in this issue to be updated to account for the differences.

Our install profile has a base theme that requires modules, and we realized because of this issue, our install profile cannot be installed anymore because the installer installs themes before modules. I would say this is a bug more than a feature request at this point.

Switching to bug per #30.

ivnish → changed the visibility of the branch 11.x to hidden.

MR for Drupal 11 is 90% ready. Needs to fix some phpstan issues. I don't have time to deal with this task anymore.

thank you for all the work @ivnish ! 🙏

nicxvan → changed the visibility of the branch 3100374 to hidden.

nicxvan → changed the visibility of the branch 3100374-make-it-possible to hidden.

I'll take a look.

Addressed the phpstan issues in the new extensionconfirm form. Added some items to the remaining tasks.

Still needs work.

I think there might be something missing for uninstalling modules when a theme is enabled, I didn't look close enough. We do need to handle the forms extending the newly deprecated form, and most likely create new ones.

Ok I fixed the CS errors.

I also undid the module confirm deprecation because extension confirmation doesn't cover what moduleslistunstableconfirmform needs.

This probably needs some additional work, but I think tests will run.