The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Assigned to DamienMcKenna
- 🇺🇸United States DamienMcKenna NH, USA
This is a definite DrupalWTF as theme builders should expect that listing a module as a dependency of their theme would make it work the same as on another module.
Working on a reroll.
- Status changed to Needs review
almost 2 years ago 4:20pm 1 February 2023 - 🇺🇸United States DamienMcKenna NH, USA
Rerolled, hopefully successfully; the only part I'm not 100% about are the changes to core/lib/Drupal/Core/Extension/ThemeInstaller.php, some refactoring had already been done there on another issue.
- Issue was unassigned.
- 🇺🇸United States DamienMcKenna NH, USA
Patch #23 was against 9.5.x. This patch is for 10.1.x
- 🇺🇸United States bnjmnm Ann Arbor, MI
Things have been deprecated in the time that passed since the last working patch ⏰⏰⏰⏰💀
- Status changed to Needs work
almost 2 years ago 3:11am 4 February 2023 - 🇺🇸United States smustgrave
Seems there were some failures.
Love the idea though as I would make my themes require the components module.
- 🇺🇸United States bnjmnm Ann Arbor, MI
I believe some (maybe all) of the remaining test failures are due to #3215043: Indicate the non-stable statuses in admin/modules page → . This made some nice changes to the module form experience, but will require the logic in this issue to be updated to account for the differences.
- 🇺🇸United States dave reid Nebraska USA
Our install profile has a base theme that requires modules, and we realized because of this issue, our install profile cannot be installed anymore because the installer installs themes before modules. I would say this is a bug more than a feature request at this point.