- Issue created by @larowlan
- 🇳🇱Netherlands seanB Netherlands
This looks good to me! The URL discovery is weird and hopefully we can get rid of this completely in the future. But that should probably be another issue.
Since there is no UI, we probably also need a change record to describe how users can enable the URL discovery again (at least until this is moved to contrib).
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Needs a re-roll and I think we need a CR to document the functionality as it is pretty hidden. Given the default is TRUE there's no behaviour change to new or existing sites here BUT it is nice to tell people about this functionality.
- First commit to issue fork.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
The last fails look relevant as they are about the deprecate this introduces.
- 🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands
Will this be opt-out ? or Opt-in?
IS and code is now opt-out. So default the URL discovery option is enabled.
In #6 SeanB is suggesting to make it Opt-out.
If this option is not needed for Youtube and Vimeo and other big Oembed players I would suggest to make the option Opt-in.
- 🇺🇸United States smustgrave
Applied the MR locally
Update hook ran fine without issue
Test coverage appears to be present
I'm hoping we can get this into 11.1! - 🇬🇧United Kingdom longwave UK
Re #12 we could opt-in existing sites so the behaviour does not change when upgrading, but for new installs we could opt-out by default?
-
alexpott →
committed a0a28bdd on 11.x
Issue #3438618 by larowlan, longwave, alexpott, martijn de wit,...
-
alexpott →
committed a0a28bdd on 11.x
-
alexpott →
committed ec449c04 on 11.x
Revert "Issue #3438618 by larowlan, longwave, alexpott, martijn de wit,...
-
alexpott →
committed ec449c04 on 11.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Turns out that @larowlan, @longwave and @catch were discussing whether we should enable the functionality in the media module. Reverting so we can make a decision about which way to go.
- 🇺🇸United States smustgrave
You mean if to opt in by default?
If the goal is to keep it as is I would say it should be set to true.
But if the goal is to eventually remove this check then I would set to know to make it easier to phase out.Only mention that as I've lost track of the number of tickets floating around regarding removal of this status report message at least.
- 🇬🇧United Kingdom longwave UK
Discussed this with @larowlan and @benjifisher. We think the safest option is to move this feature to a submodule, and leave it disabled by default on either new or existing sites. We can mention in the release notes that OEmbed discovery has been moved to a submodule and can be enabled separately, and also as a usability improvement we could suggest installing the module if OEmbed fails in a way that might be because discovery is required.
