- Issue created by @mably
- Merge request !28Issue #3420037: have SvgImageWidget inherit from ImageWidget instead of FileWidget → (Closed) created by mably
- Status changed to Needs review
11 months ago 3:04pm 13 February 2024 - 🇧🇪Belgium herved
Coming from 📌 Replace upload validators with new ones introduced in Drupal 10.2 RTBC as we are having duplicate extensions descriptions as well on our project.
This issue makes more sense to me and looks like a much cleaner way to add SVG support.
Tested on core 10.2, works perfectly, thank you.Only 2 minor nits:
1. There is a typo in comments: Druapal > Drupal
2. I think the plugin annotation shouldn't be there assvg_image_field_formatter_info_alter()already registers the class. But this is probably not directly related to this issue. - 🇺🇸United States mortona2k Seattle
I applied the latest commit, but I still see the duplicate allowed types. Would the ticket in #8 need to be rebuilt on this one to fix that?
Anything I can help with?
- 🇫🇷France mably
Allowed types are not displayed twice when using this issue MR:
- 🇺🇸United States mortona2k Seattle
You're right, I must have had my wires crossed in testing.
The change looks good to me, ripping out a bunch of stuff that duplicates what ImageWidget does.
Looks like you handled the validators from #3413668.
I think it's RBTC, just looking for confirmation.
- 🇧🇷Brazil Lucas Fernandes
Hey everyone,
I was having the same issue and this fix it worked for me as well.
Thanks for this.
- Status changed to RTBC
9 months ago 9:16pm 11 April 2024 - 🇧🇷Brazil murilohp
That's great, here's a static patch to be applied on composer
- First commit to issue fork.
- 🇫🇷France Grimreaper France 🇫🇷
Hi,
Coming from 🐛 Allowed type text is duplicated in the back end of image field Active , then #3413668-38: Replace upload validators with new ones introduced in Drupal 10.2 → .
MR fixed the issue. Thanks!!!
Uploading patch for Composer usage.
- Merge request !35Issue #3420037: SvgImageWidget should inherit from ImageWidget instead of FileWidget → (Merged) created by mably
- First commit to issue fork.
- 🇩🇪Germany Grevil
Great and important rewrite! I just renamed a variable and adjusted a comment. Works great! Just did some manual testing and debugging.
I thought about adding an update hook to rebuild the kernel, since the dependency injection "kinda" changed (as we get the injected dependencies from the parent now), but since the dependencies itself did not change and there seems to be no issue switching versions, I'd vote against that.
Time to get this merged! Thanks everybody! Great work! 💪
Automatically closed - issue fixed for 2 weeks with no activity.