- First commit to issue fork.
- Status changed to Needs review
almost 2 years ago 5:24pm 20 February 2023 - π«π·France Fabsgugu
I fixed both issues and updated the Merge Request.
- last update
over 1 year ago 158 pass - π©πͺGermany hchonov πͺπΊπ©πͺπ§π¬
We stumbled upon an issue where the calculated dimensions were not rounded as integer numbers so this patch is fixing this.
- π³π±Netherlands Martijn de Wit π³π± The Netherlands
All code after #11, doesn't allow an empty value.
This removes the 'arbitrary aspect ratio' feature. Don't know if this is a required feature for this functionality.
- π©πͺGermany majid.ali
If entered wrong aspect ratio #13 throws an error. The aspect ratio needs to be validated before saving. I therefore updated #13 with it.
- π©πͺGermany hchonov πͺπΊπ©πͺπ§π¬
Re #3186353-14: Image effect to crop by aspect ratio only β
This removes the 'arbitrary aspect ratio' feature. Don't know if this is a required feature for this functionality.
yes, it is a required since this is the main idea of the image effect - to crop by aspect ratio.
- π¨πΏCzech Republic myst1c
Iβve reviewed and tested the patch, and Iβve had it working in a project for a while now.
- π¬π·Greece giorgosk Chios, Greece π¬π·
Tested on an existing project similar to steps by @myst1c and all works as expected
- π³π±Netherlands Martijn de Wit π³π± The Netherlands
Are your tests all based on the patch in #15 ?
We are using #15 now and it works perfect